[GitHub] mcvsubbu commented on a change in pull request #3633: Use ZkCacheBaseDataAccessor to cache instance configs in PinotHelixResourceManager

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #3633: Use ZkCacheBaseDataAccessor to cache instance configs in PinotHelixResourceManager
URL: https://github.com/apache/incubator-pinot/pull/3633#discussion_r244893566
 
 

 ##########
 File path: pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/core/PinotHelixResourceManager.java
 ##########
 @@ -276,6 +295,11 @@ public Builder getKeyBuilder() {
    */
   @Nonnull
   public InstanceConfig getHelixInstanceConfig(@Nonnull String instanceId) {
+    if (_cacheInstanceConfigsDataAccessor != null) {
+      LOGGER.info("Get instance config for instance {} from cluster {}.", instanceId, _helixClusterName);
 
 Review comment:
   Change this to debug log, or remove it altogether please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org