You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "vrahane (via GitHub)" <gi...@apache.org> on 2024/07/08 18:46:39 UTC
Re: [PR] sys/log: Add number of entries support in log [mynewt-core]
vrahane commented on code in PR #3168:
URL: https://github.com/apache/mynewt-core/pull/3168#discussion_r1669114077
##########
sys/log/full/include/log/log.h:
##########
@@ -97,6 +97,7 @@ typedef int (*lh_append_mbuf_body_func_t)(struct log *log,
typedef int (*lh_walk_func_t)(struct log *,
log_walk_func_t walk_func, struct log_offset *log_offset);
typedef int (*lh_flush_func_t)(struct log *);
+typedef uint16_t (*lh_read_entry_len_func_t)(struct log *, const void *dptr);
Review Comment:
Yes, it is, do you want me to fix it ? Just say so. This is a PR to add support for a targeted feature. In the past we would open separate PRs for refactoring Vs changes made for a feature. I can change it in a separate PR later. cc: @sjanc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org