You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/23 07:39:12 UTC
[GitHub] [kafka] guozhangwang opened a new pull request #10380: KAFKA-12527: Remove deprecated PartitionGrouper
guozhangwang opened a new pull request #10380:
URL: https://github.com/apache/kafka/pull/10380
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a change in pull request #10380: KAFKA-12527: Remove deprecated PartitionGrouper
Posted by GitBox <gi...@apache.org>.
mjsax commented on a change in pull request #10380:
URL: https://github.com/apache/kafka/pull/10380#discussion_r602915785
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultPartitionGrouper.java
##########
@@ -31,16 +32,13 @@
import java.util.Set;
/**
- * Default implementation of the {@link PartitionGrouper} interface that groups partitions by the partition id.
+ * Groups partitions by the partition id.
*
* Join operations requires that topics of the joining entities are copartitoned, i.e., being partitioned by the same key and having the same
* number of partitions. Copartitioning is ensured by having the same number of partitions on
* joined topics, and by using the serialization and Producer's default partitioner.
- *
- * @deprecated since 2.4 release; will be removed in 3.0.0 via KAFKA-7785
*/
-@Deprecated
-public class DefaultPartitionGrouper implements PartitionGrouper {
+public class DefaultPartitionGrouper {
Review comment:
Should we rename this to `PartitionGrouper` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang merged pull request #10380: KAFKA-12527: Remove deprecated PartitionGrouper annotation
Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #10380:
URL: https://github.com/apache/kafka/pull/10380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org