You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@twill.apache.org by chtyim <gi...@git.apache.org> on 2016/01/06 08:46:59 UTC
[GitHub] incubator-twill pull request: Fix an easy to fail unit-test
GitHub user chtyim opened a pull request:
https://github.com/apache/incubator-twill/pull/77
Fix an easy to fail unit-test
- The test has race condition. The mutual discovery
doesn’t works well as one runnable can be finished
and not discoverable anymore before another one
tries to discover.
- Switch to use an Echo server / client runnable,
which only the client needs to discover the server.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/incubator-twill feature/fix-unit-test-race-condition
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-twill/pull/77.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #77
----
commit f1c6a59fd277227bbac1a25dab034d964d6506bb
Author: Terence Yim <ch...@apache.org>
Date: 2016-01-06T07:46:06Z
Fix an easy to fail unit-test
- The test has race condition. The mutual discovery
doesn’t works well as one runnable can be finished
and not discoverable anymore before another one
tries to discover.
- Switch to use an Echo server / client runnable,
which only the client needs to discover the server.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: Fix an easy to fail unit-test
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-twill/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: Fix an easy to fail unit-test
Posted by poornachandra <gi...@git.apache.org>.
Github user poornachandra commented on the pull request:
https://github.com/apache/incubator-twill/pull/77#issuecomment-169528098
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---