You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2017/04/20 16:21:54 UTC
Review Request 58578: Log Search REST API calls for configuration
should send proper error responses
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58578/
-----------------------------------------------------------
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Bugs: AMBARI-20807
https://issues.apache.org/jira/browse/AMBARI-20807
Repository: ambari
Description
-------
In case of a REST API call for configuration the error response should be in the proper format if the configuration is not available yet.
Also removed some unused codes.
Also modified REST API paths to have a cleaner structure
Diffs
-----
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/MessageEnums.java 4f1725f
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java 2f9cba4
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java 251619b
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java 38821bc
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogSearchConfigStateFilter.java PRE-CREATION
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_config_aggregator.py c14900e
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 84a6ad9
Diff: https://reviews.apache.org/r/58578/diff/1/
Testing
-------
Tested on local cluster
Thanks,
Miklos Gergely
Re: Review Request 58578: Log Search REST API calls for configuration
should send proper error responses
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58578/#review172785
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On April 20, 2017, 4:21 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58578/
> -----------------------------------------------------------
>
> (Updated April 20, 2017, 4:21 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-20807
> https://issues.apache.org/jira/browse/AMBARI-20807
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In case of a REST API call for configuration the error response should be in the proper format if the configuration is not available yet.
>
> Also removed some unused codes.
> Also modified REST API paths to have a cleaner structure
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/MessageEnums.java 4f1725f
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java 2f9cba4
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java 251619b
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java 38821bc
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogSearchConfigStateFilter.java PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_config_aggregator.py c14900e
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 84a6ad9
>
>
> Diff: https://reviews.apache.org/r/58578/diff/1/
>
>
> Testing
> -------
>
> Tested on local cluster
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 58578: Log Search REST API calls for configuration
should send proper error responses
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58578/
-----------------------------------------------------------
(Updated April 25, 2017, 1:07 p.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Changes
-------
Added javadoc for the new Filter class
Bugs: AMBARI-20807
https://issues.apache.org/jira/browse/AMBARI-20807
Repository: ambari
Description
-------
In case of a REST API call for configuration the error response should be in the proper format if the configuration is not available yet.
Also removed some unused codes.
Also modified REST API paths to have a cleaner structure
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/MessageEnums.java 4f1725f
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java 2f9cba4
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java 251619b
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java 38821bc
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogSearchConfigStateFilter.java PRE-CREATION
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_config_aggregator.py c14900e
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py bfe0c0d
Diff: https://reviews.apache.org/r/58578/diff/2/
Changes: https://reviews.apache.org/r/58578/diff/1-2/
Testing
-------
Tested on local cluster
Thanks,
Miklos Gergely
Re: Review Request 58578: Log Search REST API calls for configuration
should send proper error responses
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58578/#review172510
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On April 20, 2017, 4:21 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58578/
> -----------------------------------------------------------
>
> (Updated April 20, 2017, 4:21 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-20807
> https://issues.apache.org/jira/browse/AMBARI-20807
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In case of a REST API call for configuration the error response should be in the proper format if the configuration is not available yet.
>
> Also removed some unused codes.
> Also modified REST API paths to have a cleaner structure
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/MessageEnums.java 4f1725f
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java 2f9cba4
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java 251619b
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java 38821bc
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogSearchConfigStateFilter.java PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_config_aggregator.py c14900e
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 84a6ad9
>
>
> Diff: https://reviews.apache.org/r/58578/diff/1/
>
>
> Testing
> -------
>
> Tested on local cluster
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 58578: Log Search REST API calls for configuration
should send proper error responses
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58578/#review172811
-----------------------------------------------------------
Fix it, then Ship it!
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogSearchConfigStateFilter.java
Lines 43 (patched)
<https://reviews.apache.org/r/58578/#comment245854>
Add Javadoc.
- Alejandro Fernandez
On April 20, 2017, 4:21 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58578/
> -----------------------------------------------------------
>
> (Updated April 20, 2017, 4:21 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-20807
> https://issues.apache.org/jira/browse/AMBARI-20807
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In case of a REST API call for configuration the error response should be in the proper format if the configuration is not available yet.
>
> Also removed some unused codes.
> Also modified REST API paths to have a cleaner structure
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/MessageEnums.java 4f1725f
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java 2f9cba4
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java 251619b
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java 38821bc
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogSearchConfigStateFilter.java PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_config_aggregator.py c14900e
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 84a6ad9
>
>
> Diff: https://reviews.apache.org/r/58578/diff/1/
>
>
> Testing
> -------
>
> Tested on local cluster
>
>
> Thanks,
>
> Miklos Gergely
>
>