You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2017/09/29 22:29:00 UTC
[jira] [Commented] (ASTERIXDB-2096)
IntroduceDynamicTypeCastForExternalFunctionRule is not working properly for
function call in nested record
[ https://issues.apache.org/jira/browse/ASTERIXDB-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186610#comment-16186610 ]
ASF subversion and git services commented on ASTERIXDB-2096:
------------------------------------------------------------
Commit 0535526938220d0cfab90d5a8921e64694f721cf in asterixdb's branch refs/heads/master from [~idleft]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=0535526 ]
[ASTERIXDB-2096][COMP] Fix type casting for ExternalFunction
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
1. The current IntroduceDynamicTypeCastForExternalFunctionRule
cannot handle external function calls in nested record constructor.
This patch fix this issue by visiting all nested parameters for
external functions.
2. The ResultExtractor should be able to handle multiple queries
in single statement file as AQL does.
Change-Id: I65c298def75b18fab01f513012e28fc44fdc2fd4
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2010
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Contrib: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Dmitry Lychagin <dm...@couchbase.com>
> IntroduceDynamicTypeCastForExternalFunctionRule is not working properly for function call in nested record
> ----------------------------------------------------------------------------------------------------------
>
> Key: ASTERIXDB-2096
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2096
> Project: Apache AsterixDB
> Issue Type: Bug
> Reporter: Xikui Wang
>
> The current type casting rule for ExternalFunction cannot handle when we put function call into a record. The reason is this only checks AssignOp with external function call on its right side. In reality, the function call can be put in an open record constructor which is a builtin function. Also, similar casting rule should be applied to all parameter of the external function in case of recursive calling.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)