You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/02/21 14:05:01 UTC
[GitHub] [incubator-mxnet] RafLit opened a new pull request #20903: Jinja upgrade
RafLit opened a new pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903
## Description ##
The CI is failing due to Jinja version being unsupported:
https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Fwebsite/detail/PR-20899/1/pipeline/
Pinned the new version of the package to fix the issue.
Related issue:
https://github.com/pallets/jinja/issues/1585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20903: CI fixes
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903#issuecomment-1049190664
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20903: Jinja upgrade
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903#issuecomment-1047153530
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20903: Jinja upgrade
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903#issuecomment-1047284273
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20903: Jinja upgrade
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903#issuecomment-1047153568
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #20903: CI fixes
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903#issuecomment-1048585173
@mxnet-bot run ci [unix-gpu, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20903: CI fixes
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903#issuecomment-1049269830
please restart linkcheck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DickJC123 commented on pull request #20903: Jinja upgrade
Posted by GitBox <gi...@apache.org>.
DickJC123 commented on pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903#issuecomment-1047308680
I ran into this issue in my own PR https://github.com/apache/incubator-mxnet/pull/20876. If you decide you don't want to upgrade Jinja2, I found that adding this requirement:
```
MarkupSafe==2.0.1
```
also solves the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20903: CI fixes
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903#issuecomment-1049190757
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20903: Jinja upgrade
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903#issuecomment-1046914236
Hey @RafLit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-gpu, website, unix-cpu, windows-cpu, centos-cpu, centos-gpu, miscellaneous, unix-gpu, sanity, clang, edge]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20903: CI fixes
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903#issuecomment-1049209738
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20903: Jinja upgrade
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903#issuecomment-1048271038
> I see that this upgrade of Jinja2 from 2.11.3 to 3.0.3 indeed solves the import error. But, since the upgrade is in theory a breaking change, is there a way to confirm that Jinja2 continues to work as needed for MXNet?
You're right - this might need further verification. Adding the MarkupSafe dependency isn't a clean solution either as we don't depend directly on it - Jinja does. So I would see it as a temporary solution to fix the CI problems while we switch to a supported version of Jinja.
@szha I would appreciate your opinion on this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20903: CI fixes
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903#issuecomment-1048585262
Jenkins CI successfully triggered : [unix-gpu, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #20903: Jinja upgrade
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903#issuecomment-1047988848
Can you also remove broken reference to https://ts.gluon.ai/ in docs/python_docs/python/tutorials/getting-started/crash-course/7-use-gpus.md ?
Jinja upgrade/MarkupSafe freeze and removing this link are both needed to unblock CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20903: Jinja upgrade
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903#issuecomment-1047284333
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20903: CI fixes
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903#issuecomment-1049164917
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] RafLit commented on pull request #20903: CI fixes
Posted by GitBox <gi...@apache.org>.
RafLit commented on pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903#issuecomment-1049164834
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DickJC123 commented on pull request #20903: CI fixes
Posted by GitBox <gi...@apache.org>.
DickJC123 commented on pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903#issuecomment-1048999205
Regarding the ts.gluon.ai problem, since we want to reference the link once it works, my approach was to lean on them to fix the problem (see https://github.com/awslabs/gluon-ts/issues/1901). At this point, they have fixed the issue (at least to the point of removing the error).
As proof of the fix, on a side PR of mine, without any link fixes, linkcheck now passes: https://github.com/apache/incubator-mxnet/runs/5299064848?check_suite_focus=true
Are you willing to remove the link check fix from this PR, now that it is no longer needed?
And regarding the Jinja2 import issue, I prefer the approach you've taken here- simpler than adding the MarkupSafe pinning that I explored. I vote for accepting this PR, and follow up with a different fix only if someone notices the docs are wrong because of the new Jinja2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DickJC123 merged pull request #20903: CI fixes
Posted by GitBox <gi...@apache.org>.
DickJC123 merged pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DickJC123 commented on pull request #20903: Jinja upgrade
Posted by GitBox <gi...@apache.org>.
DickJC123 commented on pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903#issuecomment-1048162917
I see that this upgrade of Jinja2 from 2.11.3 to 3.0.3 indeed solves the import error. But, since the upgrade is in theory a breaking change, is there a way to confirm that Jinja2 continues to work as needed for MXNet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20903: CI fixes
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20903:
URL: https://github.com/apache/incubator-mxnet/pull/20903#issuecomment-1049209786
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org