You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/06/20 12:12:21 UTC
[GitHub] [pulsar] jiazhai commented on a change in pull request #4567: Add
missing debezium-postgres connector in distribution
jiazhai commented on a change in pull request #4567: Add missing debezium-postgres connector in distribution
URL: https://github.com/apache/pulsar/pull/4567#discussion_r295775991
##########
File path: distribution/io/src/assemble/io.xml
##########
@@ -65,5 +65,6 @@
<file><source>${basedir}/../../pulsar-io/netty/target/pulsar-io-netty-${project.version}.nar</source></file>
<file><source>${basedir}/../../pulsar-io/mongo/target/pulsar-io-mongo-${project.version}.nar</source></file>
<file><source>${basedir}/../../pulsar-io/debezium/mysql/target/pulsar-io-debezium-mysql-${project.version}.nar</source></file>
+ <file><source>${basedir}/../../pulsar-io/debezium/postgres/target/pulsar-io-debezium-postgres-${project.version}.nar</source></file>
Review comment:
nit: alignment issue: use `space` instead of `tab`.
```suggestion
<file><source>${basedir}/../../pulsar-io/debezium/postgres/target/pulsar-io-debezium-postgres-${project.version}.nar</source></file>
```
use space instead of tab to make it align
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services