You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org> on 2016/10/12 11:36:20 UTC

[jira] [Created] (BEAM-743) JdbcIO should not use getConnection() with username and password when using DBCP BasicDataSource

Jean-Baptiste Onofré created BEAM-743:
-----------------------------------------

             Summary: JdbcIO should not use getConnection() with username and password when using DBCP BasicDataSource
                 Key: BEAM-743
                 URL: https://issues.apache.org/jira/browse/BEAM-743
             Project: Beam
          Issue Type: Bug
          Components: sdk-java-extensions
            Reporter: Jean-Baptiste Onofré
            Assignee: Jean-Baptiste Onofré


When we use an username and password, {{JdbcIO}} uses {{dataSource.getConnection(username, password)}}.
However, this method is not supported by DBCP {{BasicDataSource}} (as the username and password are already part of the data source).

Basically, the test should be if username is not null and if datasource (user provided) is not null, then we use {{getConnection(username, password)}} else, we just use {{getConnection()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)