[GitHub] [maven-resolver] cstamas opened a new pull request #107: Update maven in demos

[GitBox <gi...@apache.org>]

cstamas opened a new pull request #107:
URL: https://github.com/apache/maven-resolver/pull/107


   Use latest Maven in Resolver Demos.
   
   Note: something is fishy (in maven-resolver-provider), as to make all this work I had to copy the Guice Module here and alter it.
   
   WIP


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-resolver] michael-o commented on a change in pull request #107: Update maven in demos

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #107:
URL: https://github.com/apache/maven-resolver/pull/107#discussion_r650575265



##########
File path: maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/guice/DemoResolverModule.java
##########
@@ -39,6 +50,9 @@
 
 /**
  * Guice module for Demo Resolver snippets.
+ *
+ * Here, we assemble "complete" module by using {@link AetherModule} (see it's Javadoc) and adding bits from

Review comment:
       No apostrophe 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-resolver] asfgit closed pull request #107: Update maven in demos

[GitBox <gi...@apache.org>]

asfgit closed pull request #107:
URL: https://github.com/apache/maven-resolver/pull/107


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org