You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/02/04 03:35:42 UTC
[GitHub] [lucene] jtibshirani opened a new pull request #645: Rename KnnGraphValues -> HnswGraph
jtibshirani opened a new pull request #645:
URL: https://github.com/apache/lucene/pull/645
This PR proposes some renames to clarify the code structure. The top-level
`KnnGraphValues` is renamed to `HnswGraph`, since it now represents a
hierarchical graph. It's also moved from `org.apache.lucene.index` to the
`hnsw` package.
Other renames:
* The old `HnswGraph` -> `OnHeapHnswGraph`
* `IndexedKnnGraphValues` -> `OffHeapHnswGraph` (to match
`OffHeapVectorValues`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jtibshirani commented on pull request #645: Rename KnnGraphValues -> HnswGraph
Posted by GitBox <gi...@apache.org>.
jtibshirani commented on pull request #645:
URL: https://github.com/apache/lucene/pull/645#issuecomment-1031710996
Thanks for the review! My understanding is that `git mv` is the same as `git rm` and `git add`. It doesn't give special information to git (instead git automatically detects renames by comparing the file contents). So I am not sure it would help 🤔 I guess an alternative would be to merge it as two separate commits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #645: Rename KnnGraphValues -> HnswGraph
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #645:
URL: https://github.com/apache/lucene/pull/645#issuecomment-1031849263
> It doesn't give special information to git (instead git automatically detects renames by comparing the file contents).
Correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jtibshirani merged pull request #645: Rename KnnGraphValues -> HnswGraph
Posted by GitBox <gi...@apache.org>.
jtibshirani merged pull request #645:
URL: https://github.com/apache/lucene/pull/645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org