You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2015/01/31 13:01:54 UTC

[27/50] incubator-kylin git commit: fix warnings

fix warnings


Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/409a2b7d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/409a2b7d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/409a2b7d

Branch: refs/heads/inverted-index
Commit: 409a2b7d8fc33dda02886d30111db3294db96aa5
Parents: a6dca0d
Author: Li, Yang <ya...@ebay.com>
Authored: Wed Jan 28 17:29:50 2015 +0800
Committer: Li, Yang <ya...@ebay.com>
Committed: Wed Jan 28 17:29:50 2015 +0800

----------------------------------------------------------------------
 cube/src/test/java/com/kylinolap/cube/CubeDescTest.java   |  6 +++---
 .../java/com/kylinolap/cube/CubeManagerCacheTest.java     |  8 ++++----
 .../src/test/java/com/kylinolap/cube/CubeManagerTest.java | 10 +++++-----
 .../com/kylinolap/cube/CubeSizeEstimationCLITest.java     |  2 +-
 .../java/com/kylinolap/cube/DictionaryManagerTest.java    |  4 ++--
 .../com/kylinolap/cube/common/RowKeySplitterTest.java     |  6 +++---
 .../com/kylinolap/cube/cuboid/CuboidSchedulerTest.java    |  2 +-
 .../java/com/kylinolap/cube/kv/RowKeyDecoderTest.java     |  8 ++++----
 .../java/com/kylinolap/cube/kv/RowKeyEncoderTest.java     |  8 ++++----
 .../java/com/kylinolap/cube/kv/RowValueDecoderTest.java   |  4 ++--
 .../com/kylinolap/cube/project/ProjectManagerTest.java    |  4 ++--
 11 files changed, 31 insertions(+), 31 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/409a2b7d/cube/src/test/java/com/kylinolap/cube/CubeDescTest.java
----------------------------------------------------------------------
diff --git a/cube/src/test/java/com/kylinolap/cube/CubeDescTest.java b/cube/src/test/java/com/kylinolap/cube/CubeDescTest.java
index cf9ab4b..7d41619 100644
--- a/cube/src/test/java/com/kylinolap/cube/CubeDescTest.java
+++ b/cube/src/test/java/com/kylinolap/cube/CubeDescTest.java
@@ -46,7 +46,7 @@ public class CubeDescTest extends LocalFileMetadataTestCase {
 
     @Test
     public void testSerialize() throws Exception {
-        CubeDesc desc = CubeDescManager.getInstance(this.getTestConfig()).getCubeDesc("test_kylin_cube_with_slr_desc");
+        CubeDesc desc = CubeDescManager.getInstance(getTestConfig()).getCubeDesc("test_kylin_cube_with_slr_desc");
         String str = JsonUtil.writeValueAsIndentString(desc);
         System.out.println(str);
         @SuppressWarnings("unused")
@@ -55,7 +55,7 @@ public class CubeDescTest extends LocalFileMetadataTestCase {
 
     @Test
     public void testGetCubeDesc() throws Exception {
-        CubeDesc cubeDesc = CubeDescManager.getInstance(this.getTestConfig()).getCubeDesc("test_kylin_cube_with_slr_desc");
+        CubeDesc cubeDesc = CubeDescManager.getInstance(getTestConfig()).getCubeDesc("test_kylin_cube_with_slr_desc");
         Assert.assertNotNull(cubeDesc);
     }
     
@@ -70,7 +70,7 @@ public class CubeDescTest extends LocalFileMetadataTestCase {
         
         System.out.println(mapStr);
         
-        Map map2 = JsonUtil.readValue(mapStr, HashMap.class);
+        Map<?, ?> map2 = JsonUtil.readValue(mapStr, HashMap.class);
         
         Assert.assertEquals(map, map2);
         

http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/409a2b7d/cube/src/test/java/com/kylinolap/cube/CubeManagerCacheTest.java
----------------------------------------------------------------------
diff --git a/cube/src/test/java/com/kylinolap/cube/CubeManagerCacheTest.java b/cube/src/test/java/com/kylinolap/cube/CubeManagerCacheTest.java
index 9908ac2..b444d45 100644
--- a/cube/src/test/java/com/kylinolap/cube/CubeManagerCacheTest.java
+++ b/cube/src/test/java/com/kylinolap/cube/CubeManagerCacheTest.java
@@ -40,10 +40,10 @@ public class CubeManagerCacheTest extends LocalFileMetadataTestCase {
     @Before
     public void setUp() throws Exception {
         this.createTestMetadata();
-        MetadataManager.removeInstance(this.getTestConfig());
-        CubeManager.removeInstance(this.getTestConfig());
-        ProjectManager.removeInstance(this.getTestConfig());
-        cubeManager = CubeManager.getInstance(this.getTestConfig());
+        MetadataManager.removeInstance(getTestConfig());
+        CubeManager.removeInstance(getTestConfig());
+        ProjectManager.removeInstance(getTestConfig());
+        cubeManager = CubeManager.getInstance(getTestConfig());
     }
 
     @After

http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/409a2b7d/cube/src/test/java/com/kylinolap/cube/CubeManagerTest.java
----------------------------------------------------------------------
diff --git a/cube/src/test/java/com/kylinolap/cube/CubeManagerTest.java b/cube/src/test/java/com/kylinolap/cube/CubeManagerTest.java
index 8339dfa..cb1a99b 100644
--- a/cube/src/test/java/com/kylinolap/cube/CubeManagerTest.java
+++ b/cube/src/test/java/com/kylinolap/cube/CubeManagerTest.java
@@ -40,9 +40,9 @@ public class CubeManagerTest extends LocalFileMetadataTestCase {
     @Before
     public void setUp() throws Exception {
         this.createTestMetadata();
-        MetadataManager.removeInstance(this.getTestConfig());
-        CubeManager.removeInstance(this.getTestConfig());
-        ProjectManager.removeInstance(this.getTestConfig());
+        MetadataManager.removeInstance(getTestConfig());
+        CubeManager.removeInstance(getTestConfig());
+        ProjectManager.removeInstance(getTestConfig());
     }
 
     @After
@@ -79,12 +79,12 @@ public class CubeManagerTest extends LocalFileMetadataTestCase {
 
         assertTrue(prjMgr.listAllRealizations(ProjectInstance.DEFAULT_PROJECT_NAME).contains(createdCube));
 
-        CubeInstance droppedCube = CubeManager.getInstance(this.getTestConfig()).dropCube("a_whole_new_cube", true);
+        CubeInstance droppedCube = CubeManager.getInstance(getTestConfig()).dropCube("a_whole_new_cube", true);
         assertTrue(createdCube == droppedCube);
 
         assertTrue(!prjMgr.listAllRealizations(ProjectInstance.DEFAULT_PROJECT_NAME).contains(droppedCube));
 
-        assertNull(CubeManager.getInstance(this.getTestConfig()).getCube("a_whole_new_cube"));
+        assertNull(CubeManager.getInstance(getTestConfig()).getCube("a_whole_new_cube"));
     }
 
     public CubeDescManager getCubeDescManager() {

http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/409a2b7d/cube/src/test/java/com/kylinolap/cube/CubeSizeEstimationCLITest.java
----------------------------------------------------------------------
diff --git a/cube/src/test/java/com/kylinolap/cube/CubeSizeEstimationCLITest.java b/cube/src/test/java/com/kylinolap/cube/CubeSizeEstimationCLITest.java
index a6ee956..404daf9 100644
--- a/cube/src/test/java/com/kylinolap/cube/CubeSizeEstimationCLITest.java
+++ b/cube/src/test/java/com/kylinolap/cube/CubeSizeEstimationCLITest.java
@@ -21,7 +21,7 @@ public class CubeSizeEstimationCLITest extends LocalFileMetadataTestCase {
     @Before
     public void setUp() throws Exception {
         this.createTestMetadata();
-        MetadataManager.removeInstance(this.getTestConfig());
+        MetadataManager.removeInstance(getTestConfig());
 
         String cubeName = "test_kylin_cube_with_slr_ready";
         CubeManager cubeManager = CubeManager.getInstance(getTestConfig());

http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/409a2b7d/cube/src/test/java/com/kylinolap/cube/DictionaryManagerTest.java
----------------------------------------------------------------------
diff --git a/cube/src/test/java/com/kylinolap/cube/DictionaryManagerTest.java b/cube/src/test/java/com/kylinolap/cube/DictionaryManagerTest.java
index 6595597..558ff71 100644
--- a/cube/src/test/java/com/kylinolap/cube/DictionaryManagerTest.java
+++ b/cube/src/test/java/com/kylinolap/cube/DictionaryManagerTest.java
@@ -39,7 +39,7 @@ public class DictionaryManagerTest extends LocalFileMetadataTestCase {
     @Before
     public void setup() throws Exception {
         createTestMetadata();
-        dictMgr = DictionaryManager.getInstance(this.getTestConfig());
+        dictMgr = DictionaryManager.getInstance(getTestConfig());
     }
 
     @After
@@ -50,7 +50,7 @@ public class DictionaryManagerTest extends LocalFileMetadataTestCase {
     @Test
     @Ignore("hive not ready")
     public void basic() throws Exception {
-        CubeDesc cubeDesc = CubeDescManager.getInstance(this.getTestConfig()).getCubeDesc("test_kylin_cube_without_slr_desc");
+        CubeDesc cubeDesc = CubeDescManager.getInstance(getTestConfig()).getCubeDesc("test_kylin_cube_without_slr_desc");
         TblColRef col = cubeDesc.findColumnRef("DEFAULT.TEST_CATEGORY_GROUPINGS", "META_CATEG_NAME");
 
         DictionaryInfo info1 = dictMgr.buildDictionary(cubeDesc.getModel(), cubeDesc.getRowkey().getDictionary(col), col, null);

http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/409a2b7d/cube/src/test/java/com/kylinolap/cube/common/RowKeySplitterTest.java
----------------------------------------------------------------------
diff --git a/cube/src/test/java/com/kylinolap/cube/common/RowKeySplitterTest.java b/cube/src/test/java/com/kylinolap/cube/common/RowKeySplitterTest.java
index 5d5d377..8da685d 100644
--- a/cube/src/test/java/com/kylinolap/cube/common/RowKeySplitterTest.java
+++ b/cube/src/test/java/com/kylinolap/cube/common/RowKeySplitterTest.java
@@ -35,7 +35,7 @@ public class RowKeySplitterTest extends LocalFileMetadataTestCase {
     @Before
     public void setUp() throws Exception {
         this.createTestMetadata();
-        MetadataManager.removeInstance(this.getTestConfig());
+        MetadataManager.removeInstance(getTestConfig());
     }
 
     @After
@@ -45,7 +45,7 @@ public class RowKeySplitterTest extends LocalFileMetadataTestCase {
 
     @Test
     public void testWithSlr() throws Exception {
-        CubeInstance cube = CubeManager.getInstance(this.getTestConfig()).getCube("TEST_KYLIN_CUBE_WITH_SLR_READY");
+        CubeInstance cube = CubeManager.getInstance(getTestConfig()).getCube("TEST_KYLIN_CUBE_WITH_SLR_READY");
 
         RowKeySplitter rowKeySplitter = new RowKeySplitter(cube.getFirstSegment(), 10, 20);
         // base cuboid rowkey
@@ -57,7 +57,7 @@ public class RowKeySplitterTest extends LocalFileMetadataTestCase {
 
     @Test
     public void testWithoutSlr() throws Exception {
-        CubeInstance cube = CubeManager.getInstance(this.getTestConfig()).getCube("TEST_KYLIN_CUBE_WITHOUT_SLR_READY");
+        CubeInstance cube = CubeManager.getInstance(getTestConfig()).getCube("TEST_KYLIN_CUBE_WITHOUT_SLR_READY");
 
         RowKeySplitter rowKeySplitter = new RowKeySplitter(cube.getFirstSegment(), 10, 20);
         // base cuboid rowkey

http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/409a2b7d/cube/src/test/java/com/kylinolap/cube/cuboid/CuboidSchedulerTest.java
----------------------------------------------------------------------
diff --git a/cube/src/test/java/com/kylinolap/cube/cuboid/CuboidSchedulerTest.java b/cube/src/test/java/com/kylinolap/cube/cuboid/CuboidSchedulerTest.java
index 640f0c1..7ab8df8 100644
--- a/cube/src/test/java/com/kylinolap/cube/cuboid/CuboidSchedulerTest.java
+++ b/cube/src/test/java/com/kylinolap/cube/cuboid/CuboidSchedulerTest.java
@@ -39,7 +39,7 @@ public class CuboidSchedulerTest extends LocalFileMetadataTestCase {
     @Before
     public void setUp() throws Exception {
         this.createTestMetadata();
-        MetadataManager.removeInstance(this.getTestConfig());
+        MetadataManager.removeInstance(getTestConfig());
     }
 
     @After

http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/409a2b7d/cube/src/test/java/com/kylinolap/cube/kv/RowKeyDecoderTest.java
----------------------------------------------------------------------
diff --git a/cube/src/test/java/com/kylinolap/cube/kv/RowKeyDecoderTest.java b/cube/src/test/java/com/kylinolap/cube/kv/RowKeyDecoderTest.java
index 52dfa9e..2117e38 100644
--- a/cube/src/test/java/com/kylinolap/cube/kv/RowKeyDecoderTest.java
+++ b/cube/src/test/java/com/kylinolap/cube/kv/RowKeyDecoderTest.java
@@ -41,7 +41,7 @@ public class RowKeyDecoderTest extends LocalFileMetadataTestCase {
     @Before
     public void setUp() throws Exception {
         this.createTestMetadata();
-        MetadataManager.removeInstance(this.getTestConfig());
+        MetadataManager.removeInstance(getTestConfig());
     }
 
     @After
@@ -51,7 +51,7 @@ public class RowKeyDecoderTest extends LocalFileMetadataTestCase {
 
     @Test
     public void testDecodeWithoutSlr() throws Exception {
-        CubeInstance cube = CubeManager.getInstance(this.getTestConfig()).getCube("TEST_KYLIN_CUBE_WITHOUT_SLR_READY");
+        CubeInstance cube = CubeManager.getInstance(getTestConfig()).getCube("TEST_KYLIN_CUBE_WITHOUT_SLR_READY");
 
         RowKeyDecoder rowKeyDecoder = new RowKeyDecoder(cube.getFirstSegment());
 
@@ -68,7 +68,7 @@ public class RowKeyDecoderTest extends LocalFileMetadataTestCase {
 
     @Test
     public void testDecodeWithSlr() throws Exception {
-        CubeInstance cube = CubeManager.getInstance(this.getTestConfig()).getCube("TEST_KYLIN_CUBE_WITH_SLR_READY");
+        CubeInstance cube = CubeManager.getInstance(getTestConfig()).getCube("TEST_KYLIN_CUBE_WITH_SLR_READY");
 
         RowKeyDecoder rowKeyDecoder = new RowKeyDecoder(cube.getFirstSegment());
 
@@ -85,7 +85,7 @@ public class RowKeyDecoderTest extends LocalFileMetadataTestCase {
 
     @Test
     public void testEncodeAndDecodeWithUtf8() throws IOException {
-        CubeInstance cube = CubeManager.getInstance(this.getTestConfig()).getCube("TEST_KYLIN_CUBE_WITHOUT_SLR_READY");
+        CubeInstance cube = CubeManager.getInstance(getTestConfig()).getCube("TEST_KYLIN_CUBE_WITHOUT_SLR_READY");
         CubeDesc cubeDesc = cube.getDescriptor();
 
         byte[][] data = new byte[8][];

http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/409a2b7d/cube/src/test/java/com/kylinolap/cube/kv/RowKeyEncoderTest.java
----------------------------------------------------------------------
diff --git a/cube/src/test/java/com/kylinolap/cube/kv/RowKeyEncoderTest.java b/cube/src/test/java/com/kylinolap/cube/kv/RowKeyEncoderTest.java
index ac13383..4939492 100644
--- a/cube/src/test/java/com/kylinolap/cube/kv/RowKeyEncoderTest.java
+++ b/cube/src/test/java/com/kylinolap/cube/kv/RowKeyEncoderTest.java
@@ -40,7 +40,7 @@ public class RowKeyEncoderTest extends LocalFileMetadataTestCase {
     @Before
     public void setUp() throws Exception {
         this.createTestMetadata();
-        MetadataManager.removeInstance(this.getTestConfig());
+        MetadataManager.removeInstance(getTestConfig());
     }
 
     @After
@@ -50,7 +50,7 @@ public class RowKeyEncoderTest extends LocalFileMetadataTestCase {
 
     @Test
     public void testEncodeWithoutSlr() throws Exception {
-        CubeInstance cube = CubeManager.getInstance(this.getTestConfig()).getCube("TEST_KYLIN_CUBE_WITHOUT_SLR_READY");
+        CubeInstance cube = CubeManager.getInstance(getTestConfig()).getCube("TEST_KYLIN_CUBE_WITHOUT_SLR_READY");
         // CubeSegment seg = cube.getTheOnlySegment();
         CubeDesc cubeDesc = cube.getDescriptor();
         // String data =
@@ -79,7 +79,7 @@ public class RowKeyEncoderTest extends LocalFileMetadataTestCase {
 
     @Test
     public void testEncodeWithSlr() throws Exception {
-        CubeInstance cube = CubeManager.getInstance(this.getTestConfig()).getCube("TEST_KYLIN_CUBE_WITH_SLR_READY");
+        CubeInstance cube = CubeManager.getInstance(getTestConfig()).getCube("TEST_KYLIN_CUBE_WITH_SLR_READY");
         // CubeSegment seg = cube.getTheOnlySegment();
         CubeDesc cubeDesc = cube.getDescriptor();
         // String data =
@@ -111,7 +111,7 @@ public class RowKeyEncoderTest extends LocalFileMetadataTestCase {
 
     @Test
     public void testEncodeWithSlr2() throws Exception {
-        CubeInstance cube = CubeManager.getInstance(this.getTestConfig()).getCube("TEST_KYLIN_CUBE_WITH_SLR_READY");
+        CubeInstance cube = CubeManager.getInstance(getTestConfig()).getCube("TEST_KYLIN_CUBE_WITH_SLR_READY");
         // CubeSegment seg = cube.getTheOnlySegment();
         CubeDesc cubeDesc = cube.getDescriptor();
         // String data =

http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/409a2b7d/cube/src/test/java/com/kylinolap/cube/kv/RowValueDecoderTest.java
----------------------------------------------------------------------
diff --git a/cube/src/test/java/com/kylinolap/cube/kv/RowValueDecoderTest.java b/cube/src/test/java/com/kylinolap/cube/kv/RowValueDecoderTest.java
index 0438099..8d54749 100644
--- a/cube/src/test/java/com/kylinolap/cube/kv/RowValueDecoderTest.java
+++ b/cube/src/test/java/com/kylinolap/cube/kv/RowValueDecoderTest.java
@@ -45,7 +45,7 @@ public class RowValueDecoderTest extends LocalFileMetadataTestCase {
     @Before
     public void setUp() throws Exception {
         this.createTestMetadata();
-        MetadataManager.removeInstance(this.getTestConfig());
+        MetadataManager.removeInstance(getTestConfig());
     }
 
     @After
@@ -55,7 +55,7 @@ public class RowValueDecoderTest extends LocalFileMetadataTestCase {
 
     @Test
     public void testDecode() throws Exception {
-        CubeDesc cubeDesc = CubeManager.getInstance(this.getTestConfig()).getCube("test_kylin_cube_with_slr_ready").getDescriptor();
+        CubeDesc cubeDesc = CubeManager.getInstance(getTestConfig()).getCube("test_kylin_cube_with_slr_ready").getDescriptor();
         HBaseColumnDesc hbaseCol = cubeDesc.getHBaseMapping().getColumnFamily()[0].getColumns()[0];
 
         MeasureCodec codec = new MeasureCodec(hbaseCol.getMeasures());

http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/409a2b7d/cube/src/test/java/com/kylinolap/cube/project/ProjectManagerTest.java
----------------------------------------------------------------------
diff --git a/cube/src/test/java/com/kylinolap/cube/project/ProjectManagerTest.java b/cube/src/test/java/com/kylinolap/cube/project/ProjectManagerTest.java
index 40d1287..1026a3e 100644
--- a/cube/src/test/java/com/kylinolap/cube/project/ProjectManagerTest.java
+++ b/cube/src/test/java/com/kylinolap/cube/project/ProjectManagerTest.java
@@ -54,12 +54,12 @@ public class ProjectManagerTest extends LocalFileMetadataTestCase {
 
     @Test(expected = IllegalStateException.class)
     public void testDropNonemptyProject() throws IOException {
-        ProjectManager.getInstance(this.getTestConfig()).dropProject("DEFAULT");
+        ProjectManager.getInstance(getTestConfig()).dropProject("DEFAULT");
     }
 
     @Test(expected = IllegalStateException.class)
     public void testDropNonexistProject() throws IOException {
-        ProjectManager.getInstance(this.getTestConfig()).dropProject("DEFAULT???");
+        ProjectManager.getInstance(getTestConfig()).dropProject("DEFAULT???");
     }
 
     @Test