You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/11/25 03:24:21 UTC

[GitHub] [dolphinscheduler] JinyLeeChina commented on a change in pull request #6981: [Improvement-6866][Api] Add transaction for service

JinyLeeChina commented on a change in pull request #6981:
URL: https://github.com/apache/dolphinscheduler/pull/6981#discussion_r756544631



##########
File path: dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -2194,6 +2204,7 @@ public int switchVersion(ProcessDefinition processDefinition, ProcessDefinitionL
         return result;
     }
 
+    @Transactional(rollbackFor = RuntimeException.class)

Review comment:
       There is no exception thrown in the code. I think adding this here will not work.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org