You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/04/02 18:11:54 UTC
[GitHub] [geode] jdeppe-pivotal opened a new pull request #7548: GEODE-10214: Improve speed of JvmSizeUtils.roundUpSize
jdeppe-pivotal opened a new pull request #7548:
URL: https://github.com/apache/geode/pull/7548
This small change improves the speed of this method by about 30% (as per
basic JMH benchmarking). benchamrk1 is the original and benchmark2 the
change.
```
Benchmark Mode Cnt Score Error Units
PerformanceSample.benchmark1 avgt 5 3480.815 ± 387.131 us/op
PerformanceSample.benchmark2 avgt 5 2418.937 ± 586.209 us/op
```
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #7548: GEODE-10214: Improve speed of JvmSizeUtils.roundUpSize
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on a change in pull request #7548:
URL: https://github.com/apache/geode/pull/7548#discussion_r841118765
##########
File path: geode-core/src/main/java/org/apache/geode/internal/JvmSizeUtils.java
##########
@@ -139,11 +139,7 @@ public static long roundUpSize(long size) {
// Round up to the nearest 8 bytes. Experimentally, this
// is what we've seen the sun 32 bit VM do with object size.
// See https://wiki.gemstone.com/display/rusage/Per+Entry+Overhead
Review comment:
Can you make these comments javadocs and since this wiki is defunct can you remove the link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] pivotal-jbarrett commented on pull request #7548: GEODE-10214: Improve speed of JvmSizeUtils.roundUpSize
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on pull request #7548:
URL: https://github.com/apache/geode/pull/7548#issuecomment-1086721823
Can you include the JMH spice too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org