You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/02/11 13:38:33 UTC
[GitHub] [zeppelin] omrisk opened a new pull request #4054: Add local docker-compose support and updated readme instructions
omrisk opened a new pull request #4054:
URL: https://github.com/apache/zeppelin/pull/4054
### What is this PR for?
To make it easier for new contributors to build and test documentation changes, will add support to build and serve locally using docker.
### What type of PR is it?
Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-5248
### How should this be tested?
* Automated CI
* Can be tested by following updated README instructions to run `docker-compose up` locally
*
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #4054: [ZEPPELIN-5248] - Add local docker-compose support and updated readme instructions
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4054:
URL: https://github.com/apache/zeppelin/pull/4054
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] omrisk commented on pull request #4054: [ZEPPELIN-5248] - Add local docker-compose support and updated readme instructions
Posted by GitBox <gi...@apache.org>.
omrisk commented on pull request #4054:
URL: https://github.com/apache/zeppelin/pull/4054#issuecomment-778056237
@Reamer , ok. The command I added mounts the `doc` directory to the container so it watches the files for changes (same as if you launch it using the current jekyll implementation)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4054: [ZEPPELIN-5248] - Add local docker-compose support and updated readme instructions
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4054:
URL: https://github.com/apache/zeppelin/pull/4054#issuecomment-782589829
LGTM, I tested it and it works very well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4054: [ZEPPELIN-5248] - Add local docker-compose support and updated readme instructions
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4054:
URL: https://github.com/apache/zeppelin/pull/4054#issuecomment-778072059
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] omrisk commented on pull request #4054: [ZEPPELIN-5248] - Add local docker-compose support and updated readme instructions
Posted by GitBox <gi...@apache.org>.
omrisk commented on pull request #4054:
URL: https://github.com/apache/zeppelin/pull/4054#issuecomment-778021544
@Reamer , I though the `docker-compose` may be simpler :)
I'll convert to a docker command (also one less file to maintain).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] omrisk edited a comment on pull request #4054: [ZEPPELIN-5248] - Add local docker-compose support and updated readme instructions
Posted by GitBox <gi...@apache.org>.
omrisk edited a comment on pull request #4054:
URL: https://github.com/apache/zeppelin/pull/4054#issuecomment-778021544
@Reamer , I though the `docker-compose` may be simpler :)
I'll convert to a docker command (also one less file to maintain).
Just consider that will mean that each launch of this will re-build the docker container (about a minute to start).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4054: [ZEPPELIN-5248] - Add local docker-compose support and updated readme instructions
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4054:
URL: https://github.com/apache/zeppelin/pull/4054#issuecomment-778026023
> Just consider that will mean that each launch of this will re-build the docker container (about a minute to start).
I think this is bearable as long as you don't have to restart the container for every change in the docs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4054: [ZEPPELIN-5248] - Add local docker-compose support and updated readme instructions
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4054:
URL: https://github.com/apache/zeppelin/pull/4054#issuecomment-778014154
I think docker-compose is unnecessary as we only have one container.
A simple docker command should be enough, no need for docker-compose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Leemoonsoo commented on pull request #4054: [ZEPPELIN-5248] - Add local docker-compose support and updated readme instructions
Posted by GitBox <gi...@apache.org>.
Leemoonsoo commented on pull request #4054:
URL: https://github.com/apache/zeppelin/pull/4054#issuecomment-777872855
Thank @omrisk for the contribution!
I tested this on
(I had to change the 'version' field of 'docker-compose.yml' from '3.8' to '3.3' in this docker version. After the change, worked well without problem)
as well as with the latest Docker engine
@omrisk Looks like [rat plugin fails](https://github.com/apache/zeppelin/pull/4054/checks?check_run_id=1879669313) due to missing license header on docker-compose.yml file. Could you try to add a license header? (e.g. https://github.com/apache/zeppelin/blob/master/k8s/zeppelin-server.yaml#L1-L16)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org