You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/12/23 21:19:05 UTC

[GitHub] [druid] clintropolis commented on issue #6974: sql support for dynamic parameters

clintropolis commented on issue #6974: sql support for dynamic parameters
URL: https://github.com/apache/druid/pull/6974#issuecomment-568583960
 
 
   >Is this still being tracked?
   
   >I'm under the impression that folks are encouraged to use SQL as the "default" way of querying Druid these days, with native queries only as an advanced use case, and I'd like to start switching our automated usage over to SQL too when feasible. But without this support (or a reliable way to escape strings from at least Java code), I'm not comfortable doing so for anything that needs user-controlled substitution...
   
   Apologies for the delays getting this finished, I do still plan on completing this, because I agree that it is really important. I was holding off on updating this branch until #8566 went in to avoid any conflicts between upgrading the calcite version and anything going on in this PR, but haven't had a chance to get back to it since then. I hopefully should have some time soon, maybe we can get this merged before it's birthday 🍰 
   
   >One note: given that parameters are specified in a list, could it be legal to leave out all ordinals and have them default to their 1-based list index if they are all missing?
   
   I'll see what I can do when I update the PR to fix conflicts.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org