You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/10/07 05:15:50 UTC
[GitHub] [iotdb] qiaojialin commented on a change in pull request #1785: [IOTDB-928] Make ENCODING optional in create time series sentence
qiaojialin commented on a change in pull request #1785:
URL: https://github.com/apache/iotdb/pull/1785#discussion_r500742212
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/strategy/LogicalGenerator.java
##########
@@ -1169,9 +1170,15 @@ private PartialPath parseFullPath(FullPathContext ctx) {
public void enterAttributeClauses(AttributeClausesContext ctx) {
super.enterAttributeClauses(ctx);
String dataType = ctx.dataType().getChild(0).getText().toUpperCase();
- String encoding = ctx.encoding().getChild(0).getText().toUpperCase();
createTimeSeriesOperator.setDataType(TSDataType.valueOf(dataType));
- createTimeSeriesOperator.setEncoding(TSEncoding.valueOf(encoding));
+
+ TSEncoding encoding = TSEncoding.PLAIN;
Review comment:
We could use the default Encoding method for each data type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org