[jira] [Commented] (YARN-3682) Decouple PID-file management from ContainerExecutor

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612965#comment-15612965 ] 

Hadoop QA commented on YARN-3682:
---------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue}  0m  2s{color} | {color:blue} The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  6s{color} | {color:red} YARN-3682 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | YARN-3682 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12736304/YARN-3682-20150529.1.txt |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/13563/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Decouple PID-file management from ContainerExecutor
> ---------------------------------------------------
>
>                 Key: YARN-3682
>                 URL: https://issues.apache.org/jira/browse/YARN-3682
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Vinod Kumar Vavilapalli
>              Labels: oct16-hard
>         Attachments: YARN-3682-20150526.1.txt, YARN-3682-20150526.txt, YARN-3682-20150529.1.txt
>
>
> The PID-files management currently present in ContainerExecutor really doesn't belong there. I know the original history of why we added it, that was about the only right place to put it in at that point of time.
> Given the evolution of executors for Windows etc, the ContainerExecutor is getting more complicated than is necessary.
> We should pull the PID-file management into its own entity.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org