You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/03/22 04:16:26 UTC
[GitHub] [pulsar] jerrypeng commented on a change in pull request #9987: #9986 [functions] - Allow Disabling of Function Batching
jerrypeng commented on a change in pull request #9987:
URL: https://github.com/apache/pulsar/pull/9987#discussion_r598414790
##########
File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java
##########
@@ -538,6 +538,12 @@ public String getFunctionAssignmentTopic() {
)
private boolean exposeAdminClientEnabled = false;
+ @FieldContext(
+ category = CATEGORY_FUNCTIONS,
+ doc = "Enables message batching between functions"
+ )
+ private boolean isFunctionBatchingEnabledDefault = true;
Review comment:
This seems like a one-off config as in the there are no other configs in worker configs that define defaults for certain function configs. If we are going to let cluster admin set defaults for function configs at a cluster level, we should do it in a more comprehensive manner and not just have one-off configs like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org