[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #5735: GEODE-8685: change export to not deserialize region values

[GitBox <gi...@apache.org>]

kohlmu-pivotal commented on a change in pull request #5735:
URL: https://github.com/apache/geode/pull/5735#discussion_r523301719



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/EntrySnapshot.java
##########
@@ -123,6 +123,20 @@ public Object getRawValue(boolean forceCopy) {
     return v;
   }
 
+  /**
+   * If the value is available as a CachedDeserializable instance then return it.
+   * Otherwise behave as if getValue() was called.
+   */
+  public Object getValuePreferringCachedDeserializable() {
+    checkEntryDestroyed();
+    Object v = this.regionEntry.getValue(null);

Review comment:
       Please rename variable to something more meaningful other than the character `v`

##########
File path: geode-gfsh/src/integrationTest/java/org/apache/geode/management/internal/cli/commands/ExportDataIntegrationTest.java
##########
@@ -53,10 +58,29 @@
   @Rule
   public TemporaryFolder tempDir = new TemporaryFolder();
 
-  private Region<String, String> region;
+  private Region<String, Object> region;
   private Path snapshotFile;
   private Path snapshotDir;
 
+  public static class StringWrapper implements DataSerializable {
+
+    private String value;
+
+    public StringWrapper(String v) {
+      value = v;

Review comment:
       Please refrain from using single character names




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org