[GitHub] [spark] zsxwing commented on issue #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer

[GitBox <gi...@apache.org>]

zsxwing commented on issue #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer
URL: https://github.com/apache/spark/pull/25853#issuecomment-562695007
 
 
   Sorry for the late reply. That's a really good point about the batch case. However, I'm not convinced that we should go to the path that has potential stability issues.
   
   How about we revert this and try to fix the issue by adding reference count to each producer? I agree that it could be error prone, but errors can be avoided by adding more tests. In addition, if we keep this patch in master and we want to fix the potential stability issues in future, adding reference count to each producer sounds inevitable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org