You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Venki Korukanti <ve...@gmail.com> on 2015/05/05 09:17:35 UTC
Review Request 33839: DRILL-2598: Throw validation error if CREATE
VIEW/CTAS contains duplicate columns in definition
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33839/
-----------------------------------------------------------
Review request for drill and Jinfeng Ni.
Repository: drill-git
Description
-------
Please see https://issues.apache.org/jira/browse/DRILL-2598 for details.
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerUtil.java 50af972
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestCTAS.java PRE-CREATION
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java 2ae6991
Diff: https://reviews.apache.org/r/33839/diff/
Testing
-------
Added several unittests to cover various scenarios in both CREATE VIEW and CTAS.
Thanks,
Venki Korukanti
Re: Review Request 33839: DRILL-2598: Throw validation error if CREATE
VIEW/CTAS contains duplicate columns in definition
Posted by Jinfeng Ni <jn...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33839/#review82584
-----------------------------------------------------------
Ship it!
Ship It!
- Jinfeng Ni
On May 5, 2015, 9:19 a.m., Venki Korukanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33839/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 9:19 a.m.)
>
>
> Review request for drill and Jinfeng Ni.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Please see https://issues.apache.org/jira/browse/DRILL-2598 for details.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerUtil.java 50af972
> exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestCTAS.java PRE-CREATION
> exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java 2ae6991
>
> Diff: https://reviews.apache.org/r/33839/diff/
>
>
> Testing
> -------
>
> Added several unittests to cover various scenarios in both CREATE VIEW and CTAS.
>
>
> Thanks,
>
> Venki Korukanti
>
>
Re: Review Request 33839: DRILL-2598: Throw validation error if CREATE
VIEW/CTAS contains duplicate columns in definition
Posted by Venki Korukanti <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33839/
-----------------------------------------------------------
(Updated May 5, 2015, 4:19 p.m.)
Review request for drill and Jinfeng Ni.
Repository: drill-git
Description
-------
Please see https://issues.apache.org/jira/browse/DRILL-2598 for details.
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerUtil.java 50af972
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestCTAS.java PRE-CREATION
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java 2ae6991
Diff: https://reviews.apache.org/r/33839/diff/
Testing
-------
Added several unittests to cover various scenarios in both CREATE VIEW and CTAS.
Thanks,
Venki Korukanti