[GitHub] [iceberg] rdblue commented on a change in pull request #1612: Hive: Using Hive schema to create tables and partition specification

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1612:
URL: https://github.com/apache/iceberg/pull/1612#discussion_r511126893



##########
File path: mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -79,6 +83,7 @@ public void preCreateTable(org.apache.hadoop.hive.metastore.api.Table hmsTable)
             "Iceberg table already created - can not use provided schema");
         Preconditions.checkArgument(catalogProperties.getProperty(InputFormatConfig.PARTITION_SPEC) == null,
             "Iceberg table already created - can not use provided partition specification");
+        // TODO: Check type compatibility between this.icebergTable and hmsTable.getSd().getCols()

Review comment:
       What about disallowing a schema in Hive DDL when the table already exists? Then we could always fill in the schema from the Iceberg table.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org