[GitHub] [apisix-helm-chart] incubator4 opened a new pull request, #399: fix(apisix-ingress-controller): get apisix-admin service namespace error

[GitBox <gi...@apache.org>]

incubator4 opened a new pull request, #399:
URL: https://github.com/apache/apisix-helm-chart/pull/399

   ## What does this pr do ?
   Fix namespace error which had been mentioned in Issue #263 
   
   ## How do I fix it ?
   I noticed that Service `apisix-admin` always use `.Value.config.apisix.serviceNamespace` as target url namespace.
   Well, it might not cause problem by deploy helm chart to namespace ingress-apisix as same as docs do.
   Therefore, when I deploy to another namespace, it failed.
   
   As usuall, all apisix resource should be deployed into same namespace. SO I use `.Release.Namespace` by default instead  of `ingress-apisix`. And it could also change namespace by set `.Value.config.apisix.serviceNamespace` to the real apisix service namespace.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(apisix-ingress-controller): get apisix-admin service namespace error [apisix-helm-chart]

["juzhiyuan (via GitHub)" <gi...@apache.org>]

juzhiyuan closed pull request #399: fix(apisix-ingress-controller): get apisix-admin service namespace error
URL: https://github.com/apache/apisix-helm-chart/pull/399


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org