You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/03 00:34:36 UTC
[GitHub] [airflow] tooptoop4 opened a new pull request #7012: [AIRFLOW-6433]
reduce conf.get lookups in scheduler_job.py loops
tooptoop4 opened a new pull request #7012: [AIRFLOW-6433] reduce conf.get lookups in scheduler_job.py loops
URL: https://github.com/apache/airflow/pull/7012
---
Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-6433
- [ X] Description above provides context of the change
- [X ] Commit message starts with `[AIRFLOW-6433]`, where AIRFLOW-NNNN = JIRA ID*
- [X ] Unit tests coverage for changes (not needed for documentation changes)
- [X ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X ] Relevant documentation is updated including usage instructions.
- [X ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
(*) For document-only changes, no JIRA issue is needed. Commit message starts `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7012:
[AIRFLOW-6433] reduce conf.get lookups in scheduler_job.py loops
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7012: [AIRFLOW-6433] reduce conf.get lookups in scheduler_job.py loops
URL: https://github.com/apache/airflow/pull/7012#issuecomment-570646314
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=h1) Report
> Merging [#7012](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f391039be9cb5a767f4c66771ba70031210d3e76?src=pr&el=desc) will **decrease** coverage by `0.35%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7012 +/- ##
==========================================
- Coverage 85.03% 84.67% -0.36%
==========================================
Files 679 679
Lines 38545 38603 +58
==========================================
- Hits 32775 32688 -87
- Misses 5770 5915 +145
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.29% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/gcp/example\_dags/example\_dlp\_operator.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGxwX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [...low/gcp/example\_dags/example\_automl\_translation.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYXV0b21sX3RyYW5zbGF0aW9uLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [...viders/google/cloud/example\_dags/example\_vision.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX3Zpc2lvbi5weQ==) | `0% <0%> (ø)` | :arrow_up: |
| ... and [30 more](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=footer). Last update [f391039...e8cf09c](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7012:
[AIRFLOW-6433] reduce conf.get lookups in scheduler_job.py loops
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7012: [AIRFLOW-6433] reduce conf.get lookups in scheduler_job.py loops
URL: https://github.com/apache/airflow/pull/7012#issuecomment-570646314
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=h1) Report
> Merging [#7012](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f391039be9cb5a767f4c66771ba70031210d3e76?src=pr&el=desc) will **decrease** coverage by `0.35%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7012 +/- ##
==========================================
- Coverage 85.03% 84.67% -0.36%
==========================================
Files 679 679
Lines 38545 38603 +58
==========================================
- Hits 32775 32688 -87
- Misses 5770 5915 +145
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.29% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/gcp/example\_dags/example\_dlp\_operator.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGxwX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [...low/gcp/example\_dags/example\_automl\_translation.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYXV0b21sX3RyYW5zbGF0aW9uLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [...viders/google/cloud/example\_dags/example\_vision.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX3Zpc2lvbi5weQ==) | `0% <0%> (ø)` | :arrow_up: |
| ... and [30 more](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=footer). Last update [f391039...e8cf09c](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7012:
[AIRFLOW-6433] reduce conf.get lookups in scheduler_job.py loops
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7012: [AIRFLOW-6433] reduce conf.get lookups in scheduler_job.py loops
URL: https://github.com/apache/airflow/pull/7012#issuecomment-570646314
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=h1) Report
> Merging [#7012](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `87.2%`.
[](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7012 +/- ##
==========================================
- Coverage 84.7% 84.67% -0.03%
==========================================
Files 680 679 -1
Lines 38556 38603 +47
==========================================
+ Hits 32659 32688 +29
- Misses 5897 5915 +18
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5) | `99.07% <ø> (ø)` | :arrow_up: |
| [airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=) | `89.28% <ø> (ø)` | :arrow_up: |
| [airflow/gcp/utils/mlengine\_operator\_utils.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvdXRpbHMvbWxlbmdpbmVfb3BlcmF0b3JfdXRpbHMucHk=) | `95.34% <ø> (ø)` | :arrow_up: |
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.92% <ø> (+0.35%)` | :arrow_up: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `92.65% <ø> (ø)` | :arrow_up: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <ø> (-1.06%)` | :arrow_down: |
| [airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==) | `97.43% <ø> (ø)` | :arrow_up: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [...gle/cloud/example\_dags/example\_natural\_language.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX25hdHVyYWxfbGFuZ3VhZ2UucHk=) | `0% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/sensors/python\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvcHl0aG9uX3NlbnNvci5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| ... and [94 more](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=footer). Last update [7d97d16...e8cf09c](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7012:
[AIRFLOW-6433] reduce conf.get lookups in scheduler_job.py loops
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7012: [AIRFLOW-6433] reduce conf.get lookups in scheduler_job.py loops
URL: https://github.com/apache/airflow/pull/7012#issuecomment-570646314
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=h1) Report
> Merging [#7012](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `87.2%`.
[](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7012 +/- ##
==========================================
- Coverage 84.7% 84.67% -0.03%
==========================================
Files 680 679 -1
Lines 38556 38603 +47
==========================================
+ Hits 32659 32688 +29
- Misses 5897 5915 +18
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5) | `99.07% <ø> (ø)` | :arrow_up: |
| [airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=) | `89.28% <ø> (ø)` | :arrow_up: |
| [airflow/gcp/utils/mlengine\_operator\_utils.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvdXRpbHMvbWxlbmdpbmVfb3BlcmF0b3JfdXRpbHMucHk=) | `95.34% <ø> (ø)` | :arrow_up: |
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.92% <ø> (+0.35%)` | :arrow_up: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `92.65% <ø> (ø)` | :arrow_up: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <ø> (-1.06%)` | :arrow_down: |
| [airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==) | `97.43% <ø> (ø)` | :arrow_up: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [...gle/cloud/example\_dags/example\_natural\_language.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX25hdHVyYWxfbGFuZ3VhZ2UucHk=) | `0% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/sensors/python\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvcHl0aG9uX3NlbnNvci5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| ... and [94 more](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=footer). Last update [7d97d16...e8cf09c](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7012:
[AIRFLOW-6433] reduce conf.get lookups in scheduler_job.py loops
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7012: [AIRFLOW-6433] reduce conf.get lookups in scheduler_job.py loops
URL: https://github.com/apache/airflow/pull/7012#issuecomment-570646314
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=h1) Report
> Merging [#7012](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f391039be9cb5a767f4c66771ba70031210d3e76?src=pr&el=desc) will **decrease** coverage by `0.35%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7012 +/- ##
==========================================
- Coverage 85.03% 84.67% -0.36%
==========================================
Files 679 679
Lines 38545 38603 +58
==========================================
- Hits 32775 32688 -87
- Misses 5770 5915 +145
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.29% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/gcp/example\_dags/example\_dlp\_operator.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGxwX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [...low/gcp/example\_dags/example\_automl\_translation.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYXV0b21sX3RyYW5zbGF0aW9uLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [...viders/google/cloud/example\_dags/example\_vision.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX3Zpc2lvbi5weQ==) | `0% <0%> (ø)` | :arrow_up: |
| ... and [30 more](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=footer). Last update [f391039...e8cf09c](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7012:
[AIRFLOW-6433] reduce conf.get lookups in scheduler_job.py loops
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7012: [AIRFLOW-6433] reduce conf.get lookups in scheduler_job.py loops
URL: https://github.com/apache/airflow/pull/7012#issuecomment-570646314
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=h1) Report
> Merging [#7012](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f391039be9cb5a767f4c66771ba70031210d3e76?src=pr&el=desc) will **decrease** coverage by `0.35%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7012 +/- ##
==========================================
- Coverage 85.03% 84.67% -0.36%
==========================================
Files 679 679
Lines 38545 38603 +58
==========================================
- Hits 32775 32688 -87
- Misses 5770 5915 +145
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.29% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/gcp/example\_dags/example\_dlp\_operator.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGxwX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [...low/gcp/example\_dags/example\_automl\_translation.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYXV0b21sX3RyYW5zbGF0aW9uLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [...viders/google/cloud/example\_dags/example\_vision.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX3Zpc2lvbi5weQ==) | `0% <0%> (ø)` | :arrow_up: |
| ... and [30 more](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=footer). Last update [f391039...e8cf09c](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7012:
[AIRFLOW-6433] reduce conf.get lookups in scheduler_job.py loops
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7012: [AIRFLOW-6433] reduce conf.get lookups in scheduler_job.py loops
URL: https://github.com/apache/airflow/pull/7012#issuecomment-570646314
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=h1) Report
> Merging [#7012](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f391039be9cb5a767f4c66771ba70031210d3e76?src=pr&el=desc) will **decrease** coverage by `0.35%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7012 +/- ##
==========================================
- Coverage 85.03% 84.67% -0.36%
==========================================
Files 679 679
Lines 38545 38603 +58
==========================================
- Hits 32775 32688 -87
- Misses 5770 5915 +145
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.29% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/gcp/example\_dags/example\_dlp\_operator.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGxwX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [...low/gcp/example\_dags/example\_automl\_translation.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYXV0b21sX3RyYW5zbGF0aW9uLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [...viders/google/cloud/example\_dags/example\_vision.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX3Zpc2lvbi5weQ==) | `0% <0%> (ø)` | :arrow_up: |
| ... and [30 more](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=footer). Last update [f391039...e8cf09c](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7012: [AIRFLOW-6433]
reduce conf.get lookups in scheduler_job.py loops
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7012: [AIRFLOW-6433] reduce conf.get lookups in scheduler_job.py loops
URL: https://github.com/apache/airflow/pull/7012#issuecomment-570646314
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=h1) Report
> Merging [#7012](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f391039be9cb5a767f4c66771ba70031210d3e76?src=pr&el=desc) will **decrease** coverage by `0.35%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7012 +/- ##
==========================================
- Coverage 85.03% 84.67% -0.36%
==========================================
Files 679 679
Lines 38545 38603 +58
==========================================
- Hits 32775 32688 -87
- Misses 5770 5915 +145
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.29% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/gcp/example\_dags/example\_dlp\_operator.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGxwX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [...low/gcp/example\_dags/example\_automl\_translation.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYXV0b21sX3RyYW5zbGF0aW9uLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [...viders/google/cloud/example\_dags/example\_vision.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX3Zpc2lvbi5weQ==) | `0% <0%> (ø)` | :arrow_up: |
| ... and [30 more](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=footer). Last update [f391039...e8cf09c](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7012:
[AIRFLOW-6433] reduce conf.get lookups in scheduler_job.py loops
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7012: [AIRFLOW-6433] reduce conf.get lookups in scheduler_job.py loops
URL: https://github.com/apache/airflow/pull/7012#issuecomment-570646314
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=h1) Report
> Merging [#7012](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `87.2%`.
[](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7012 +/- ##
==========================================
- Coverage 84.7% 84.67% -0.03%
==========================================
Files 680 679 -1
Lines 38556 38603 +47
==========================================
+ Hits 32659 32688 +29
- Misses 5897 5915 +18
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5) | `99.07% <ø> (ø)` | :arrow_up: |
| [airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=) | `89.28% <ø> (ø)` | :arrow_up: |
| [airflow/gcp/utils/mlengine\_operator\_utils.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvdXRpbHMvbWxlbmdpbmVfb3BlcmF0b3JfdXRpbHMucHk=) | `95.34% <ø> (ø)` | :arrow_up: |
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.92% <ø> (+0.35%)` | :arrow_up: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `92.65% <ø> (ø)` | :arrow_up: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <ø> (-1.06%)` | :arrow_down: |
| [airflow/cli/commands/db\_command.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGJfY29tbWFuZC5weQ==) | `97.43% <ø> (ø)` | :arrow_up: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [...gle/cloud/example\_dags/example\_natural\_language.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX25hdHVyYWxfbGFuZ3VhZ2UucHk=) | `0% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/sensors/python\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvcHl0aG9uX3NlbnNvci5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| ... and [94 more](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=footer). Last update [7d97d16...e8cf09c](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7012:
[AIRFLOW-6433] reduce conf.get lookups in scheduler_job.py loops
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7012: [AIRFLOW-6433] reduce conf.get lookups in scheduler_job.py loops
URL: https://github.com/apache/airflow/pull/7012#issuecomment-570646314
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=h1) Report
> Merging [#7012](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f391039be9cb5a767f4c66771ba70031210d3e76?src=pr&el=desc) will **decrease** coverage by `0.35%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7012 +/- ##
==========================================
- Coverage 85.03% 84.67% -0.36%
==========================================
Files 679 679
Lines 38545 38603 +58
==========================================
- Hits 32775 32688 -87
- Misses 5770 5915 +145
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.29% <100%> (+0.01%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/gcp/example\_dags/example\_dlp\_operator.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGxwX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [...low/gcp/example\_dags/example\_automl\_translation.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYXV0b21sX3RyYW5zbGF0aW9uLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [...viders/google/cloud/example\_dags/example\_vision.py](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX3Zpc2lvbi5weQ==) | `0% <0%> (ø)` | :arrow_up: |
| ... and [30 more](https://codecov.io/gh/apache/airflow/pull/7012/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=footer). Last update [f391039...e8cf09c](https://codecov.io/gh/apache/airflow/pull/7012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services