[GitHub] [royale-asjs] estanglerbm commented on pull request #960: Fix VerifyError: Error #1053 in Flash Debug Player due to mismatched types

[GitBox <gi...@apache.org>]

estanglerbm commented on pull request #960:
URL: https://github.com/apache/royale-asjs/pull/960#issuecomment-735711686


   Everywhere else that IDataInput / IDataOutput is used, there are conditional imports.  It was just missed in this area, as far as I can tell.  So this isn't something new.
   
   Flex doesn't allow function overloading like you describe;  it throws `Error: Incompatible override.`
   
   That is, it doesn't allow:
   
   ```
   package a
   {
           public class Y {}
           public class X extends Y {}
   
           public class B { public function foo(c:Y):void {} }
           public class A extends B { override public function foo(c:X):void {} }
   }
   ```
   
   The IDataInput / IDataOutput changes are just copying over the conditional imports from other areas.
   
   The DataGroup change is something new.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org