You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/11 04:07:26 UTC
[GitHub] [camel-website] favourori opened a new pull request #189: opening
foreign links in new tab
favourori opened a new pull request #189: opening foreign links in new tab
URL: https://github.com/apache/camel-website/pull/189
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] favourori commented on a change in pull request
#189: opening foreign links in new tab
Posted by GitBox <gi...@apache.org>.
favourori commented on a change in pull request #189: opening foreign links in new tab
URL: https://github.com/apache/camel-website/pull/189#discussion_r390882437
##########
File path: config.toml
##########
@@ -83,7 +83,7 @@ timeout = 300000
parent = "docs"
weight = 4
identifier = "api-documentation"
- url = "https://www.javadoc.io/doc/org.apache.camel/camel-api/latest/index.html"
+ url = "https://www.javadoc.io/doc/org.apache.camel/camel-api/latest"
Review comment:
The way I get to know what an external link - is when it has https, but this url has index.html prefix and was behaving like a local link, so I had to remove the index.html (the link still works though). I can revert if you want me to
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] favourori commented on a change in pull request
#189: opening foreign links in new tab
Posted by GitBox <gi...@apache.org>.
favourori commented on a change in pull request #189: opening foreign links in new tab
URL: https://github.com/apache/camel-website/pull/189#discussion_r390816817
##########
File path: layouts/partials/header.html
##########
@@ -42,12 +42,16 @@
<a class="navbar-link" href="#">{{ .Name }}</a>
<div class="navbar-dropdown">
{{ range .Children }}
+ {{ if strings.HasPrefix .URL "https" }}
+ <a class="navbar-item" href="{{ .URL | relURL }}" target="_blank" rel="noopener">{{ .Name }}</a>
Review comment:
This is false, it adds to all external links in the menu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#189: opening foreign links in new tab
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #189: opening foreign links in new tab
URL: https://github.com/apache/camel-website/pull/189#discussion_r390806343
##########
File path: config.toml
##########
@@ -83,7 +83,7 @@ timeout = 300000
parent = "docs"
weight = 4
identifier = "api-documentation"
- url = "https://www.javadoc.io/doc/org.apache.camel/camel-api/latest/index.html"
+ url = "https://www.javadoc.io/doc/org.apache.camel/camel-api/latest"
Review comment:
Not sure this needs to be changed, can you elaborate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#189: opening foreign links in new tab
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #189: opening foreign links in new tab
URL: https://github.com/apache/camel-website/pull/189#discussion_r392116790
##########
File path: layouts/partials/header.html
##########
@@ -42,12 +42,16 @@
<a class="navbar-link navbar-topics" href="#">{{ .Name }}</a>
<div class="navbar-dropdown">
{{ range .Children }}
+ {{ if strings.HasPrefix .URL "https" }}
Review comment:
Please revert changes to this file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] favourori commented on issue #189: opening foreign
links in new tab
Posted by GitBox <gi...@apache.org>.
favourori commented on issue #189: opening foreign links in new tab
URL: https://github.com/apache/camel-website/pull/189#issuecomment-599223928
Okay. Noted
> On Mar 15, 2020, at 5:10 PM, Zoran Regvart <no...@github.com> wrote:
>
>
> @favourori changes in pull requests need to be relating to a single topic, if your intent is to bundle multiple changes into a single pull request then we can't accept that. You need to work on separate topics in separate pull requests.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] favourori commented on issue #189: opening foreign
links in new tab
Posted by GitBox <gi...@apache.org>.
favourori commented on issue #189: opening foreign links in new tab
URL: https://github.com/apache/camel-website/pull/189#issuecomment-598207820
Hi @zregvart
You can check now. All foreign links open in new tabs now. Nav, footer, site-wide.
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] favourori commented on a change in pull request
#189: opening foreign links in new tab
Posted by GitBox <gi...@apache.org>.
favourori commented on a change in pull request #189: opening foreign links in new tab
URL: https://github.com/apache/camel-website/pull/189#discussion_r390816817
##########
File path: layouts/partials/header.html
##########
@@ -42,12 +42,16 @@
<a class="navbar-link" href="#">{{ .Name }}</a>
<div class="navbar-dropdown">
{{ range .Children }}
+ {{ if strings.HasPrefix .URL "https" }}
+ <a class="navbar-item" href="{{ .URL | relURL }}" target="_blank" rel="noopener">{{ .Name }}</a>
Review comment:
Great. Will fix that. Thanks for the pointers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#189: opening foreign links in new tab
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #189: opening foreign links in new tab
URL: https://github.com/apache/camel-website/pull/189#discussion_r390807595
##########
File path: layouts/partials/header.html
##########
@@ -42,12 +42,16 @@
<a class="navbar-link" href="#">{{ .Name }}</a>
<div class="navbar-dropdown">
{{ range .Children }}
+ {{ if strings.HasPrefix .URL "https" }}
+ <a class="navbar-item" href="{{ .URL | relURL }}" target="_blank" rel="noopener">{{ .Name }}</a>
Review comment:
This adds `target` and `rel` attributes for one link on the menu. What we need is something that will add this for all external links regardless of where they are rendered from.
[The issue](https://issues.apache.org/jira/browse/CAMEL-13888) in question has some pointers on how to accomplish that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] favourori commented on a change in pull request
#189: opening foreign links in new tab
Posted by GitBox <gi...@apache.org>.
favourori commented on a change in pull request #189: opening foreign links in new tab
URL: https://github.com/apache/camel-website/pull/189#discussion_r390816817
##########
File path: layouts/partials/header.html
##########
@@ -42,12 +42,16 @@
<a class="navbar-link" href="#">{{ .Name }}</a>
<div class="navbar-dropdown">
{{ range .Children }}
+ {{ if strings.HasPrefix .URL "https" }}
+ <a class="navbar-item" href="{{ .URL | relURL }}" target="_blank" rel="noopener">{{ .Name }}</a>
Review comment:
Great. Will fix that today. Thanks for the pointers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#189: opening foreign links in new tab
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #189: opening foreign links in new tab
URL: https://github.com/apache/camel-website/pull/189#discussion_r392116665
##########
File path: antora-ui-camel/src/css/header.css
##########
@@ -429,4 +429,4 @@ body {
#social-media {
display: none;
}
-}
Review comment:
Please revert this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] favourori commented on issue #189: opening foreign
links in new tab
Posted by GitBox <gi...@apache.org>.
favourori commented on issue #189: opening foreign links in new tab
URL: https://github.com/apache/camel-website/pull/189#issuecomment-598202663
Hi, check again.
I added blackfriday parser to config at the top markup
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] favourori commented on issue #189: opening foreign
links in new tab
Posted by GitBox <gi...@apache.org>.
favourori commented on issue #189: opening foreign links in new tab
URL: https://github.com/apache/camel-website/pull/189#issuecomment-597510125
No problem.
Let me work on that.
Best,
Favour
> On Mar 11, 2020, at 10:27 AM, Zoran Regvart <no...@github.com> wrote:
>
>
> @zregvart requested changes on this pull request.
>
> I don't think this solves the problem as a whole, we need add the rel attribute for all external links.
>
> In config.toml:
>
> > @@ -83,7 +83,7 @@ timeout = 300000
> parent = "docs"
> weight = 4
> identifier = "api-documentation"
> - url = "https://www.javadoc.io/doc/org.apache.camel/camel-api/latest/index.html"
> + url = "https://www.javadoc.io/doc/org.apache.camel/camel-api/latest"
> Not sure this needs to be changed, can you elaborate?
>
> In layouts/partials/header.html:
>
> > @@ -42,12 +42,16 @@
> <a class="navbar-link" href="#">{{ .Name }}</a>
> <div class="navbar-dropdown">
> {{ range .Children }}
> + {{ if strings.HasPrefix .URL "https" }}
> + <a class="navbar-item" href="{{ .URL | relURL }}" target="_blank" rel="noopener">{{ .Name }}</a>
> This adds target and rel attributes for one link on the menu. What we need is something that will add this for all external links regardless of where they are rendered from.
>
> The issue in question has some pointers on how to accomplish that.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] favourori edited a comment on issue #189: opening
foreign links in new tab
Posted by GitBox <gi...@apache.org>.
favourori edited a comment on issue #189: opening foreign links in new tab
URL: https://github.com/apache/camel-website/pull/189#issuecomment-597510125
No problem.
Let me work on that.
> On Mar 11, 2020, at 10:27 AM, Zoran Regvart <no...@github.com> wrote:
>
>
> @zregvart requested changes on this pull request.
>
> I don't think this solves the problem as a whole, we need add the rel attribute for all external links.
>
> In config.toml:
>
> > @@ -83,7 +83,7 @@ timeout = 300000
> parent = "docs"
> weight = 4
> identifier = "api-documentation"
> - url = "https://www.javadoc.io/doc/org.apache.camel/camel-api/latest/index.html"
> + url = "https://www.javadoc.io/doc/org.apache.camel/camel-api/latest"
> Not sure this needs to be changed, can you elaborate?
>
> In layouts/partials/header.html:
>
> > @@ -42,12 +42,16 @@
> <a class="navbar-link" href="#">{{ .Name }}</a>
> <div class="navbar-dropdown">
> {{ range .Children }}
> + {{ if strings.HasPrefix .URL "https" }}
> + <a class="navbar-item" href="{{ .URL | relURL }}" target="_blank" rel="noopener">{{ .Name }}</a>
> This adds target and rel attributes for one link on the menu. What we need is something that will add this for all external links regardless of where they are rendered from.
>
> The issue in question has some pointers on how to accomplish that.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] favourori removed a comment on issue #189: opening
foreign links in new tab
Posted by GitBox <gi...@apache.org>.
favourori removed a comment on issue #189: opening foreign links in new tab
URL: https://github.com/apache/camel-website/pull/189#issuecomment-597510125
No problem.
Let me work on that.
> On Mar 11, 2020, at 10:27 AM, Zoran Regvart <no...@github.com> wrote:
>
>
> @zregvart requested changes on this pull request.
>
> I don't think this solves the problem as a whole, we need add the rel attribute for all external links.
>
> In config.toml:
>
> > @@ -83,7 +83,7 @@ timeout = 300000
> parent = "docs"
> weight = 4
> identifier = "api-documentation"
> - url = "https://www.javadoc.io/doc/org.apache.camel/camel-api/latest/index.html"
> + url = "https://www.javadoc.io/doc/org.apache.camel/camel-api/latest"
> Not sure this needs to be changed, can you elaborate?
>
> In layouts/partials/header.html:
>
> > @@ -42,12 +42,16 @@
> <a class="navbar-link" href="#">{{ .Name }}</a>
> <div class="navbar-dropdown">
> {{ range .Children }}
> + {{ if strings.HasPrefix .URL "https" }}
> + <a class="navbar-item" href="{{ .URL | relURL }}" target="_blank" rel="noopener">{{ .Name }}</a>
> This adds target and rel attributes for one link on the menu. What we need is something that will add this for all external links regardless of where they are rendered from.
>
> The issue in question has some pointers on how to accomplish that.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] favourori commented on issue #189: opening foreign
links in new tab
Posted by GitBox <gi...@apache.org>.
favourori commented on issue #189: opening foreign links in new tab
URL: https://github.com/apache/camel-website/pull/189#issuecomment-599088977
closing, so I can move on to the next issue. Should you need additional modifications, please let me know
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #189: opening foreign
links in new tab
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #189: opening foreign links in new tab
URL: https://github.com/apache/camel-website/pull/189#issuecomment-599222762
@favourori changes in pull requests need to be relating to a single topic, if your intent is to bundle multiple changes into a single pull request then we can't accept that. You need to work on separate topics in separate pull requests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] favourori closed pull request #189: opening foreign
links in new tab
Posted by GitBox <gi...@apache.org>.
favourori closed pull request #189: opening foreign links in new tab
URL: https://github.com/apache/camel-website/pull/189
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services