You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Bertrand Delacretaz (Created) (JIRA)" <ji...@apache.org> on 2011/11/15 16:28:52 UTC
[jira] [Created] (SLING-2288) Bundle jar is silently ignored by the
installer if MANIFEST.MF is not the first file in the archive
Bundle jar is silently ignored by the installer if MANIFEST.MF is not the first file in the archive
---------------------------------------------------------------------------------------------------
Key: SLING-2288
URL: https://issues.apache.org/jira/browse/SLING-2288
Project: Sling
Issue Type: Bug
Components: Installer
Reporter: Bertrand Delacretaz
Priority: Minor
A jar file where the MANIFEST.MF is not the first file in the jar is silently ignored by the installer.
We should at least output a warning, and maybe try harder to find the manifest, in the Util.getManifest(...) method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2288) Bundle jar is silently ignored by
the installer if MANIFEST.MF is not the first file in the archive
Posted by "Carsten Ziegeler (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler reassigned SLING-2288:
---------------------------------------
Assignee: Carsten Ziegeler
> Bundle jar is silently ignored by the installer if MANIFEST.MF is not the first file in the archive
> ---------------------------------------------------------------------------------------------------
>
> Key: SLING-2288
> URL: https://issues.apache.org/jira/browse/SLING-2288
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Reporter: Bertrand Delacretaz
> Assignee: Carsten Ziegeler
> Priority: Minor
>
> A jar file where the MANIFEST.MF is not the first file in the jar is silently ignored by the installer.
> We should at least output a warning, and maybe try harder to find the manifest, in the Util.getManifest(...) method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SLING-2288) Bundle jar is silently ignored by the
installer if MANIFEST.MF is not the first file in the archive
Posted by "Carsten Ziegeler (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler closed SLING-2288.
-----------------------------------
> Bundle jar is silently ignored by the installer if MANIFEST.MF is not the first file in the archive
> ---------------------------------------------------------------------------------------------------
>
> Key: SLING-2288
> URL: https://issues.apache.org/jira/browse/SLING-2288
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: Installer Core 3.2.2
> Reporter: Bertrand Delacretaz
> Assignee: Carsten Ziegeler
> Priority: Minor
> Fix For: Installer Core 3.3.0
>
>
> A jar file where the MANIFEST.MF is not the first file in the jar is silently ignored by the installer.
> We should at least output a warning, and maybe try harder to find the manifest, in the Util.getManifest(...) method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2288) Bundle jar is silently ignored by
the installer if MANIFEST.MF is not the first file in the archive
Posted by "Felix Meschberger (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150580#comment-13150580 ]
Felix Meschberger commented on SLING-2288:
------------------------------------------
I cannot find it in the JAR spec, but it is an agreed upon fact, that the MANIFEST.MF must be first. But the java.util.JarInputStream class expects this.
So I would suggest we just assume this to be factual and just log.
> Bundle jar is silently ignored by the installer if MANIFEST.MF is not the first file in the archive
> ---------------------------------------------------------------------------------------------------
>
> Key: SLING-2288
> URL: https://issues.apache.org/jira/browse/SLING-2288
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Reporter: Bertrand Delacretaz
> Assignee: Carsten Ziegeler
> Priority: Minor
>
> A jar file where the MANIFEST.MF is not the first file in the jar is silently ignored by the installer.
> We should at least output a warning, and maybe try harder to find the manifest, in the Util.getManifest(...) method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2288) Bundle jar is silently ignored by
the installer if MANIFEST.MF is not the first file in the archive
Posted by "Bertrand Delacretaz (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150562#comment-13150562 ]
Bertrand Delacretaz commented on SLING-2288:
--------------------------------------------
Do you have an URL to that spec?
I see posts from usually knowledgeable people saying that having MANIFEST.MF first in a jar file is not required by the spec, so having that would be good ;-)
> Bundle jar is silently ignored by the installer if MANIFEST.MF is not the first file in the archive
> ---------------------------------------------------------------------------------------------------
>
> Key: SLING-2288
> URL: https://issues.apache.org/jira/browse/SLING-2288
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Reporter: Bertrand Delacretaz
> Assignee: Carsten Ziegeler
> Priority: Minor
>
> A jar file where the MANIFEST.MF is not the first file in the jar is silently ignored by the installer.
> We should at least output a warning, and maybe try harder to find the manifest, in the Util.getManifest(...) method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2288) Bundle jar is silently ignored by
the installer if MANIFEST.MF is not the first file in the archive
Posted by "Carsten Ziegeler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150555#comment-13150555 ]
Carsten Ziegeler commented on SLING-2288:
-----------------------------------------
Logging makes sense, but we should not try harder - the spec requires this and we just rely in the tools provided by the JDK, All other tools using the standard methods will fail with such a jar as well, so there is no point in supporting it :)
> Bundle jar is silently ignored by the installer if MANIFEST.MF is not the first file in the archive
> ---------------------------------------------------------------------------------------------------
>
> Key: SLING-2288
> URL: https://issues.apache.org/jira/browse/SLING-2288
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Reporter: Bertrand Delacretaz
> Assignee: Carsten Ziegeler
> Priority: Minor
>
> A jar file where the MANIFEST.MF is not the first file in the jar is silently ignored by the installer.
> We should at least output a warning, and maybe try harder to find the manifest, in the Util.getManifest(...) method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2288) Bundle jar is silently ignored by the
installer if MANIFEST.MF is not the first file in the archive
Posted by "Carsten Ziegeler (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler updated SLING-2288:
------------------------------------
Affects Version/s: Installer Core 3.2.2
Fix Version/s: Installer Core 3.2.4
> Bundle jar is silently ignored by the installer if MANIFEST.MF is not the first file in the archive
> ---------------------------------------------------------------------------------------------------
>
> Key: SLING-2288
> URL: https://issues.apache.org/jira/browse/SLING-2288
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: Installer Core 3.2.2
> Reporter: Bertrand Delacretaz
> Assignee: Carsten Ziegeler
> Priority: Minor
> Fix For: Installer Core 3.2.4
>
>
> A jar file where the MANIFEST.MF is not the first file in the jar is silently ignored by the installer.
> We should at least output a warning, and maybe try harder to find the manifest, in the Util.getManifest(...) method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2288) Bundle jar is silently ignored by
the installer if MANIFEST.MF is not the first file in the archive
Posted by "Carsten Ziegeler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150579#comment-13150579 ]
Carsten Ziegeler commented on SLING-2288:
-----------------------------------------
The implementation is the spec...
> Bundle jar is silently ignored by the installer if MANIFEST.MF is not the first file in the archive
> ---------------------------------------------------------------------------------------------------
>
> Key: SLING-2288
> URL: https://issues.apache.org/jira/browse/SLING-2288
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Reporter: Bertrand Delacretaz
> Assignee: Carsten Ziegeler
> Priority: Minor
>
> A jar file where the MANIFEST.MF is not the first file in the jar is silently ignored by the installer.
> We should at least output a warning, and maybe try harder to find the manifest, in the Util.getManifest(...) method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2288) Bundle jar is silently ignored by
the installer if MANIFEST.MF is not the first file in the archive
Posted by "Bertrand Delacretaz (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150584#comment-13150584 ]
Bertrand Delacretaz commented on SLING-2288:
--------------------------------------------
I'm absolutely fine with just logging - but if we can find the actual spec that helps explain what happens when people have to cope with broken jars.
> Bundle jar is silently ignored by the installer if MANIFEST.MF is not the first file in the archive
> ---------------------------------------------------------------------------------------------------
>
> Key: SLING-2288
> URL: https://issues.apache.org/jira/browse/SLING-2288
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Reporter: Bertrand Delacretaz
> Assignee: Carsten Ziegeler
> Priority: Minor
>
> A jar file where the MANIFEST.MF is not the first file in the jar is silently ignored by the installer.
> We should at least output a warning, and maybe try harder to find the manifest, in the Util.getManifest(...) method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2288) Bundle jar is silently ignored by
the installer if MANIFEST.MF is not the first file in the archive
Posted by "Bertrand Delacretaz (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150597#comment-13150597 ]
Bertrand Delacretaz commented on SLING-2288:
--------------------------------------------
The jar file spec doesn't seem to mention this, but the jar tool docs [1] indicates that jar always puts the manifest first in the jar.
https://issuetracker.springsource.com/browse/BNDLR-287 mentions that JarInputStream does enforce it while JarFile does not - I haven't checked that myself in the current JDKs.
So it looks like it's really a de facto requirement, and logging a warning is the right thing to do to avoid surprises.
[1] http://download.oracle.com/javase/1.3/docs/tooldocs/solaris/jar.html
> Bundle jar is silently ignored by the installer if MANIFEST.MF is not the first file in the archive
> ---------------------------------------------------------------------------------------------------
>
> Key: SLING-2288
> URL: https://issues.apache.org/jira/browse/SLING-2288
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Reporter: Bertrand Delacretaz
> Assignee: Carsten Ziegeler
> Priority: Minor
>
> A jar file where the MANIFEST.MF is not the first file in the jar is silently ignored by the installer.
> We should at least output a warning, and maybe try harder to find the manifest, in the Util.getManifest(...) method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2288) Bundle jar is silently ignored by
the installer if MANIFEST.MF is not the first file in the archive
Posted by "Carsten Ziegeler (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler resolved SLING-2288.
-------------------------------------
Resolution: Fixed
Added a warn log msg in revision 1202555
> Bundle jar is silently ignored by the installer if MANIFEST.MF is not the first file in the archive
> ---------------------------------------------------------------------------------------------------
>
> Key: SLING-2288
> URL: https://issues.apache.org/jira/browse/SLING-2288
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: Installer Core 3.2.2
> Reporter: Bertrand Delacretaz
> Assignee: Carsten Ziegeler
> Priority: Minor
> Fix For: Installer Core 3.2.4
>
>
> A jar file where the MANIFEST.MF is not the first file in the jar is silently ignored by the installer.
> We should at least output a warning, and maybe try harder to find the manifest, in the Util.getManifest(...) method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira