You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "lburgazzoli (via GitHub)" <gi...@apache.org> on 2023/02/17 08:21:10 UTC

[GitHub] [camel-k] lburgazzoli commented on a diff in pull request #4064: Move pod's phase indexer to integration controller initialization

lburgazzoli commented on code in PR #4064:
URL: https://github.com/apache/camel-k/pull/4064#discussion_r1109425998


##########
pkg/controller/integration/integration_controller.go:
##########
@@ -55,6 +57,16 @@ import (
 )
 
 func Add(mgr manager.Manager, c client.Client) error {
+	err := mgr.GetFieldIndexer().IndexField(context.Background(), &corev1.Pod{}, "status.phase",

Review Comment:
   Yep, that was a question I had in mind, maybe  the `Add` method should always require a context ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org