You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/12/14 23:57:07 UTC

Review Request 54764: Replaced `::pipe` with `os::pipe` in mesos.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54764/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

Replaced `::pipe` with `os::pipe` in mesos.


Diffs
-----

  src/slave/containerizer/mesos/containerizer.cpp a4daff627db6e82c3d26070668b05195f1df1385 
  src/slave/containerizer/mesos/io/switchboard.cpp c80627986f729255e3b3ad1fc9cfa6213e19c521 
  src/slave/containerizer/mesos/io/switchboard_main.cpp 87056c3f76525151834b4ff782e2009050941ccb 
  src/tests/containerizer/io_switchboard_tests.cpp 5bd9dc4a776fe8a0d04ed31aa167f10c394984e6 
  src/tests/containerizer/nested_mesos_containerizer_tests.cpp 9a6bcb54f77f8343786f42e3cb511f2e95aaff5e 

Diff: https://reviews.apache.org/r/54764/diff/


Testing
-------


Thanks,

Michael Park

Re: Review Request 54764: Replaced `::pipe` with `os::pipe` in mesos.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54764/#review159257
-----------------------------------------------------------



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos ReviewBot


On Dec. 14, 2016, 11:57 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54764/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2016, 11:57 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced `::pipe` with `os::pipe` in mesos.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp a4daff627db6e82c3d26070668b05195f1df1385 
>   src/slave/containerizer/mesos/io/switchboard.cpp c80627986f729255e3b3ad1fc9cfa6213e19c521 
>   src/slave/containerizer/mesos/io/switchboard_main.cpp 87056c3f76525151834b4ff782e2009050941ccb 
>   src/tests/containerizer/io_switchboard_tests.cpp 5bd9dc4a776fe8a0d04ed31aa167f10c394984e6 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 9a6bcb54f77f8343786f42e3cb511f2e95aaff5e 
> 
> Diff: https://reviews.apache.org/r/54764/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>