[GitHub] [ozone] bshashikant commented on a change in pull request #1940: HDDS-4821. Use SCM service ID in SCMBlockClient and SCM Client.

[GitBox <gi...@apache.org>]

bshashikant commented on a change in pull request #1940:
URL: https://github.com/apache/ozone/pull/1940#discussion_r579001038



##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAUtils.java
##########
@@ -101,4 +103,32 @@ public static String getSCMRatisSnapshotDirectory(ConfigurationSource conf) {
     }
     return snapshotDir;
   }
+
+  /**
+   * Get SCM ServiceId from OzoneConfiguration.
+   * @param conf
+   * @return SCM service id if defined, else null.
+   */
+  public static String getScmServiceId(ConfigurationSource conf) {
+
+    String localScmServiceId = conf.getTrimmed(
+        ScmConfigKeys.OZONE_SCM_DEFAULT_SERVICE_ID);
+
+    Collection< String > scmServiceIds;

Review comment:
       Collection< String > -> Collection<String>

##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMNodeInfo.java
##########
@@ -0,0 +1,246 @@
+/*

Review comment:
       Can't we reuse SCMNodeDetails class here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org