You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/25 10:39:59 UTC
[GitHub] [skywalking] dmsolr opened a new pull request #7565: Enable mTLS for gRPC channel
dmsolr opened a new pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06e391f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `13.50%`.
> The diff coverage is `2.32%`.
> :exclamation: Current head 06e391f differs from pull request most recent head 8b9dab0. Consider uploading reports for the commit 8b9dab0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 40.49% -13.51%
+ Complexity 4386 3076 -1310
=============================================
Files 1903 1044 -859
Lines 41371 26730 -14641
Branches 4632 2634 -1998
=============================================
- Hits 22340 10824 -11516
+ Misses 17889 15025 -2864
+ Partials 1142 881 -261
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1450 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng edited a comment on pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-909750671
@dmsolr We are locking the agent images(https://github.com/apache/skywalking/pull/7625) to make the test predictable. After merge and sync, your PR should run with the latest agent codes directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#discussion_r699437159
##########
File path: docs/en/setup/backend/grpc-security.md
##########
@@ -44,3 +44,28 @@ gRPCSslCertChainPath: /path/to/server.crt
Since `sharding-server` only receives data from an external source, it doesn't need a CA at all.
If you port to Java agent, refer to [the Java agent repo](http://github.com/apache/skywalking-java) to config java agent and enable TLS.
+
+## mutual TLS mode
+
+To enable `mTLS` mode for gRPC channel requires [Sharing gRPC Server](./backend-receivers.md/#grpchttp-server-for-receiver) enabled, as following configuration.
+
+```properties
+receiver-sharing-server:
+ selector: ${SW_RECEIVER_SHARING_SERVER:default}
+ default:
+ # For gRPC server
+ gRPCHost: ${SW_RECEIVER_GRPC_HOST:0.0.0.0}
+ gRPCPort: ${SW_RECEIVER_GRPC_PORT:11801}
+ maxConcurrentCallsPerConnection: ${SW_RECEIVER_GRPC_MAX_CONCURRENT_CALL:0}
+ maxMessageSize: ${SW_RECEIVER_GRPC_MAX_MESSAGE_SIZE:0}
+ gRPCThreadPoolQueueSize: ${SW_RECEIVER_GRPC_POOL_QUEUE_SIZE:0}
+ gRPCThreadPoolSize: ${SW_RECEIVER_GRPC_THREAD_POOL_SIZE:0}
+ gRPCSslEnabled: ${SW_RECEIVER_GRPC_SSL_ENABLED:true}
+ gRPCSslKeyPath: ${SW_RECEIVER_GRPC_SSL_KEY_PATH:"/path/to/server.pem"}
+ gRPCSslCertChainPath: ${SW_RECEIVER_GRPC_SSL_CERT_CHAIN_PATH:"/path/to/server.crt"}
+ gRPCSslTrustedCAsPath: ${SW_RECEIVER_GRPC_SSL_TRUSTED_CAS_PATH:"/path/to/ca.crt"}
+ authentication: ${SW_AUTHENTICATION:""}
+```
Review comment:
A question, could you share what are the major differences of settings between mTLS and `Config OAP server` part?
##########
File path: docs/en/setup/backend/grpc-security.md
##########
@@ -44,3 +44,28 @@ gRPCSslCertChainPath: /path/to/server.crt
Since `sharding-server` only receives data from an external source, it doesn't need a CA at all.
If you port to Java agent, refer to [the Java agent repo](http://github.com/apache/skywalking-java) to config java agent and enable TLS.
+
+## mutual TLS mode
+
+To enable `mTLS` mode for gRPC channel requires [Sharing gRPC Server](./backend-receivers.md/#grpchttp-server-for-receiver) enabled, as following configuration.
+
+```properties
+receiver-sharing-server:
+ selector: ${SW_RECEIVER_SHARING_SERVER:default}
+ default:
+ # For gRPC server
+ gRPCHost: ${SW_RECEIVER_GRPC_HOST:0.0.0.0}
+ gRPCPort: ${SW_RECEIVER_GRPC_PORT:11801}
+ maxConcurrentCallsPerConnection: ${SW_RECEIVER_GRPC_MAX_CONCURRENT_CALL:0}
+ maxMessageSize: ${SW_RECEIVER_GRPC_MAX_MESSAGE_SIZE:0}
+ gRPCThreadPoolQueueSize: ${SW_RECEIVER_GRPC_POOL_QUEUE_SIZE:0}
+ gRPCThreadPoolSize: ${SW_RECEIVER_GRPC_THREAD_POOL_SIZE:0}
+ gRPCSslEnabled: ${SW_RECEIVER_GRPC_SSL_ENABLED:true}
+ gRPCSslKeyPath: ${SW_RECEIVER_GRPC_SSL_KEY_PATH:"/path/to/server.pem"}
+ gRPCSslCertChainPath: ${SW_RECEIVER_GRPC_SSL_CERT_CHAIN_PATH:"/path/to/server.crt"}
+ gRPCSslTrustedCAsPath: ${SW_RECEIVER_GRPC_SSL_TRUSTED_CAS_PATH:"/path/to/ca.crt"}
+ authentication: ${SW_AUTHENTICATION:""}
+```
Review comment:
And this is not documented yet, https://github.com/apache/skywalking/pull/7565#discussion_r698094625.
Could you polish the whole document, and make the whole doc more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `0.12%`.
> The diff coverage is `11.62%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 53.87% -0.13%
+ Complexity 4386 4155 -231
============================================
Files 1903 1073 -830
Lines 41371 27252 -14119
Branches 4632 2698 -1934
============================================
- Hits 22340 14682 -7658
+ Misses 17889 11277 -6612
- Partials 1142 1293 +151
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1374 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06e391f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `21.13%`.
> The diff coverage is `2.32%`.
> :exclamation: Current head 06e391f differs from pull request most recent head 8b9dab0. Consider uploading reports for the commit 8b9dab0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 32.86% -21.14%
+ Complexity 4386 2485 -1901
=============================================
Files 1903 1013 -890
Lines 41371 25693 -15678
Branches 4632 2535 -2097
=============================================
- Hits 22340 8443 -13897
+ Misses 17889 16586 -1303
+ Partials 1142 664 -478
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1507 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#discussion_r698094625
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/util/PrivateKeyUtil.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.skywalking.apm.agent.core.util;
+
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+import java.util.Base64;
+
+/**
+ * Util intends to parse PKCS#1 and PKCS#8 at same time.
Review comment:
yes, but we should document private key supports PKCS#8 and PKCS#1 for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 182 -1721
Lines 41371 4603 -36768
Branches 4632 532 -4100
============================================
- Hits 22340 0 -22340
+ Misses 17889 4603 -13286
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1873 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `1.89%`.
> The diff coverage is `41.86%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 55.89% +1.89%
+ Complexity 4386 4332 -54
============================================
Files 1903 1077 -826
Lines 41371 27506 -13865
Branches 4632 2728 -1904
============================================
- Hits 22340 15374 -6966
+ Misses 17889 10800 -7089
- Partials 1142 1332 +190
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1353 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ebda726) into [master](https://codecov.io/gh/apache/skywalking/commit/db2bc935737ee24ad79b6f237b0eaa60991434ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db2bc93) will **decrease** coverage by `1.85%`.
> The diff coverage is `13.63%`.
> :exclamation: Current head ebda726 differs from pull request most recent head f417a77. Consider uploading reports for the commit f417a77 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 54.14% 52.28% -1.86%
+ Complexity 4407 4048 -359
============================================
Files 1903 1040 -863
Lines 41371 26727 -14644
Branches 4632 2637 -1995
============================================
- Hits 22401 13975 -8426
+ Misses 17827 11520 -6307
- Partials 1143 1232 +89
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `23.07% <20.00%> (-13.29%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1374 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...f417a77](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06e391f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `3.22%`.
> The diff coverage is `41.86%`.
> :exclamation: Current head 06e391f differs from pull request most recent head 8b9dab0. Consider uploading reports for the commit 8b9dab0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 57.22% +3.22%
+ Complexity 4386 4308 -78
============================================
Files 1903 1044 -859
Lines 41371 26782 -14589
Branches 4632 2645 -1987
============================================
- Hits 22340 15326 -7014
+ Misses 17889 10106 -7783
- Partials 1142 1350 +208
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `53.96% <100.00%> (-3.18%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1360 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `4.31%`.
> The diff coverage is `51.85%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 90f199e. Consider uploading reports for the commit 90f199e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 57.99% +4.31%
- Complexity 4334 4374 +40
============================================
Files 1903 1050 -853
Lines 41395 26956 -14439
Branches 4635 2661 -1974
============================================
- Hits 22219 15633 -6586
+ Misses 18035 9939 -8096
- Partials 1141 1384 +243
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [313edd3...90f199e](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] dmsolr commented on a change in pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#discussion_r696652549
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/util/PrivateKeyUtil.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.skywalking.apm.agent.core.util;
+
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+import java.util.Base64;
+
+/**
+ * Util intends to parse PKCS#1 and PKCS#8 at same time.
Review comment:
I am not familiar with this. May I improve it in new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e04af6f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 178 -1725
Lines 41371 4544 -36827
Branches 4632 527 -4105
============================================
- Hits 22340 0 -22340
+ Misses 17889 4544 -13345
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1854 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...e04af6f](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `11.01%`.
> The diff coverage is `2.32%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 42.98% -11.02%
+ Complexity 4386 3231 -1155
=============================================
Files 1903 1073 -830
Lines 41371 27240 -14131
Branches 4632 2698 -1934
=============================================
- Hits 22340 11709 -10631
+ Misses 17889 14563 -3326
+ Partials 1142 968 -174
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1445 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `15.71%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.67% 37.96% -15.72%
+ Complexity 4334 2867 -1467
=============================================
Files 1903 1048 -855
Lines 41395 26773 -14622
Branches 4635 2636 -1999
=============================================
- Hits 22219 10164 -12055
+ Misses 18035 15815 -2220
+ Partials 1141 794 -347
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1479 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905472193
You have CI failure and conflict, please resolve them first. About the mTLS, it is better we consider a new e2e case, single service to OAP server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] dmsolr commented on a change in pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#discussion_r699789263
##########
File path: docs/en/setup/backend/grpc-security.md
##########
@@ -44,3 +44,28 @@ gRPCSslCertChainPath: /path/to/server.crt
Since `sharding-server` only receives data from an external source, it doesn't need a CA at all.
If you port to Java agent, refer to [the Java agent repo](http://github.com/apache/skywalking-java) to config java agent and enable TLS.
+
+## mutual TLS mode
+
+To enable `mTLS` mode for gRPC channel requires [Sharing gRPC Server](./backend-receivers.md/#grpchttp-server-for-receiver) enabled, as following configuration.
+
+```properties
+receiver-sharing-server:
+ selector: ${SW_RECEIVER_SHARING_SERVER:default}
+ default:
+ # For gRPC server
+ gRPCHost: ${SW_RECEIVER_GRPC_HOST:0.0.0.0}
+ gRPCPort: ${SW_RECEIVER_GRPC_PORT:11801}
+ maxConcurrentCallsPerConnection: ${SW_RECEIVER_GRPC_MAX_CONCURRENT_CALL:0}
+ maxMessageSize: ${SW_RECEIVER_GRPC_MAX_MESSAGE_SIZE:0}
+ gRPCThreadPoolQueueSize: ${SW_RECEIVER_GRPC_POOL_QUEUE_SIZE:0}
+ gRPCThreadPoolSize: ${SW_RECEIVER_GRPC_THREAD_POOL_SIZE:0}
+ gRPCSslEnabled: ${SW_RECEIVER_GRPC_SSL_ENABLED:true}
+ gRPCSslKeyPath: ${SW_RECEIVER_GRPC_SSL_KEY_PATH:"/path/to/server.pem"}
+ gRPCSslCertChainPath: ${SW_RECEIVER_GRPC_SSL_CERT_CHAIN_PATH:"/path/to/server.crt"}
+ gRPCSslTrustedCAsPath: ${SW_RECEIVER_GRPC_SSL_TRUSTED_CAS_PATH:"/path/to/ca.crt"}
+ authentication: ${SW_AUTHENTICATION:""}
+```
Review comment:
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5eaf3af) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `24.71%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.67% 28.96% -24.72%
=============================================
Files 1903 1808 -95
Lines 41395 38679 -2716
Branches 4635 4859 +224
=============================================
- Hits 22219 11203 -11016
- Misses 18035 26413 +8378
+ Partials 1141 1063 -78
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-79.67%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `0.00% <0.00%> (-57.15%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-29.88%)` | :arrow_down: |
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [883 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `20.30%`.
> The diff coverage is `2.32%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 33.69% -20.31%
+ Complexity 4386 2675 -1711
=============================================
Files 1903 1073 -830
Lines 41371 27203 -14168
Branches 4632 2699 -1933
=============================================
- Hits 22340 9165 -13175
+ Misses 17889 17325 -564
+ Partials 1142 713 -429
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1482 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b9dab0) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 195 -1708
Lines 41371 4855 -36516
Branches 4632 559 -4073
============================================
- Hits 22340 0 -22340
+ Misses 17889 4855 -13034
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1876 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `4.31%`.
> The diff coverage is `51.85%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head f1ab04a. Consider uploading reports for the commit f1ab04a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 57.99% +4.31%
- Complexity 4334 4374 +40
============================================
Files 1903 1050 -853
Lines 41395 26956 -14439
Branches 4635 2661 -1974
============================================
- Hits 22219 15633 -6586
+ Misses 18035 9939 -8096
- Partials 1141 1384 +243
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ee16a1d...f1ab04a](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f417a77) into [master](https://codecov.io/gh/apache/skywalking/commit/db2bc935737ee24ad79b6f237b0eaa60991434ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db2bc93) will **decrease** coverage by `54.14%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 54.14% 0.00% -54.15%
============================================
Files 1903 213 -1690
Lines 41371 5169 -36202
Branches 4632 604 -4028
============================================
- Hits 22401 0 -22401
+ Misses 17827 5169 -12658
+ Partials 1143 0 -1143
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1876 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...f417a77](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `4.31%`.
> The diff coverage is `51.85%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head f2ba9a5. Consider uploading reports for the commit f2ba9a5 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 57.99% +4.31%
- Complexity 4334 4374 +40
============================================
Files 1903 1050 -853
Lines 41395 26956 -14439
Branches 4635 2661 -1974
============================================
- Hits 22219 15633 -6586
+ Misses 18035 9939 -8096
- Partials 1141 1384 +243
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [444adc6...f2ba9a5](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06e391f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `17.14%`.
> The diff coverage is `2.32%`.
> :exclamation: Current head 06e391f differs from pull request most recent head 8b9dab0. Consider uploading reports for the commit 8b9dab0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 36.85% -17.15%
+ Complexity 4386 2845 -1541
=============================================
Files 1903 1044 -859
Lines 41371 26694 -14677
Branches 4632 2633 -1999
=============================================
- Hits 22340 9839 -12501
+ Misses 17889 16053 -1836
+ Partials 1142 802 -340
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1475 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `4.31%`.
> The diff coverage is `51.85%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head c0a366f. Consider uploading reports for the commit c0a366f to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 57.99% +4.31%
- Complexity 4334 4374 +40
============================================
Files 1903 1050 -853
Lines 41395 26956 -14439
Branches 4635 2661 -1974
============================================
- Hits 22219 15633 -6586
+ Misses 18035 9939 -8096
- Partials 1141 1384 +243
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [313edd3...c0a366f](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `1.62%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 55.29% +1.62%
+ Complexity 4334 4190 -144
============================================
Files 1903 1050 -853
Lines 41395 26928 -14467
Branches 4635 2656 -1979
============================================
- Hits 22219 14890 -7329
+ Misses 18035 10716 -7319
- Partials 1141 1322 +181
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `47.61% <33.33%> (-9.53%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1362 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `16.47%`.
> The diff coverage is `2.32%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 37.51% -16.48%
+ Complexity 4386 2939 -1447
=============================================
Files 1903 1074 -829
Lines 41371 27274 -14097
Branches 4632 2700 -1932
=============================================
- Hits 22340 10233 -12107
+ Misses 17889 16232 -1657
+ Partials 1142 809 -333
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1468 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 214 -1689
Lines 41371 5208 -36163
Branches 4632 603 -4029
============================================
- Hits 22340 0 -22340
+ Misses 17889 5208 -12681
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1852 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `18.44%`.
> The diff coverage is `2.32%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 35.55% -18.45%
+ Complexity 4386 2824 -1562
=============================================
Files 1903 1074 -829
Lines 41371 27255 -14116
Branches 4632 2700 -1932
=============================================
- Hits 22340 9690 -12650
+ Misses 17889 16807 -1082
+ Partials 1142 758 -384
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1475 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `1.94%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 55.62% +1.94%
+ Complexity 4334 4210 -124
============================================
Files 1903 1050 -853
Lines 41395 26928 -14467
Branches 4635 2656 -1979
============================================
- Hits 22219 14978 -7241
+ Misses 18035 10613 -7422
- Partials 1141 1337 +196
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `47.61% <33.33%> (-9.53%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1360 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5fc2701) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `21.88%`.
> The diff coverage is `4.34%`.
> :exclamation: Current head 5fc2701 differs from pull request most recent head 997e768. Consider uploading reports for the commit 997e768 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 32.11% -21.89%
+ Complexity 4386 2035 -2351
=============================================
Files 1903 846 -1057
Lines 41371 21379 -19992
Branches 4632 2030 -2602
=============================================
- Hits 22340 6865 -15475
+ Misses 17889 14020 -3869
+ Partials 1142 494 -648
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ache/skywalking/oap/meter/analyzer/dsl/Sample.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ing/oap/server/core/storage/IHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9JSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1554 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `4.57%`.
> The diff coverage is `11.62%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 49.42% -4.58%
+ Complexity 4386 3964 -422
============================================
Files 1903 1077 -826
Lines 41371 27365 -14006
Branches 4632 2713 -1919
============================================
- Hits 22340 13526 -8814
+ Misses 17889 12643 -5246
- Partials 1142 1196 +54
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1386 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.02%`.
> The diff coverage is `41.86%`.
> :exclamation: Current head 3994315 differs from pull request most recent head df0ea9b. Consider uploading reports for the commit df0ea9b to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.02% +2.02%
+ Complexity 4386 4341 -45
============================================
Files 1903 1077 -826
Lines 41371 27506 -13865
Branches 4632 2728 -1904
============================================
- Hits 22340 15411 -6929
+ Misses 17889 10754 -7135
- Partials 1142 1341 +199
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1352 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...df0ea9b](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `53.67%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.67% 0.00% -53.68%
============================================
Files 1903 181 -1722
Lines 41395 4553 -36842
Branches 4635 525 -4110
============================================
- Hits 22219 0 -22219
+ Misses 18035 4553 -13482
+ Partials 1141 0 -1141
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1872 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `1.11%`.
> The diff coverage is `11.62%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 52.88% -1.12%
+ Complexity 4386 4106 -280
============================================
Files 1903 1073 -830
Lines 41371 27252 -14119
Branches 4632 2698 -1934
============================================
- Hits 22340 14413 -7927
+ Misses 17889 11557 -6332
- Partials 1142 1282 +140
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1382 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `26.98%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.67% 26.69% -26.99%
+ Complexity 4334 2030 -2304
=============================================
Files 1903 1017 -886
Lines 41395 25597 -15798
Branches 4635 2506 -2129
=============================================
- Hits 22219 6832 -15387
- Misses 18035 18266 +231
+ Partials 1141 499 -642
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1558 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `32.78%`.
> The diff coverage is `2.32%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 21.21% -32.79%
+ Complexity 4386 1704 -2682
=============================================
Files 1903 1038 -865
Lines 41371 25781 -15590
Branches 4632 2517 -2115
=============================================
- Hits 22340 5469 -16871
- Misses 17889 19902 +2013
+ Partials 1142 410 -732
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1583 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `1.28%`.
> The diff coverage is `10.52%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 52.70% -1.29%
+ Complexity 4386 4137 -249
============================================
Files 1903 1077 -826
Lines 41371 27494 -13877
Branches 4632 2725 -1907
============================================
- Hits 22340 14492 -7848
+ Misses 17889 11739 -6150
- Partials 1142 1263 +121
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| ... and [1355 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b9dab0) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 182 -1721
Lines 41371 4581 -36790
Branches 4632 529 -4103
============================================
- Hits 22340 0 -22340
+ Misses 17889 4581 -13308
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1875 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905950177
Existing SSL tests fail, please recheck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06e391f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `4.30%`.
> The diff coverage is `41.86%`.
> :exclamation: Current head 06e391f differs from pull request most recent head 997e768. Consider uploading reports for the commit 997e768 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 58.30% +4.30%
- Complexity 4386 4394 +8
============================================
Files 1903 1048 -855
Lines 41371 26933 -14438
Branches 4632 2661 -1971
============================================
- Hits 22340 15704 -6636
+ Misses 17889 9843 -8046
- Partials 1142 1386 +244
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1348 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `29.93%`.
> The diff coverage is `2.32%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 24.06% -29.94%
+ Complexity 4386 1902 -2484
=============================================
Files 1903 1038 -865
Lines 41371 25834 -15537
Branches 4632 2524 -2108
=============================================
- Hits 22340 6217 -16123
- Misses 17889 19149 +1260
+ Partials 1142 468 -674
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1576 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5eaf3af) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `53.67%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.67% 0.00% -53.68%
============================================
Files 1903 180 -1723
Lines 41395 4548 -36847
Branches 4635 525 -4110
============================================
- Hits 22219 0 -22219
+ Misses 18035 4548 -13487
+ Partials 1141 0 -1141
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1872 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b9dab0) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 190 -1713
Lines 41371 4744 -36627
Branches 4632 554 -4078
============================================
- Hits 22340 0 -22340
+ Misses 17889 4744 -13145
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1876 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 merged pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#discussion_r701210579
##########
File path: oap-server/server-bootstrap/src/main/java/org/apache/skywalking/oap/server/starter/OAPServerBootstrap.java
##########
@@ -58,4 +58,8 @@ public static void start() {
System.exit(1);
}
}
+
+ public static void main(String[] args) {
+ OAPServerBootstrap.start();
+ }
Review comment:
Why add this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 209 -1694
Lines 41371 5062 -36309
Branches 4632 591 -4041
============================================
- Hits 22340 0 -22340
+ Misses 17889 5062 -12827
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1875 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#discussion_r697975078
##########
File path: docs/en/setup/backend/grpc-ssl.md
##########
@@ -44,3 +44,25 @@ gRPCSslCertChainPath: /path/to/server.crt
Since `sharding-server` only receives data from an external source, it doesn't need a CA at all.
If you port to Java agent, refer to [the Java agent repo](http://github.com/apache/skywalking-java) to config java agent and enable TLS.
+
+## mutual TLS mode
Review comment:
I noticed this `grpc-ssl.md ` has not been referenced in any place of the repo.
Please add a menu here,

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ebda726) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `0.29%`.
> The diff coverage is `13.63%`.
> :exclamation: Current head ebda726 differs from pull request most recent head 8b9dab0. Consider uploading reports for the commit 8b9dab0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 53.69% -0.30%
+ Complexity 4386 4127 -259
============================================
Files 1903 1045 -858
Lines 41371 26803 -14568
Branches 4632 2645 -1987
============================================
- Hits 22340 14393 -7947
+ Misses 17889 11143 -6746
- Partials 1142 1267 +125
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `23.07% <20.00%> (-13.29%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1365 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `15.55%`.
> The diff coverage is `2.32%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 38.44% -15.56%
+ Complexity 4386 3008 -1378
=============================================
Files 1903 1074 -829
Lines 41371 27289 -14082
Branches 4632 2704 -1928
=============================================
- Hits 22340 10490 -11850
+ Misses 17889 15965 -1924
+ Partials 1142 834 -308
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1459 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 205 -1698
Lines 41371 5027 -36344
Branches 4632 590 -4042
============================================
- Hits 22340 0 -22340
+ Misses 17889 5027 -12862
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1874 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.75%`.
> The diff coverage is `32.89%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.75% +2.75%
+ Complexity 4386 4365 -21
============================================
Files 1903 1077 -826
Lines 41371 27532 -13839
Branches 4632 2731 -1901
============================================
- Hits 22340 15625 -6715
+ Misses 17889 10516 -7373
- Partials 1142 1391 +249
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `78.26% <81.81%> (-2.70%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| ... and [1334 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `4.31%`.
> The diff coverage is `51.85%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head e5c0d37. Consider uploading reports for the commit e5c0d37 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 57.99% +4.31%
- Complexity 4334 4374 +40
============================================
Files 1903 1050 -853
Lines 41395 26956 -14439
Branches 4635 2661 -1974
============================================
- Hits 22219 15633 -6586
+ Misses 18035 9939 -8096
- Partials 1141 1384 +243
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0ab10ab...e5c0d37](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-909750671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5eaf3af) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `53.67%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.67% 0.00% -53.68%
============================================
Files 1903 198 -1705
Lines 41395 4917 -36478
Branches 4635 567 -4068
============================================
- Hits 22219 0 -22219
+ Misses 18035 4917 -13118
+ Partials 1141 0 -1141
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1872 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `16.36%`.
> The diff coverage is `2.32%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 37.62% -16.37%
+ Complexity 4386 2877 -1509
=============================================
Files 1903 1070 -833
Lines 41371 27069 -14302
Branches 4632 2666 -1966
=============================================
- Hits 22340 10186 -12154
+ Misses 17889 16071 -1818
+ Partials 1142 812 -330
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1474 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `16.38%`.
> The diff coverage is `2.32%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 37.61% -16.39%
+ Complexity 4386 2875 -1511
=============================================
Files 1903 1070 -833
Lines 41371 27069 -14302
Branches 4632 2666 -1966
=============================================
- Hits 22340 10182 -12158
+ Misses 17889 16075 -1814
+ Partials 1142 812 -330
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1474 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (071ce4e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `0.82%`.
> The diff coverage is `6.84%`.
> :exclamation: Current head 071ce4e differs from pull request most recent head 64980eb. Consider uploading reports for the commit 64980eb to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 53.17% -0.83%
+ Complexity 4386 4143 -243
============================================
Files 1903 1068 -835
Lines 41371 27311 -14060
Branches 4632 2710 -1922
============================================
- Hits 22340 14523 -7817
+ Misses 17889 11527 -6362
- Partials 1142 1261 +119
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| ... and [1350 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...64980eb](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 205 -1698
Lines 41371 5014 -36357
Branches 4632 587 -4045
============================================
- Hits 22340 0 -22340
+ Misses 17889 5014 -12875
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1877 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `11.38%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.67% 42.28% -11.39%
+ Complexity 4334 3130 -1204
=============================================
Files 1903 1048 -855
Lines 41395 26862 -14533
Branches 4635 2644 -1991
=============================================
- Hits 22219 11359 -10860
+ Misses 18035 14604 -3431
+ Partials 1141 899 -242
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `47.61% <33.33%> (-9.53%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1457 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ebda726) into [master](https://codecov.io/gh/apache/skywalking/commit/db2bc935737ee24ad79b6f237b0eaa60991434ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db2bc93) will **decrease** coverage by `1.12%`.
> The diff coverage is `13.63%`.
> :exclamation: Current head ebda726 differs from pull request most recent head f417a77. Consider uploading reports for the commit f417a77 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 54.14% 53.02% -1.13%
+ Complexity 4407 4087 -320
============================================
Files 1903 1045 -858
Lines 41371 26803 -14568
Branches 4632 2645 -1987
============================================
- Hits 22401 14211 -8190
+ Misses 17827 11336 -6491
- Partials 1143 1256 +113
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `23.07% <20.00%> (-13.29%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1371 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...f417a77](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `11.36%`.
> The diff coverage is `2.32%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 42.63% -11.37%
+ Complexity 4386 3206 -1180
=============================================
Files 1903 1072 -831
Lines 41371 27236 -14135
Branches 4632 2698 -1934
=============================================
- Hits 22340 11612 -10728
+ Misses 17889 14661 -3228
+ Partials 1142 963 -179
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1449 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `15.10%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.67% 38.57% -15.11%
+ Complexity 4334 2897 -1437
=============================================
Files 1903 1048 -855
Lines 41395 26773 -14622
Branches 4635 2636 -1999
=============================================
- Hits 22219 10327 -11892
+ Misses 18035 15635 -2400
+ Partials 1141 811 -330
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1479 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `0.16%`.
> The diff coverage is `10.52%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 53.83% -0.17%
+ Complexity 4386 4186 -200
============================================
Files 1903 1077 -826
Lines 41371 27504 -13867
Branches 4632 2726 -1906
============================================
- Hits 22340 14807 -7533
+ Misses 17889 11399 -6490
- Partials 1142 1298 +156
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| ... and [1354 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5eaf3af) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `53.67%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.67% 0.00% -53.68%
============================================
Files 1903 189 -1714
Lines 41395 4763 -36632
Branches 4635 554 -4081
============================================
- Hits 22219 0 -22219
+ Misses 18035 4763 -13272
+ Partials 1141 0 -1141
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1871 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#discussion_r699437159
##########
File path: docs/en/setup/backend/grpc-security.md
##########
@@ -44,3 +44,28 @@ gRPCSslCertChainPath: /path/to/server.crt
Since `sharding-server` only receives data from an external source, it doesn't need a CA at all.
If you port to Java agent, refer to [the Java agent repo](http://github.com/apache/skywalking-java) to config java agent and enable TLS.
+
+## mutual TLS mode
+
+To enable `mTLS` mode for gRPC channel requires [Sharing gRPC Server](./backend-receivers.md/#grpchttp-server-for-receiver) enabled, as following configuration.
+
+```properties
+receiver-sharing-server:
+ selector: ${SW_RECEIVER_SHARING_SERVER:default}
+ default:
+ # For gRPC server
+ gRPCHost: ${SW_RECEIVER_GRPC_HOST:0.0.0.0}
+ gRPCPort: ${SW_RECEIVER_GRPC_PORT:11801}
+ maxConcurrentCallsPerConnection: ${SW_RECEIVER_GRPC_MAX_CONCURRENT_CALL:0}
+ maxMessageSize: ${SW_RECEIVER_GRPC_MAX_MESSAGE_SIZE:0}
+ gRPCThreadPoolQueueSize: ${SW_RECEIVER_GRPC_POOL_QUEUE_SIZE:0}
+ gRPCThreadPoolSize: ${SW_RECEIVER_GRPC_THREAD_POOL_SIZE:0}
+ gRPCSslEnabled: ${SW_RECEIVER_GRPC_SSL_ENABLED:true}
+ gRPCSslKeyPath: ${SW_RECEIVER_GRPC_SSL_KEY_PATH:"/path/to/server.pem"}
+ gRPCSslCertChainPath: ${SW_RECEIVER_GRPC_SSL_CERT_CHAIN_PATH:"/path/to/server.crt"}
+ gRPCSslTrustedCAsPath: ${SW_RECEIVER_GRPC_SSL_TRUSTED_CAS_PATH:"/path/to/ca.crt"}
+ authentication: ${SW_AUTHENTICATION:""}
+```
Review comment:
A question, could you share what are the major differences of settings between mTLS and `Config OAP server` part?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f417a77) into [master](https://codecov.io/gh/apache/skywalking/commit/db2bc935737ee24ad79b6f237b0eaa60991434ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db2bc93) will **decrease** coverage by `6.13%`.
> The diff coverage is `13.63%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 54.14% 48.01% -6.14%
+ Complexity 4407 3853 -554
============================================
Files 1903 1076 -827
Lines 41371 27439 -13932
Branches 4632 2719 -1913
============================================
- Hits 22401 13175 -9226
+ Misses 17827 13097 -4730
- Partials 1143 1167 +24
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `23.07% <20.00%> (-13.29%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1403 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...f417a77](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06e391f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `10.55%`.
> The diff coverage is `2.32%`.
> :exclamation: Current head 06e391f differs from pull request most recent head 8b9dab0. Consider uploading reports for the commit 8b9dab0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 43.44% -10.56%
+ Complexity 4386 3248 -1138
=============================================
Files 1903 1044 -859
Lines 41371 26743 -14628
Branches 4632 2635 -1997
=============================================
- Hits 22340 11618 -10722
+ Misses 17889 14196 -3693
+ Partials 1142 929 -213
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1433 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.52%`.
> The diff coverage is `11.62%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.52% +2.52%
+ Complexity 4386 4338 -48
============================================
Files 1903 1073 -830
Lines 41371 27340 -14031
Branches 4632 2711 -1921
============================================
- Hits 22340 15454 -6886
+ Misses 17889 10534 -7355
- Partials 1142 1352 +210
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1345 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `1.72%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 55.39% +1.72%
+ Complexity 4334 4202 -132
============================================
Files 1903 1050 -853
Lines 41395 26928 -14467
Branches 4635 2656 -1979
============================================
- Hits 22219 14918 -7301
+ Misses 18035 10688 -7347
- Partials 1141 1322 +181
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `47.61% <33.33%> (-9.53%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1361 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5eaf3af) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `53.67%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.67% 0.00% -53.68%
============================================
Files 1903 187 -1716
Lines 41395 4665 -36730
Branches 4635 537 -4098
============================================
- Hits 22219 0 -22219
+ Misses 18035 4665 -13370
+ Partials 1141 0 -1141
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1872 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.76%`.
> The diff coverage is `32.89%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.76% +2.76%
+ Complexity 4386 4366 -20
============================================
Files 1903 1077 -826
Lines 41371 27532 -13839
Branches 4632 2731 -1901
============================================
- Hits 22340 15628 -6712
+ Misses 17889 10514 -7375
- Partials 1142 1390 +248
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `78.26% <81.81%> (-2.70%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| ... and [1333 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `1.91%`.
> The diff coverage is `27.63%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 55.91% +1.91%
+ Complexity 4386 4323 -63
============================================
Files 1903 1077 -826
Lines 41371 27532 -13839
Branches 4632 2731 -1901
============================================
- Hits 22340 15394 -6946
+ Misses 17889 10772 -7117
- Partials 1142 1366 +224
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| ... and [1338 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.89%`.
> The diff coverage is `32.89%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.89% +2.89%
+ Complexity 4386 4380 -6
============================================
Files 1903 1077 -826
Lines 41371 27532 -13839
Branches 4632 2731 -1901
============================================
- Hits 22340 15665 -6675
+ Misses 17889 10478 -7411
- Partials 1142 1389 +247
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `78.26% <81.81%> (-2.70%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| ... and [1330 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 208 -1695
Lines 41371 5061 -36310
Branches 4632 591 -4041
============================================
- Hits 22340 0 -22340
+ Misses 17889 5061 -12828
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1875 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `20.51%`.
> The diff coverage is `2.32%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 33.48% -20.52%
+ Complexity 4386 2615 -1771
=============================================
Files 1903 1070 -833
Lines 41371 27033 -14338
Branches 4632 2665 -1967
=============================================
- Hits 22340 9053 -13287
+ Misses 17889 17256 -633
+ Partials 1142 724 -418
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1490 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 217 -1686
Lines 41371 5223 -36148
Branches 4632 603 -4029
============================================
- Hits 22340 0 -22340
+ Misses 17889 5223 -12666
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1852 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `1.64%`.
> The diff coverage is `11.62%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 55.64% +1.64%
+ Complexity 4386 4297 -89
============================================
Files 1903 1073 -830
Lines 41371 27338 -14033
Branches 4632 2706 -1926
============================================
- Hits 22340 15213 -7127
+ Misses 17889 10803 -7086
- Partials 1142 1322 +180
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1353 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `20.81%`.
> The diff coverage is `2.32%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 33.18% -20.82%
+ Complexity 4386 2604 -1782
=============================================
Files 1903 1070 -833
Lines 41371 27033 -14338
Branches 4632 2665 -1967
=============================================
- Hits 22340 8971 -13369
+ Misses 17889 17350 -539
+ Partials 1142 712 -430
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1493 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `4.31%`.
> The diff coverage is `51.85%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 57.99% +4.31%
- Complexity 4334 4374 +40
============================================
Files 1903 1050 -853
Lines 41395 26956 -14439
Branches 4635 2661 -1974
============================================
- Hits 22219 15633 -6586
+ Misses 18035 9939 -8096
- Partials 1141 1384 +243
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `20.45%`.
> The diff coverage is `2.32%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 33.54% -20.46%
+ Complexity 4386 2669 -1717
=============================================
Files 1903 1073 -830
Lines 41371 27203 -14168
Branches 4632 2699 -1933
=============================================
- Hits 22340 9125 -13215
+ Misses 17889 17371 -518
+ Partials 1142 707 -435
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1482 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f417a77) into [master](https://codecov.io/gh/apache/skywalking/commit/db2bc935737ee24ad79b6f237b0eaa60991434ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db2bc93) will **decrease** coverage by `54.14%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 54.14% 0.00% -54.15%
============================================
Files 1903 215 -1688
Lines 41371 5180 -36191
Branches 4632 604 -4028
============================================
- Hits 22401 0 -22401
+ Misses 17827 5180 -12647
+ Partials 1143 0 -1143
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1876 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...f417a77](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (071ce4e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.47%`.
> The diff coverage is `24.65%`.
> :exclamation: Current head 071ce4e differs from pull request most recent head 64980eb. Consider uploading reports for the commit 64980eb to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.47% +2.47%
+ Complexity 4386 4350 -36
============================================
Files 1903 1075 -828
Lines 41371 27470 -13901
Branches 4632 2724 -1908
============================================
- Hits 22340 15513 -6827
+ Misses 17889 10595 -7294
- Partials 1142 1362 +220
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| ... and [1339 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...64980eb](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `4.31%`.
> The diff coverage is `51.85%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 050a853. Consider uploading reports for the commit 050a853 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 57.99% +4.31%
- Complexity 4334 4374 +40
============================================
Files 1903 1050 -853
Lines 41395 26956 -14439
Branches 4635 2661 -1974
============================================
- Hits 22219 15633 -6586
+ Misses 18035 9939 -8096
- Partials 1141 1384 +243
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0ab10ab...050a853](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `0.86%`.
> The diff coverage is `11.62%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 54.86% +0.86%
+ Complexity 4386 4228 -158
============================================
Files 1903 1073 -830
Lines 41371 27338 -14033
Branches 4632 2706 -1926
============================================
- Hits 22340 14998 -7342
+ Misses 17889 11022 -6867
- Partials 1142 1318 +176
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1364 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `2.79%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 56.47% +2.79%
+ Complexity 4334 4266 -68
============================================
Files 1903 1050 -853
Lines 41395 26928 -14467
Branches 4635 2656 -1979
============================================
- Hits 22219 15207 -7012
+ Misses 18035 10364 -7671
- Partials 1141 1357 +216
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `47.61% <33.33%> (-9.53%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1354 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f417a77) into [master](https://codecov.io/gh/apache/skywalking/commit/db2bc935737ee24ad79b6f237b0eaa60991434ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db2bc93) will **decrease** coverage by `54.14%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 54.14% 0.00% -54.15%
============================================
Files 1903 216 -1687
Lines 41371 5219 -36152
Branches 4632 605 -4027
============================================
- Hits 22401 0 -22401
+ Misses 17827 5219 -12608
+ Partials 1143 0 -1143
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1877 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...f417a77](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `21.47%`.
> The diff coverage is `2.32%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 32.51% -21.48%
+ Complexity 4386 2573 -1813
=============================================
Files 1903 1070 -833
Lines 41371 27033 -14338
Branches 4632 2665 -1967
=============================================
- Hits 22340 8791 -13549
+ Misses 17889 17545 -344
+ Partials 1142 697 -445
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1494 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `1.70%`.
> The diff coverage is `11.62%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 52.29% -1.71%
+ Complexity 4386 4069 -317
============================================
Files 1903 1073 -830
Lines 41371 27249 -14122
Branches 4632 2698 -1934
============================================
- Hits 22340 14251 -8089
+ Misses 17889 11722 -6167
- Partials 1142 1276 +134
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1386 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#discussion_r696385268
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/util/PrivateKeyUtil.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.skywalking.apm.agent.core.util;
+
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+import java.util.Base64;
+
+/**
+ * Util intends to parse PKCS#1 and PKCS#8 at same time.
Review comment:
We should support PKCS#12 which is a more useful private key format than PKCS#8. We should document which key and cert formats are supported by oap and agent
##########
File path: docs/en/setup/service-agent/java-agent/TLS.md
##########
@@ -17,10 +16,24 @@ Only support **no mutual auth**.
## Open and config TLS
### Agent config
-- Place `ca.crt` into `/ca` folder in agent package. Notice, `/ca` is not created in distribution, please create it by yourself.
-
-- Agent open TLS automatically after the `/ca/ca.crt` file detected.
+- Agent open TLS automatically after the `ca.crt`(by default `/ca` folder in agent package) file detected.
- TLS with no CA mode could be activated by this setting.
```
-agent.force_tls=${SW_AGENT_FORCE_TLS:false}
+agent.force_tls=${SW_AGENT_FORCE_TLS:true}
+```
+
+## Enable mutual TLS
+
+- Sharing gRPC server must be started with enabled mTLS. More details see `receiver-sharing-server` section in `application.yaml`. Please refer to [gRPC SSL](../../backend/grpc-ssl.md)
+- Configure Client-side SSL/TLS in `agent.conf`.
+- Change `SW_AGENT_COLLECTOR_BACKEND_SERVICES` to host and port of `receiver-sharing-server`.
+
+For example:
+```
+agent.force_tls=${SW_AGENT_FORCE_TLS:true}
+agent.ssl_trusted_ca_path=${SW_AGENT_SSL_TRUSTED_CA_PATH:/path/to/ca.crt}
+agent.ssl_key_path=${SW_AGENT_SSL_KEY_PATH:/path/to/client.pem}
Review comment:
Could you mention that this key is generated from a CA which should be loaded by OAP?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `23.08%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.67% 30.59% -23.09%
+ Complexity 4334 2370 -1964
=============================================
Files 1903 1048 -855
Lines 41395 26610 -14785
Branches 4635 2604 -2031
=============================================
- Hits 22219 8141 -14078
+ Misses 18035 17866 -169
+ Partials 1141 603 -538
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1518 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `4.31%`.
> The diff coverage is `51.85%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 561ab39. Consider uploading reports for the commit 561ab39 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 57.99% +4.31%
- Complexity 4334 4374 +40
============================================
Files 1903 1050 -853
Lines 41395 26956 -14439
Branches 4635 2661 -1974
============================================
- Hits 22219 15633 -6586
+ Misses 18035 9939 -8096
- Partials 1141 1384 +243
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7d428ec...561ab39](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 216 -1687
Lines 41371 5219 -36152
Branches 4632 603 -4029
============================================
- Hits 22340 0 -22340
+ Misses 17889 5219 -12670
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1852 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `1.93%`.
> The diff coverage is `41.86%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 52.06% -1.94%
+ Complexity 4386 4137 -249
============================================
Files 1903 1077 -826
Lines 41371 27489 -13882
Branches 4632 2727 -1905
============================================
- Hits 22340 14313 -8027
+ Misses 17889 11928 -5961
- Partials 1142 1248 +106
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1368 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-909750671
@dmsolr We are locking the agent images(https://github.com/apache/skywalking/pull/7625) to make the test predictable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (071ce4e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 071ce4e differs from pull request most recent head 64980eb. Consider uploading reports for the commit 64980eb to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 204 -1699
Lines 41371 4993 -36378
Branches 4632 586 -4046
============================================
- Hits 22340 0 -22340
+ Misses 17889 4993 -12896
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1855 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...64980eb](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `18.10%`.
> The diff coverage is `3.94%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 35.89% -18.11%
+ Complexity 4386 2851 -1535
=============================================
Files 1903 1077 -826
Lines 41371 27444 -13927
Branches 4632 2719 -1913
=============================================
- Hits 22340 9850 -12490
+ Misses 17889 16821 -1068
+ Partials 1142 773 -369
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| ... and [1450 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f417a77) into [master](https://codecov.io/gh/apache/skywalking/commit/db2bc935737ee24ad79b6f237b0eaa60991434ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db2bc93) will **decrease** coverage by `16.03%`.
> The diff coverage is `2.27%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 54.14% 38.11% -16.04%
+ Complexity 4407 2882 -1525
=============================================
Files 1903 1045 -858
Lines 41371 26507 -14864
Branches 4632 2629 -2003
=============================================
- Hits 22401 10103 -12298
+ Misses 17827 15593 -2234
+ Partials 1143 811 -332
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1483 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...f417a77](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 207 -1696
Lines 41371 5056 -36315
Branches 4632 591 -4041
============================================
- Hits 22340 0 -22340
+ Misses 17889 5056 -12833
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1875 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `0.84%`.
> The diff coverage is `11.62%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 54.83% +0.84%
+ Complexity 4386 4227 -159
============================================
Files 1903 1073 -830
Lines 41371 27338 -14033
Branches 4632 2706 -1926
============================================
- Hits 22340 14992 -7348
+ Misses 17889 11029 -6860
- Partials 1142 1317 +175
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1364 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06e391f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `20.98%`.
> The diff coverage is `2.32%`.
> :exclamation: Current head 06e391f differs from pull request most recent head 8b9dab0. Consider uploading reports for the commit 8b9dab0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 33.01% -20.99%
+ Complexity 4386 2491 -1895
=============================================
Files 1903 1013 -890
Lines 41371 25693 -15678
Branches 4632 2535 -2097
=============================================
- Hits 22340 8483 -13857
+ Misses 17889 16540 -1349
+ Partials 1142 670 -472
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1507 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `3.22%`.
> The diff coverage is `45.83%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 56.89% +3.22%
- Complexity 4334 4380 +46
============================================
Files 1903 1077 -826
Lines 41395 27532 -13863
Branches 4635 2731 -1904
============================================
- Hits 22219 15665 -6554
+ Misses 18035 10478 -7557
- Partials 1141 1389 +248
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `78.26% <81.81%> (-2.70%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `43.58% <100.00%> (+13.71%)` | :arrow_up: |
| ... and [1348 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06e391f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `3.26%`.
> The diff coverage is `41.86%`.
> :exclamation: Current head 06e391f differs from pull request most recent head 8b9dab0. Consider uploading reports for the commit 8b9dab0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 57.26% +3.26%
+ Complexity 4386 4309 -77
============================================
Files 1903 1044 -859
Lines 41371 26782 -14589
Branches 4632 2645 -1987
============================================
- Hits 22340 15336 -7004
+ Misses 17889 10095 -7794
- Partials 1142 1351 +209
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `53.96% <100.00%> (-3.18%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1360 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-906071456
@hanahmily Please check the mTLS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 180 -1723
Lines 41371 4576 -36795
Branches 4632 528 -4104
============================================
- Hits 22340 0 -22340
+ Misses 17889 4576 -13313
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1874 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.88%`.
> The diff coverage is `11.62%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.88% +2.88%
+ Complexity 4386 4353 -33
============================================
Files 1903 1073 -830
Lines 41371 27340 -14031
Branches 4632 2711 -1921
============================================
- Hits 22340 15553 -6787
+ Misses 17889 10413 -7476
- Partials 1142 1374 +232
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1342 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.02%`.
> The diff coverage is `41.86%`.
> :exclamation: Current head 3994315 differs from pull request most recent head e04af6f. Consider uploading reports for the commit e04af6f to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.02% +2.02%
+ Complexity 4386 4341 -45
============================================
Files 1903 1077 -826
Lines 41371 27506 -13865
Branches 4632 2728 -1904
============================================
- Hits 22340 15411 -6929
+ Misses 17889 10754 -7135
- Partials 1142 1341 +199
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1352 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...e04af6f](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `31.66%`.
> The diff coverage is `2.32%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 22.33% -31.67%
+ Complexity 4386 1784 -2602
=============================================
Files 1903 1038 -865
Lines 41371 25834 -15537
Branches 4632 2524 -2108
=============================================
- Hits 22340 5769 -16571
- Misses 17889 19653 +1764
+ Partials 1142 412 -730
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1581 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `0.06%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.67% 53.61% -0.07%
+ Complexity 4334 4050 -284
============================================
Files 1903 1050 -853
Lines 41395 26910 -14485
Branches 4635 2655 -1980
============================================
- Hits 22219 14427 -7792
+ Misses 18035 11225 -6810
- Partials 1141 1258 +117
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `47.61% <33.33%> (-9.53%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1385 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (071ce4e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.68%`.
> The diff coverage is `30.13%`.
> :exclamation: Current head 071ce4e differs from pull request most recent head 64980eb. Consider uploading reports for the commit 64980eb to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.68% +2.68%
+ Complexity 4386 4357 -29
============================================
Files 1903 1075 -828
Lines 41371 27470 -13901
Branches 4632 2724 -1908
============================================
- Hits 22340 15572 -6768
+ Misses 17889 10517 -7372
- Partials 1142 1381 +239
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `78.26% <81.81%> (-2.70%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| ... and [1339 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...64980eb](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `4.31%`.
> The diff coverage is `51.85%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5459c7a. Consider uploading reports for the commit 5459c7a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 57.99% +4.31%
- Complexity 4334 4374 +40
============================================
Files 1903 1050 -853
Lines 41395 26956 -14439
Branches 4635 2661 -1974
============================================
- Hits 22219 15633 -6586
+ Misses 18035 9939 -8096
- Partials 1141 1384 +243
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0ab10ab...5459c7a](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e04af6f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 183 -1720
Lines 41371 4595 -36776
Branches 4632 529 -4103
============================================
- Hits 22340 0 -22340
+ Misses 17889 4595 -13294
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1854 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...e04af6f](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `1.05%`.
> The diff coverage is `27.63%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 55.05% +1.05%
+ Complexity 4386 4267 -119
============================================
Files 1903 1077 -826
Lines 41371 27532 -13839
Branches 4632 2731 -1901
============================================
- Hits 22340 15158 -7182
+ Misses 17889 11035 -6854
- Partials 1142 1339 +197
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `3.61%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 57.29% +3.61%
+ Complexity 4334 4310 -24
============================================
Files 1903 1050 -853
Lines 41395 26928 -14467
Branches 4635 2656 -1979
============================================
- Hits 22219 15428 -6791
+ Misses 18035 10134 -7901
- Partials 1141 1366 +225
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `47.61% <33.33%> (-9.53%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1348 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `53.67%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.67% 0.00% -53.68%
============================================
Files 1903 180 -1723
Lines 41395 4542 -36853
Branches 4635 525 -4110
============================================
- Hits 22219 0 -22219
+ Misses 18035 4542 -13493
+ Partials 1141 0 -1141
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1872 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `17.67%`.
> The diff coverage is `2.32%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 36.32% -17.68%
+ Complexity 4386 2799 -1587
=============================================
Files 1903 1070 -833
Lines 41371 27069 -14302
Branches 4632 2666 -1966
=============================================
- Hits 22340 9832 -12508
+ Misses 17889 16451 -1438
+ Partials 1142 786 -356
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1481 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06e391f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `10.27%`.
> The diff coverage is `2.32%`.
> :exclamation: Current head 06e391f differs from pull request most recent head 8b9dab0. Consider uploading reports for the commit 8b9dab0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 43.72% -10.28%
+ Complexity 4386 3262 -1124
=============================================
Files 1903 1044 -859
Lines 41371 26745 -14626
Branches 4632 2640 -1992
=============================================
- Hits 22340 11694 -10646
+ Misses 17889 14112 -3777
+ Partials 1142 939 -203
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1429 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `4.31%`.
> The diff coverage is `51.85%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head c358a87. Consider uploading reports for the commit c358a87 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 57.99% +4.31%
- Complexity 4334 4374 +40
============================================
Files 1903 1050 -853
Lines 41395 26956 -14439
Branches 4635 2661 -1974
============================================
- Hits 22219 15633 -6586
+ Misses 18035 9939 -8096
- Partials 1141 1384 +243
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [444adc6...c358a87](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `1.57%`.
> The diff coverage is `41.86%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 55.57% +1.57%
+ Complexity 4386 4305 -81
============================================
Files 1903 1077 -826
Lines 41371 27506 -13865
Branches 4632 2728 -1904
============================================
- Hits 22340 15286 -7054
+ Misses 17889 10894 -6995
- Partials 1142 1326 +184
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1356 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `6.39%`.
> The diff coverage is `11.62%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 47.60% -6.40%
+ Complexity 4386 3831 -555
============================================
Files 1903 1074 -829
Lines 41371 27323 -14048
Branches 4632 2707 -1925
============================================
- Hits 22340 13006 -9334
+ Misses 17889 13186 -4703
+ Partials 1142 1131 -11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1399 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06e391f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `32.37%`.
> The diff coverage is `2.32%`.
> :exclamation: Current head 06e391f differs from pull request most recent head 8b9dab0. Consider uploading reports for the commit 8b9dab0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 21.62% -32.38%
+ Complexity 4386 1706 -2680
=============================================
Files 1903 1012 -891
Lines 41371 25296 -16075
Branches 4632 2454 -2178
=============================================
- Hits 22340 5471 -16869
- Misses 17889 19417 +1528
+ Partials 1142 408 -734
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1583 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-912166171
Strange, etcd IT tests keep failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#discussion_r699440349
##########
File path: docs/en/setup/backend/grpc-security.md
##########
@@ -44,3 +44,28 @@ gRPCSslCertChainPath: /path/to/server.crt
Since `sharding-server` only receives data from an external source, it doesn't need a CA at all.
If you port to Java agent, refer to [the Java agent repo](http://github.com/apache/skywalking-java) to config java agent and enable TLS.
+
+## mutual TLS mode
+
+To enable `mTLS` mode for gRPC channel requires [Sharing gRPC Server](./backend-receivers.md/#grpchttp-server-for-receiver) enabled, as following configuration.
+
+```properties
+receiver-sharing-server:
+ selector: ${SW_RECEIVER_SHARING_SERVER:default}
+ default:
+ # For gRPC server
+ gRPCHost: ${SW_RECEIVER_GRPC_HOST:0.0.0.0}
+ gRPCPort: ${SW_RECEIVER_GRPC_PORT:11801}
+ maxConcurrentCallsPerConnection: ${SW_RECEIVER_GRPC_MAX_CONCURRENT_CALL:0}
+ maxMessageSize: ${SW_RECEIVER_GRPC_MAX_MESSAGE_SIZE:0}
+ gRPCThreadPoolQueueSize: ${SW_RECEIVER_GRPC_POOL_QUEUE_SIZE:0}
+ gRPCThreadPoolSize: ${SW_RECEIVER_GRPC_THREAD_POOL_SIZE:0}
+ gRPCSslEnabled: ${SW_RECEIVER_GRPC_SSL_ENABLED:true}
+ gRPCSslKeyPath: ${SW_RECEIVER_GRPC_SSL_KEY_PATH:"/path/to/server.pem"}
+ gRPCSslCertChainPath: ${SW_RECEIVER_GRPC_SSL_CERT_CHAIN_PATH:"/path/to/server.crt"}
+ gRPCSslTrustedCAsPath: ${SW_RECEIVER_GRPC_SSL_TRUSTED_CAS_PATH:"/path/to/ca.crt"}
+ authentication: ${SW_AUTHENTICATION:""}
+```
Review comment:
And this is not documented yet, https://github.com/apache/skywalking/pull/7565#discussion_r698094625.
Could you polish the whole document, and make the whole doc more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `2.22%`.
> The diff coverage is `41.86%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 51.77% -2.23%
+ Complexity 4386 4123 -263
============================================
Files 1903 1077 -826
Lines 41371 27489 -13882
Branches 4632 2727 -1905
============================================
- Hits 22340 14232 -8108
+ Misses 17889 12013 -5876
- Partials 1142 1244 +102
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1368 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 185 -1718
Lines 41371 4637 -36734
Branches 4632 533 -4099
============================================
- Hits 22340 0 -22340
+ Misses 17889 4637 -13252
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1849 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `2.49%`.
> The diff coverage is `41.86%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 51.50% -2.50%
+ Complexity 4386 4106 -280
============================================
Files 1903 1077 -826
Lines 41371 27489 -13882
Branches 4632 2727 -1905
============================================
- Hits 22340 14159 -8181
+ Misses 17889 12096 -5793
- Partials 1142 1234 +92
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `53.96% <100.00%> (-3.18%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1369 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (071ce4e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `0.32%`.
> The diff coverage is `24.65%`.
> :exclamation: Current head 071ce4e differs from pull request most recent head 64980eb. Consider uploading reports for the commit 64980eb to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 54.32% +0.32%
+ Complexity 4386 4221 -165
============================================
Files 1903 1068 -835
Lines 41371 27339 -14032
Branches 4632 2715 -1917
============================================
- Hits 22340 14852 -7488
+ Misses 17889 11178 -6711
- Partials 1142 1309 +167
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| ... and [1342 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...64980eb](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `32.78%`.
> The diff coverage is `2.32%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 21.21% -32.79%
+ Complexity 4386 1704 -2682
=============================================
Files 1903 1036 -867
Lines 41371 25775 -15596
Branches 4632 2517 -2115
=============================================
- Hits 22340 5469 -16871
- Misses 17889 19896 +2007
+ Partials 1142 410 -732
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1583 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `4.31%`.
> The diff coverage is `51.85%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head f04a0e5. Consider uploading reports for the commit f04a0e5 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 57.99% +4.31%
- Complexity 4334 4374 +40
============================================
Files 1903 1050 -853
Lines 41395 26956 -14439
Branches 4635 2661 -1974
============================================
- Hits 22219 15633 -6586
+ Misses 18035 9939 -8096
- Partials 1141 1384 +243
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7d428ec...f04a0e5](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `20.50%`.
> The diff coverage is `3.94%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 33.48% -20.51%
+ Complexity 4386 2671 -1715
=============================================
Files 1903 1077 -826
Lines 41371 27358 -14013
Branches 4632 2711 -1921
=============================================
- Hits 22340 9162 -13178
+ Misses 17889 17471 -418
+ Partials 1142 725 -417
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| ... and [1471 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `16.56%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.67% 37.11% -16.57%
+ Complexity 4334 2831 -1503
=============================================
Files 1903 1048 -855
Lines 41395 26766 -14629
Branches 4635 2636 -1999
=============================================
- Hits 22219 9933 -12286
+ Misses 18035 16046 -1989
+ Partials 1141 787 -354
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1486 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `1.70%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 55.38% +1.70%
+ Complexity 4334 4200 -134
============================================
Files 1903 1050 -853
Lines 41395 26928 -14467
Branches 4635 2656 -1979
============================================
- Hits 22219 14913 -7306
+ Misses 18035 10692 -7343
- Partials 1141 1323 +182
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `47.61% <33.33%> (-9.53%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1361 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (071ce4e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `1.52%`.
> The diff coverage is `24.65%`.
> :exclamation: Current head 071ce4e differs from pull request most recent head 64980eb. Consider uploading reports for the commit 64980eb to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 55.52% +1.52%
+ Complexity 4386 4277 -109
============================================
Files 1903 1069 -834
Lines 41371 27343 -14028
Branches 4632 2715 -1917
============================================
- Hits 22340 15182 -7158
+ Misses 17889 10822 -7067
- Partials 1142 1339 +197
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| ... and [1345 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...64980eb](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (071ce4e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.55%`.
> The diff coverage is `24.65%`.
> :exclamation: Current head 071ce4e differs from pull request most recent head 64980eb. Consider uploading reports for the commit 64980eb to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.55% +2.55%
+ Complexity 4386 4350 -36
============================================
Files 1903 1073 -830
Lines 41371 27428 -13943
Branches 4632 2720 -1912
============================================
- Hits 22340 15513 -6827
+ Misses 17889 10553 -7336
- Partials 1142 1362 +220
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| ... and [1341 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...64980eb](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f417a77) into [master](https://codecov.io/gh/apache/skywalking/commit/db2bc935737ee24ad79b6f237b0eaa60991434ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db2bc93) will **decrease** coverage by `54.14%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 54.14% 0.00% -54.15%
============================================
Files 1903 212 -1691
Lines 41371 5156 -36215
Branches 4632 604 -4028
============================================
- Hits 22401 0 -22401
+ Misses 17827 5156 -12671
+ Partials 1143 0 -1143
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1876 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...f417a77](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06e391f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `10.32%`.
> The diff coverage is `2.32%`.
> :exclamation: Current head 06e391f differs from pull request most recent head 8b9dab0. Consider uploading reports for the commit 8b9dab0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 43.67% -10.33%
+ Complexity 4386 3260 -1126
=============================================
Files 1903 1044 -859
Lines 41371 26743 -14628
Branches 4632 2635 -1997
=============================================
- Hits 22340 11680 -10660
+ Misses 17889 14123 -3766
+ Partials 1142 940 -202
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1430 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (071ce4e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.47%`.
> The diff coverage is `24.65%`.
> :exclamation: Current head 071ce4e differs from pull request most recent head 64980eb. Consider uploading reports for the commit 64980eb to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.47% +2.47%
+ Complexity 4386 4350 -36
============================================
Files 1903 1075 -828
Lines 41371 27470 -13901
Branches 4632 2724 -1908
============================================
- Hits 22340 15513 -6827
+ Misses 17889 10595 -7294
- Partials 1142 1362 +220
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| ... and [1339 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...64980eb](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (071ce4e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.80%`.
> The diff coverage is `30.13%`.
> :exclamation: Current head 071ce4e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.80% +2.80%
+ Complexity 4386 4373 -13
============================================
Files 1903 1077 -826
Lines 41371 27529 -13842
Branches 4632 2731 -1901
============================================
- Hits 22340 15637 -6703
+ Misses 17889 10499 -7390
- Partials 1142 1393 +251
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `78.26% <81.81%> (-2.70%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| ... and [1335 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5eaf3af) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `53.67%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.67% 0.00% -53.68%
============================================
Files 1903 193 -1710
Lines 41395 4836 -36559
Branches 4635 556 -4079
============================================
- Hits 22219 0 -22219
+ Misses 18035 4836 -13199
+ Partials 1141 0 -1141
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1872 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06e391f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `14.26%`.
> The diff coverage is `2.32%`.
> :exclamation: Current head 06e391f differs from pull request most recent head 8b9dab0. Consider uploading reports for the commit 8b9dab0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 39.73% -14.27%
+ Complexity 4386 3041 -1345
=============================================
Files 1903 1044 -859
Lines 41371 26730 -14641
Branches 4632 2634 -1998
=============================================
- Hits 22340 10620 -11720
+ Misses 17889 15253 -2636
+ Partials 1142 857 -285
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1452 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06e391f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `8.58%`.
> The diff coverage is `32.55%`.
> :exclamation: Current head 06e391f differs from pull request most recent head 8b9dab0. Consider uploading reports for the commit 8b9dab0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 45.41% -8.59%
+ Complexity 4386 3347 -1039
============================================
Files 1903 1044 -859
Lines 41371 26773 -14598
Branches 4632 2645 -1987
============================================
- Hits 22340 12158 -10182
+ Misses 17889 13620 -4269
+ Partials 1142 995 -147
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `53.96% <100.00%> (-3.18%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1426 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.02%`.
> The diff coverage is `41.86%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.02% +2.02%
+ Complexity 4386 4341 -45
============================================
Files 1903 1077 -826
Lines 41371 27506 -13865
Branches 4632 2728 -1904
============================================
- Hits 22340 15411 -6929
+ Misses 17889 10754 -7135
- Partials 1142 1341 +199
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1352 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (071ce4e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `25.53%`.
> The diff coverage is `1.36%`.
> :exclamation: Current head 071ce4e differs from pull request most recent head 64980eb. Consider uploading reports for the commit 64980eb to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 28.46% -25.54%
+ Complexity 4386 2199 -2187
=============================================
Files 1903 1033 -870
Lines 41371 26003 -15368
Branches 4632 2566 -2066
=============================================
- Hits 22340 7402 -14938
- Misses 17889 18049 +160
+ Partials 1142 552 -590
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| ... and [1515 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...64980eb](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 187 -1716
Lines 41371 4651 -36720
Branches 4632 534 -4098
============================================
- Hits 22340 0 -22340
+ Misses 17889 4651 -13238
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1849 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b9dab0) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 179 -1724
Lines 41371 4542 -36829
Branches 4632 523 -4109
============================================
- Hits 22340 0 -22340
+ Misses 17889 4542 -13347
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1875 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `3.03%`.
> The diff coverage is `10.52%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 50.96% -3.04%
+ Complexity 4386 4056 -330
============================================
Files 1903 1077 -826
Lines 41371 27492 -13879
Branches 4632 2720 -1912
============================================
- Hits 22340 14011 -8329
+ Misses 17889 12243 -5646
- Partials 1142 1238 +96
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| ... and [1364 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `53.67%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.67% 0.00% -53.68%
============================================
Files 1903 188 -1715
Lines 41395 4608 -36787
Branches 4635 527 -4108
============================================
- Hits 22219 0 -22219
+ Misses 18035 4608 -13427
+ Partials 1141 0 -1141
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1872 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e04af6f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 184 -1719
Lines 41371 4604 -36767
Branches 4632 530 -4102
============================================
- Hits 22340 0 -22340
+ Misses 17889 4604 -13285
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1854 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...e04af6f](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f417a77) into [master](https://codecov.io/gh/apache/skywalking/commit/db2bc935737ee24ad79b6f237b0eaa60991434ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db2bc93) will **decrease** coverage by `19.92%`.
> The diff coverage is `2.27%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 54.14% 34.21% -19.93%
+ Complexity 4407 2634 -1773
=============================================
Files 1903 1045 -858
Lines 41371 26469 -14902
Branches 4632 2627 -2005
=============================================
- Hits 22401 9057 -13344
+ Misses 17827 16707 -1120
+ Partials 1143 705 -438
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1501 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...f417a77](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `12.87%`.
> The diff coverage is `2.32%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 41.12% -12.88%
+ Complexity 4386 3121 -1265
=============================================
Files 1903 1072 -831
Lines 41371 27226 -14145
Branches 4632 2697 -1935
=============================================
- Hits 22340 11197 -11143
+ Misses 17889 15096 -2793
+ Partials 1142 933 -209
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1456 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#discussion_r697989187
##########
File path: docs/menu.yml
##########
@@ -91,6 +91,8 @@ catalog:
path: "/en/setup/backend/ttl"
- name: "Dynamical Logging"
path: "/en/setup/backend/dynamical-logging"
+ - name: "gRPC SSL transportation support for OAP serve"
+ path: "/en/setup/backend/grpc-ssl"
Review comment:
```suggestion
- name: "Security(SSL/TLS/mTLS)"
path: "/en/setup/backend/grpc-security"
```
Please rename `grpc-ssl.md` to `grpc-security.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `10.98%`.
> The diff coverage is `2.32%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 43.01% -10.99%
+ Complexity 4386 3237 -1149
=============================================
Files 1903 1073 -830
Lines 41371 27240 -14131
Branches 4632 2698 -1934
=============================================
- Hits 22340 11718 -10622
+ Misses 17889 14552 -3337
+ Partials 1142 970 -172
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1445 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `0.60%`.
> The diff coverage is `11.62%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 53.39% -0.61%
+ Complexity 4386 4128 -258
============================================
Files 1903 1073 -830
Lines 41371 27252 -14119
Branches 4632 2698 -1934
============================================
- Hits 22340 14552 -7788
+ Misses 17889 11414 -6475
- Partials 1142 1286 +144
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1379 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (071ce4e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `1.85%`.
> The diff coverage is `24.65%`.
> :exclamation: Current head 071ce4e differs from pull request most recent head 64980eb. Consider uploading reports for the commit 64980eb to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 55.85% +1.85%
+ Complexity 4386 4300 -86
============================================
Files 1903 1073 -830
Lines 41371 27428 -13943
Branches 4632 2720 -1912
============================================
- Hits 22340 15321 -7019
+ Misses 17889 10756 -7133
- Partials 1142 1351 +209
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| ... and [1345 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...64980eb](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b9dab0) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 214 -1689
Lines 41371 5205 -36166
Branches 4632 603 -4029
============================================
- Hits 22340 0 -22340
+ Misses 17889 5205 -12684
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1876 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `1.94%`.
> The diff coverage is `41.86%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 52.04% -1.95%
+ Complexity 4386 4136 -250
============================================
Files 1903 1077 -826
Lines 41371 27489 -13882
Branches 4632 2727 -1905
============================================
- Hits 22340 14308 -8032
+ Misses 17889 11933 -5956
- Partials 1142 1248 +106
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1368 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `53.67%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.67% 0.00% -53.68%
============================================
Files 1903 183 -1720
Lines 41395 4565 -36830
Branches 4635 525 -4110
============================================
- Hits 22219 0 -22219
+ Misses 18035 4565 -13470
+ Partials 1141 0 -1141
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1872 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] dmsolr commented on a change in pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#discussion_r699789263
##########
File path: docs/en/setup/backend/grpc-security.md
##########
@@ -44,3 +44,28 @@ gRPCSslCertChainPath: /path/to/server.crt
Since `sharding-server` only receives data from an external source, it doesn't need a CA at all.
If you port to Java agent, refer to [the Java agent repo](http://github.com/apache/skywalking-java) to config java agent and enable TLS.
+
+## mutual TLS mode
+
+To enable `mTLS` mode for gRPC channel requires [Sharing gRPC Server](./backend-receivers.md/#grpchttp-server-for-receiver) enabled, as following configuration.
+
+```properties
+receiver-sharing-server:
+ selector: ${SW_RECEIVER_SHARING_SERVER:default}
+ default:
+ # For gRPC server
+ gRPCHost: ${SW_RECEIVER_GRPC_HOST:0.0.0.0}
+ gRPCPort: ${SW_RECEIVER_GRPC_PORT:11801}
+ maxConcurrentCallsPerConnection: ${SW_RECEIVER_GRPC_MAX_CONCURRENT_CALL:0}
+ maxMessageSize: ${SW_RECEIVER_GRPC_MAX_MESSAGE_SIZE:0}
+ gRPCThreadPoolQueueSize: ${SW_RECEIVER_GRPC_POOL_QUEUE_SIZE:0}
+ gRPCThreadPoolSize: ${SW_RECEIVER_GRPC_THREAD_POOL_SIZE:0}
+ gRPCSslEnabled: ${SW_RECEIVER_GRPC_SSL_ENABLED:true}
+ gRPCSslKeyPath: ${SW_RECEIVER_GRPC_SSL_KEY_PATH:"/path/to/server.pem"}
+ gRPCSslCertChainPath: ${SW_RECEIVER_GRPC_SSL_CERT_CHAIN_PATH:"/path/to/server.crt"}
+ gRPCSslTrustedCAsPath: ${SW_RECEIVER_GRPC_SSL_TRUSTED_CAS_PATH:"/path/to/ca.crt"}
+ authentication: ${SW_AUTHENTICATION:""}
+```
Review comment:
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.89%`.
> The diff coverage is `32.89%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.89% +2.89%
+ Complexity 4386 4380 -6
============================================
Files 1903 1077 -826
Lines 41371 27532 -13839
Branches 4632 2731 -1901
============================================
- Hits 22340 15665 -6675
+ Misses 17889 10478 -7411
- Partials 1142 1389 +247
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `78.26% <81.81%> (-2.70%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| ... and [1330 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `14.06%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.67% 39.60% -14.07%
+ Complexity 4334 2957 -1377
=============================================
Files 1903 1048 -855
Lines 41395 26773 -14622
Branches 4635 2636 -1999
=============================================
- Hits 22219 10604 -11615
+ Misses 18035 15342 -2693
+ Partials 1141 827 -314
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `47.61% <33.33%> (-9.53%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1475 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f417a77) into [master](https://codecov.io/gh/apache/skywalking/commit/db2bc935737ee24ad79b6f237b0eaa60991434ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db2bc93) will **decrease** coverage by `54.14%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 54.14% 0.00% -54.15%
============================================
Files 1903 208 -1695
Lines 41371 5049 -36322
Branches 4632 589 -4043
============================================
- Hits 22401 0 -22401
+ Misses 17827 5049 -12778
+ Partials 1143 0 -1143
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1877 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...f417a77](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `0.24%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 53.92% +0.24%
+ Complexity 4334 4063 -271
============================================
Files 1903 1050 -853
Lines 41395 26910 -14485
Branches 4635 2655 -1980
============================================
- Hits 22219 14510 -7709
+ Misses 18035 11128 -6907
- Partials 1141 1272 +131
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `47.61% <33.33%> (-9.53%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1386 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f417a77) into [master](https://codecov.io/gh/apache/skywalking/commit/db2bc935737ee24ad79b6f237b0eaa60991434ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db2bc93) will **decrease** coverage by `54.14%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 54.14% 0.00% -54.15%
============================================
Files 1903 206 -1697
Lines 41371 5043 -36328
Branches 4632 589 -4043
============================================
- Hits 22401 0 -22401
+ Misses 17827 5043 -12784
+ Partials 1143 0 -1143
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1877 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...f417a77](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `3.84%`.
> The diff coverage is `9.21%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 50.15% -3.85%
+ Complexity 4386 4015 -371
============================================
Files 1903 1077 -826
Lines 41371 27489 -13882
Branches 4632 2720 -1912
============================================
- Hits 22340 13787 -8553
+ Misses 17889 12482 -5407
- Partials 1142 1220 +78
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...in/elasticsearch7/query/BrowserLogQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Ccm93c2VyTG9nUXVlcnlFczdEQU8uamF2YQ==) | `6.25% <0.00%> (-55.05%)` | :arrow_down: |
| ... and [1370 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5eaf3af) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `53.67%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.67% 0.00% -53.68%
============================================
Files 1903 176 -1727
Lines 41395 4479 -36916
Branches 4635 520 -4115
============================================
- Hits 22219 0 -22219
+ Misses 18035 4479 -13556
+ Partials 1141 0 -1141
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1872 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (071ce4e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.83%`.
> The diff coverage is `30.13%`.
> :exclamation: Current head 071ce4e differs from pull request most recent head 64980eb. Consider uploading reports for the commit 64980eb to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.83% +2.83%
+ Complexity 4386 4367 -19
============================================
Files 1903 1075 -828
Lines 41371 27470 -13901
Branches 4632 2724 -1908
============================================
- Hits 22340 15613 -6727
+ Misses 17889 10465 -7424
- Partials 1142 1392 +250
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `78.26% <81.81%> (-2.70%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| ... and [1335 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...64980eb](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `29.24%`.
> The diff coverage is `4.00%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 24.75% -29.25%
+ Complexity 4386 1956 -2430
=============================================
Files 1903 1045 -858
Lines 41371 26021 -15350
Branches 4632 2539 -2093
=============================================
- Hits 22340 6441 -15899
- Misses 17889 19124 +1235
+ Partials 1142 456 -686
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| ... and [1558 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (071ce4e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.80%`.
> The diff coverage is `30.13%`.
> :exclamation: Current head 071ce4e differs from pull request most recent head 64980eb. Consider uploading reports for the commit 64980eb to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.80% +2.80%
+ Complexity 4386 4362 -24
============================================
Files 1903 1075 -828
Lines 41371 27470 -13901
Branches 4632 2724 -1908
============================================
- Hits 22340 15605 -6735
+ Misses 17889 10473 -7416
- Partials 1142 1392 +250
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `78.26% <81.81%> (-2.70%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| ... and [1339 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...64980eb](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (071ce4e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `1.93%`.
> The diff coverage is `24.65%`.
> :exclamation: Current head 071ce4e differs from pull request most recent head 64980eb. Consider uploading reports for the commit 64980eb to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 55.93% +1.93%
+ Complexity 4386 4300 -86
============================================
Files 1903 1072 -831
Lines 41371 27389 -13982
Branches 4632 2719 -1913
============================================
- Hits 22340 15321 -7019
+ Misses 17889 10717 -7172
- Partials 1142 1351 +209
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| ... and [1344 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...64980eb](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `6.41%`.
> The diff coverage is `11.62%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 47.58% -6.42%
+ Complexity 4386 3831 -555
============================================
Files 1903 1076 -827
Lines 41371 27334 -14037
Branches 4632 2707 -1925
============================================
- Hits 22340 13006 -9334
+ Misses 17889 13197 -4692
+ Partials 1142 1131 -11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1399 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#discussion_r697989187
##########
File path: docs/menu.yml
##########
@@ -91,6 +91,8 @@ catalog:
path: "/en/setup/backend/ttl"
- name: "Dynamical Logging"
path: "/en/setup/backend/dynamical-logging"
+ - name: "gRPC SSL transportation support for OAP serve"
+ path: "/en/setup/backend/grpc-ssl"
Review comment:
```suggestion
- name: "Security(SSL/TLS/mTLS)"
path: "/en/setup/backend/grpc-security"
```
Please rename `grpc-ssl` to `grpc-security`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#discussion_r698014693
##########
File path: docs/menu.yml
##########
@@ -91,6 +91,8 @@ catalog:
path: "/en/setup/backend/ttl"
- name: "Dynamical Logging"
path: "/en/setup/backend/dynamical-logging"
+ - name: "gRPC SSL transportation support for OAP serve"
+ path: "/en/setup/backend/grpc-ssl"
Review comment:
> Please rename grpc-ssl.md to grpc-security.md.
@dmsolr I think you miss this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sonatype-lift[bot] commented on a change in pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on a change in pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#discussion_r695680948
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/TLSChannelBuilder.java
##########
@@ -23,26 +23,55 @@
import io.grpc.netty.NettyChannelBuilder;
import io.netty.handler.ssl.SslContextBuilder;
import java.io.File;
-import javax.net.ssl.SSLException;
+import java.io.FileInputStream;
+import java.io.IOException;
import org.apache.skywalking.apm.agent.core.boot.AgentPackageNotFoundException;
import org.apache.skywalking.apm.agent.core.boot.AgentPackagePath;
import org.apache.skywalking.apm.agent.core.conf.Config;
-import org.apache.skywalking.apm.agent.core.conf.Constants;
+import org.apache.skywalking.apm.agent.core.logging.api.ILog;
+import org.apache.skywalking.apm.agent.core.logging.api.LogManager;
+import org.apache.skywalking.apm.agent.core.util.PrivateKeyUtil;
+import org.apache.skywalking.apm.util.StringUtil;
/**
- * Detect the `/ca` folder in agent package, if `ca.crt` exists, start TLS (no mutual auth).
+ * If only ca.crt exists, start TLS. If cert, key and ca files exist, enable mTLS.
*/
public class TLSChannelBuilder implements ChannelBuilder<NettyChannelBuilder> {
- private static String CA_FILE_NAME = "ca" + Constants.PATH_SEPARATOR + "ca.crt";
+ private static final ILog LOGGER = LogManager.getLogger(TLSChannelBuilder.class);
@Override
public NettyChannelBuilder build(
- NettyChannelBuilder managedChannelBuilder) throws AgentPackageNotFoundException, SSLException {
- File caFile = new File(AgentPackagePath.getPath(), CA_FILE_NAME);
- boolean isCAFileExist = caFile.exists() && caFile.isFile();
- if (Config.Agent.FORCE_TLS || isCAFileExist) {
+ NettyChannelBuilder managedChannelBuilder) throws AgentPackageNotFoundException, IOException {
+
+ String caPath = Config.Agent.SSL_TRUSTED_CA_PATH;
+ if (caPath.startsWith("./")) {
+ caPath = AgentPackagePath.getPath() + caPath.substring(2);
+ }
+ File caFile = new File(caPath);
Review comment:
*PATH_TRAVERSAL_IN:* This API (java/io/File.<init>(Ljava/lang/String;)V) reads a file whose location might be specified by user input [(details)](https://find-sec-bugs.github.io/bugs.htm#PATH_TRAVERSAL_IN)
(at-me [in a reply](https://help.sonatype.com/lift) with `help` or `ignore`)
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/util/PrivateKeyUtil.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.skywalking.apm.agent.core.util;
+
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+import java.util.Base64;
+
+/**
+ * Util intends to parse PKCS#1 and PKCS#8 at same time.
+ */
+public class PrivateKeyUtil {
+ private static final String PKCS_1_PEM_HEADER = "-----BEGIN RSA PRIVATE KEY-----";
+ private static final String PKCS_1_PEM_FOOTER = "-----END RSA PRIVATE KEY-----";
+ private static final String PKCS_8_PEM_HEADER = "-----BEGIN PRIVATE KEY-----";
+ private static final String PKCS_8_PEM_FOOTER = "-----END PRIVATE KEY-----";
+
+ /**
+ * Load a RSA decryption key from a file (PEM or DER).
+ */
+ public static InputStream loadDecryptionKey(String keyFilePath) throws IOException {
+ byte[] keyDataBytes = Files.readAllBytes(Paths.get(keyFilePath));
Review comment:
*PATH_TRAVERSAL_IN:* This API (java/nio/file/Paths.get(Ljava/lang/String;[Ljava/lang/String;)Ljava/nio/file/Path;) reads a file whose location might be specified by user input [(details)](https://find-sec-bugs.github.io/bugs.htm#PATH_TRAVERSAL_IN)
(at-me [in a reply](https://help.sonatype.com/lift) with `help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `12.76%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.67% 40.91% -12.77%
+ Complexity 4334 3035 -1299
=============================================
Files 1903 1048 -855
Lines 41395 26773 -14622
Branches 4635 2636 -1999
=============================================
- Hits 22219 10953 -11266
+ Misses 18035 14948 -3087
+ Partials 1141 872 -269
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `47.61% <33.33%> (-9.53%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1471 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (071ce4e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `14.43%`.
> The diff coverage is `1.36%`.
> :exclamation: Current head 071ce4e differs from pull request most recent head 64980eb. Consider uploading reports for the commit 64980eb to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 39.56% -14.44%
+ Complexity 4386 3070 -1316
=============================================
Files 1903 1066 -837
Lines 41371 27252 -14119
Branches 4632 2709 -1923
=============================================
- Hits 22340 10783 -11557
+ Misses 17889 15582 -2307
+ Partials 1142 887 -255
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| ... and [1436 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...64980eb](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `1.65%`.
> The diff coverage is `11.62%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 55.65% +1.65%
+ Complexity 4386 4299 -87
============================================
Files 1903 1073 -830
Lines 41371 27338 -14033
Branches 4632 2706 -1926
============================================
- Hits 22340 15215 -7125
+ Misses 17889 10803 -7086
- Partials 1142 1320 +178
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1351 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (071ce4e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.80%`.
> The diff coverage is `30.13%`.
> :exclamation: Current head 071ce4e differs from pull request most recent head 64980eb. Consider uploading reports for the commit 64980eb to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.80% +2.80%
+ Complexity 4386 4373 -13
============================================
Files 1903 1077 -826
Lines 41371 27529 -13842
Branches 4632 2731 -1901
============================================
- Hits 22340 15637 -6703
+ Misses 17889 10499 -7390
- Partials 1142 1393 +251
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `78.26% <81.81%> (-2.70%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| ... and [1335 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...64980eb](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `15.50%`.
> The diff coverage is `2.32%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 38.48% -15.51%
+ Complexity 4386 2917 -1469
=============================================
Files 1903 1072 -831
Lines 41371 27080 -14291
Branches 4632 2666 -1966
=============================================
- Hits 22340 10423 -11917
+ Misses 17889 15827 -2062
+ Partials 1142 830 -312
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1471 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `19.01%`.
> The diff coverage is `2.32%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 34.98% -19.02%
+ Complexity 4386 2781 -1605
=============================================
Files 1903 1074 -829
Lines 41371 27255 -14116
Branches 4632 2700 -1932
=============================================
- Hits 22340 9536 -12804
+ Misses 17889 16967 -922
+ Partials 1142 752 -390
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1478 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.02%`.
> The diff coverage is `41.86%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.02% +2.02%
+ Complexity 4386 4339 -47
============================================
Files 1903 1077 -826
Lines 41371 27506 -13865
Branches 4632 2728 -1904
============================================
- Hits 22340 15409 -6931
+ Misses 17889 10754 -7135
- Partials 1142 1343 +201
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1352 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `31.65%`.
> The diff coverage is `2.32%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 22.34% -31.66%
+ Complexity 4386 1853 -2533
=============================================
Files 1903 1072 -831
Lines 41371 26848 -14523
Branches 4632 2625 -2007
=============================================
- Hits 22340 5999 -16341
- Misses 17889 20424 +2535
+ Partials 1142 425 -717
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1561 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.54%`.
> The diff coverage is `11.62%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.54% +2.54%
+ Complexity 4386 4340 -46
============================================
Files 1903 1073 -830
Lines 41371 27340 -14031
Branches 4632 2711 -1921
============================================
- Hits 22340 15459 -6881
+ Misses 17889 10529 -7360
- Partials 1142 1352 +210
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1344 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 210 -1693
Lines 41371 5067 -36304
Branches 4632 591 -4041
============================================
- Hits 22340 0 -22340
+ Misses 17889 5067 -12822
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1875 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `4.31%`.
> The diff coverage is `51.85%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head d45f1ba. Consider uploading reports for the commit d45f1ba to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 57.99% +4.31%
- Complexity 4334 4374 +40
============================================
Files 1903 1050 -853
Lines 41395 26956 -14439
Branches 4635 2661 -1974
============================================
- Hits 22219 15633 -6586
+ Misses 18035 9939 -8096
- Partials 1141 1384 +243
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a3317a8...d45f1ba](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `4.76%`.
> The diff coverage is `11.62%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 49.23% -4.77%
+ Complexity 4386 3953 -433
============================================
Files 1903 1077 -826
Lines 41371 27365 -14006
Branches 4632 2713 -1919
============================================
- Hits 22340 13472 -8868
+ Misses 17889 12710 -5179
- Partials 1142 1183 +41
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1387 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06e391f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.99%`.
> The diff coverage is `41.86%`.
> :exclamation: Current head 06e391f differs from pull request most recent head 8b9dab0. Consider uploading reports for the commit 8b9dab0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.98% +2.99%
+ Complexity 4386 4301 -85
============================================
Files 1903 1044 -859
Lines 41371 26782 -14589
Branches 4632 2645 -1987
============================================
- Hits 22340 15263 -7077
+ Misses 17889 10183 -7706
- Partials 1142 1336 +194
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `53.96% <100.00%> (-3.18%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1361 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `5.35%`.
> The diff coverage is `11.62%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 48.63% -5.36%
+ Complexity 4386 3916 -470
============================================
Files 1903 1077 -826
Lines 41371 27340 -14031
Branches 4632 2712 -1920
============================================
- Hits 22340 13298 -9042
+ Misses 17889 12891 -4998
- Partials 1142 1151 +9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1390 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#discussion_r701210579
##########
File path: oap-server/server-bootstrap/src/main/java/org/apache/skywalking/oap/server/starter/OAPServerBootstrap.java
##########
@@ -58,4 +58,8 @@ public static void start() {
System.exit(1);
}
}
+
+ public static void main(String[] args) {
+ OAPServerBootstrap.start();
+ }
Review comment:
Why add this?
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `1.83%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 55.50% +1.83%
+ Complexity 4334 4206 -128
============================================
Files 1903 1050 -853
Lines 41395 26928 -14467
Branches 4635 2656 -1979
============================================
- Hits 22219 14947 -7272
+ Misses 18035 10653 -7382
- Partials 1141 1328 +187
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `47.61% <33.33%> (-9.53%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1360 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `14.62%`.
> The diff coverage is `3.94%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 39.37% -14.63%
+ Complexity 4386 3078 -1308
=============================================
Files 1903 1077 -826
Lines 41371 27480 -13891
Branches 4632 2720 -1912
=============================================
- Hits 22340 10819 -11521
+ Misses 17889 15785 -2104
+ Partials 1142 876 -266
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| ... and [1435 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5fc2701) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `21.88%`.
> The diff coverage is `4.34%`.
> :exclamation: Current head 5fc2701 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 32.11% -21.89%
+ Complexity 4386 2035 -2351
=============================================
Files 1903 846 -1057
Lines 41371 21379 -19992
Branches 4632 2030 -2602
=============================================
- Hits 22340 6865 -15475
+ Misses 17889 14020 -3869
+ Partials 1142 494 -648
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ache/skywalking/oap/meter/analyzer/dsl/Sample.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ing/oap/server/core/storage/IHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9JSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1554 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `19.48%`.
> The diff coverage is `2.32%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 34.50% -19.49%
+ Complexity 4386 2697 -1689
=============================================
Files 1903 1070 -833
Lines 41371 27033 -14338
Branches 4632 2665 -1967
=============================================
- Hits 22340 9329 -13011
+ Misses 17889 16969 -920
+ Partials 1142 735 -407
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1489 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.62%`.
> The diff coverage is `32.89%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.62% +2.62%
+ Complexity 4386 4360 -26
============================================
Files 1903 1077 -826
Lines 41371 27532 -13839
Branches 4632 2731 -1901
============================================
- Hits 22340 15590 -6750
+ Misses 17889 10556 -7333
- Partials 1142 1386 +244
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `78.26% <81.81%> (-2.70%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| ... and [1334 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06e391f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `3.31%`.
> The diff coverage is `41.86%`.
> :exclamation: Current head 06e391f differs from pull request most recent head 8b9dab0. Consider uploading reports for the commit 8b9dab0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 57.30% +3.31%
+ Complexity 4386 4322 -64
============================================
Files 1903 1048 -855
Lines 41371 26847 -14524
Branches 4632 2653 -1979
============================================
- Hits 22340 15386 -6954
+ Misses 17889 10105 -7784
- Partials 1142 1356 +214
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1358 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `1.09%`.
> The diff coverage is `11.62%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 55.09% +1.09%
+ Complexity 4386 4255 -131
============================================
Files 1903 1073 -830
Lines 41371 27338 -14033
Branches 4632 2706 -1926
============================================
- Hits 22340 15063 -7277
+ Misses 17889 10948 -6941
- Partials 1142 1327 +185
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1360 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06e391f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `3.20%`.
> The diff coverage is `41.86%`.
> :exclamation: Current head 06e391f differs from pull request most recent head 8b9dab0. Consider uploading reports for the commit 8b9dab0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 57.20% +3.20%
+ Complexity 4386 4318 -68
============================================
Files 1903 1048 -855
Lines 41371 26847 -14524
Branches 4632 2653 -1979
============================================
- Hits 22340 15358 -6982
+ Misses 17889 10138 -7751
- Partials 1142 1351 +209
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1359 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `11.19%`.
> The diff coverage is `2.32%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 42.80% -11.20%
+ Complexity 4386 3221 -1165
=============================================
Files 1903 1072 -831
Lines 41371 27236 -14135
Branches 4632 2698 -1934
=============================================
- Hits 22340 11658 -10682
+ Misses 17889 14617 -3272
+ Partials 1142 961 -181
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1446 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `0.00%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.67% 53.67% -0.01%
+ Complexity 4334 4054 -280
============================================
Files 1903 1050 -853
Lines 41395 26910 -14485
Branches 4635 2655 -1980
============================================
- Hits 22219 14444 -7775
+ Misses 18035 11208 -6827
- Partials 1141 1258 +117
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `47.61% <33.33%> (-9.53%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1385 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 186 -1717
Lines 41371 4646 -36725
Branches 4632 534 -4098
============================================
- Hits 22340 0 -22340
+ Misses 17889 4646 -13243
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1849 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `0.44%`.
> The diff coverage is `41.86%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 54.44% +0.44%
+ Complexity 4386 4248 -138
============================================
Files 1903 1077 -826
Lines 41371 27506 -13865
Branches 4632 2728 -1904
============================================
- Hits 22340 14975 -7365
+ Misses 17889 11230 -6659
- Partials 1142 1301 +159
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1362 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `6.93%`.
> The diff coverage is `11.62%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 47.06% -6.94%
+ Complexity 4386 3799 -587
============================================
Files 1903 1074 -829
Lines 41371 27320 -14051
Branches 4632 2707 -1925
============================================
- Hits 22340 12859 -9481
+ Misses 17889 13336 -4553
+ Partials 1142 1125 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1404 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `1.02%`.
> The diff coverage is `41.86%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 55.02% +1.02%
+ Complexity 4386 4284 -102
============================================
Files 1903 1077 -826
Lines 41371 27506 -13865
Branches 4632 2728 -1904
============================================
- Hits 22340 15136 -7204
+ Misses 17889 11045 -6844
- Partials 1142 1325 +183
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1358 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `0.17%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 53.84% +0.17%
+ Complexity 4334 4060 -274
============================================
Files 1903 1050 -853
Lines 41395 26910 -14485
Branches 4635 2655 -1980
============================================
- Hits 22219 14490 -7729
+ Misses 18035 11150 -6885
- Partials 1141 1270 +129
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `47.61% <33.33%> (-9.53%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1386 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f417a77) into [master](https://codecov.io/gh/apache/skywalking/commit/db2bc935737ee24ad79b6f237b0eaa60991434ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db2bc93) will **decrease** coverage by `54.14%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 54.14% 0.00% -54.15%
============================================
Files 1903 213 -1690
Lines 41371 5161 -36210
Branches 4632 604 -4028
============================================
- Hits 22401 0 -22401
+ Misses 17827 5161 -12666
+ Partials 1143 0 -1143
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1876 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...f417a77](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng edited a comment on pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-909750671
@dmsolr We are locking the agent images(https://github.com/apache/skywalking/pull/7625) to make the test predictable. After merge and sync, your PR should run with the latest agent codes directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06e391f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.80%`.
> The diff coverage is `41.86%`.
> :exclamation: Current head 06e391f differs from pull request most recent head 8b9dab0. Consider uploading reports for the commit 8b9dab0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.79% +2.80%
+ Complexity 4386 4288 -98
============================================
Files 1903 1044 -859
Lines 41371 26782 -14589
Branches 4632 2645 -1987
============================================
- Hits 22340 15212 -7128
+ Misses 17889 10236 -7653
- Partials 1142 1334 +192
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `53.96% <100.00%> (-3.18%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1362 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `6.94%`.
> The diff coverage is `11.62%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 47.05% -6.95%
+ Complexity 4386 3797 -589
============================================
Files 1903 1074 -829
Lines 41371 27298 -14073
Branches 4632 2704 -1928
============================================
- Hits 22340 12845 -9495
+ Misses 17889 13331 -4558
+ Partials 1142 1122 -20
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1404 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `5.35%`.
> The diff coverage is `11.62%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 48.64% -5.36%
+ Complexity 4386 3916 -470
============================================
Files 1903 1076 -827
Lines 41371 27336 -14035
Branches 4632 2712 -1920
============================================
- Hits 22340 13298 -9042
+ Misses 17889 12887 -5002
- Partials 1142 1151 +9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1390 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.89%`.
> The diff coverage is `32.89%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.89% +2.89%
+ Complexity 4386 4380 -6
============================================
Files 1903 1077 -826
Lines 41371 27532 -13839
Branches 4632 2731 -1901
============================================
- Hits 22340 15665 -6675
+ Misses 17889 10478 -7411
- Partials 1142 1389 +247
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `78.26% <81.81%> (-2.70%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| ... and [1330 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **decrease** coverage by `12.96%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.67% 40.70% -12.97%
+ Complexity 4334 3026 -1308
=============================================
Files 1903 1048 -855
Lines 41395 26773 -14622
Branches 4635 2636 -1999
=============================================
- Hits 22219 10899 -11320
+ Misses 18035 15011 -3024
+ Partials 1141 863 -278
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `47.61% <33.33%> (-9.53%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1471 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (071ce4e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `0.67%`.
> The diff coverage is `24.65%`.
> :exclamation: Current head 071ce4e differs from pull request most recent head 64980eb. Consider uploading reports for the commit 64980eb to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 54.67% +0.67%
+ Complexity 4386 4241 -145
============================================
Files 1903 1068 -835
Lines 41371 27339 -14032
Branches 4632 2715 -1917
============================================
- Hits 22340 14948 -7392
+ Misses 17889 11078 -6811
- Partials 1142 1313 +171
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| ... and [1346 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...64980eb](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `3.48%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 57.15% +3.48%
+ Complexity 4334 4301 -33
============================================
Files 1903 1050 -853
Lines 41395 26928 -14467
Branches 4635 2656 -1979
============================================
- Hits 22219 15391 -6828
+ Misses 18035 10172 -7863
- Partials 1141 1365 +224
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `47.61% <33.33%> (-9.53%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1350 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c00d0e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `1.79%`.
> The diff coverage is `27.63%`.
> :exclamation: Current head 6c00d0e differs from pull request most recent head 192da59. Consider uploading reports for the commit 192da59 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 55.79% +1.79%
+ Complexity 4386 4318 -68
============================================
Files 1903 1077 -826
Lines 41371 27532 -13839
Branches 4632 2731 -1901
============================================
- Hits 22340 15361 -6979
+ Misses 17889 10816 -7073
- Partials 1142 1355 +213
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| ... and [1338 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...192da59](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06e391f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.21%`.
> The diff coverage is `41.86%`.
> :exclamation: Current head 06e391f differs from pull request most recent head 8b9dab0. Consider uploading reports for the commit 8b9dab0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.20% +2.21%
+ Complexity 4386 4263 -123
============================================
Files 1903 1044 -859
Lines 41371 26782 -14589
Branches 4632 2645 -1987
============================================
- Hits 22340 15054 -7286
+ Misses 17889 10392 -7497
- Partials 1142 1336 +194
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <70.00%> (-11.39%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `53.96% <100.00%> (-3.18%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1365 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `2.71%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 56.38% +2.71%
+ Complexity 4334 4261 -73
============================================
Files 1903 1050 -853
Lines 41395 26928 -14467
Branches 4635 2656 -1979
============================================
- Hits 22219 15184 -7035
+ Misses 18035 10393 -7642
- Partials 1141 1351 +210
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `47.61% <33.33%> (-9.53%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1357 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `3.34%`.
> The diff coverage is `3.70%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 57.01% +3.34%
+ Complexity 4334 4287 -47
============================================
Files 1903 1050 -853
Lines 41395 26928 -14467
Branches 4635 2656 -1979
============================================
- Hits 22219 15354 -6865
+ Misses 18035 10208 -7827
- Partials 1141 1366 +225
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `47.61% <33.33%> (-9.53%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1353 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06e391f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 06e391f differs from pull request most recent head 8b9dab0. Consider uploading reports for the commit 8b9dab0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 184 -1719
Lines 41371 4582 -36789
Branches 4632 528 -4104
============================================
- Hits 22340 0 -22340
+ Misses 17889 4582 -13307
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1875 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (071ce4e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `2.92%`.
> The diff coverage is `30.13%`.
> :exclamation: Current head 071ce4e differs from pull request most recent head 64980eb. Consider uploading reports for the commit 64980eb to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 56.92% +2.92%
+ Complexity 4386 4373 -13
============================================
Files 1903 1075 -828
Lines 41371 27470 -13901
Branches 4632 2724 -1908
============================================
- Hits 22340 15637 -6703
+ Misses 17889 10440 -7449
- Partials 1142 1393 +251
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `19.23% <13.63%> (-17.14%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `78.26% <81.81%> (-2.70%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| ... and [1335 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...64980eb](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **increase** coverage by `0.80%`.
> The diff coverage is `11.62%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.99% 54.80% +0.80%
+ Complexity 4386 4225 -161
============================================
Files 1903 1073 -830
Lines 41371 27338 -14033
Branches 4632 2706 -1926
============================================
- Hits 22340 14983 -7357
+ Misses 17889 11038 -6851
- Partials 1142 1317 +175
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `21.73% <15.78%> (-14.63%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1364 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (997e768) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `11.37%`.
> The diff coverage is `2.32%`.
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 42.62% -11.38%
+ Complexity 4386 3205 -1181
=============================================
Files 1903 1072 -831
Lines 41371 27236 -14135
Branches 4632 2698 -1934
=============================================
- Hits 22340 11610 -10730
+ Misses 17889 14661 -3228
+ Partials 1142 965 -177
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1449 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...997e768](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ebda726) into [master](https://codecov.io/gh/apache/skywalking/commit/db2bc935737ee24ad79b6f237b0eaa60991434ef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db2bc93) will **decrease** coverage by `0.44%`.
> The diff coverage is `13.63%`.
> :exclamation: Current head ebda726 differs from pull request most recent head f417a77. Consider uploading reports for the commit f417a77 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 54.14% 53.69% -0.45%
+ Complexity 4407 4127 -280
============================================
Files 1903 1045 -858
Lines 41371 26803 -14568
Branches 4632 2645 -1987
============================================
- Hits 22401 14393 -8008
+ Misses 17827 11143 -6684
- Partials 1143 1267 +124
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `26.92% <0.00%> (-2.95%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `23.07% <20.00%> (-13.29%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `42.85% <33.33%> (-14.29%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.81% <100.00%> (+0.27%)` | :arrow_up: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1370 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...f417a77](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (071ce4e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `23.57%`.
> The diff coverage is `1.36%`.
> :exclamation: Current head 071ce4e differs from pull request most recent head 64980eb. Consider uploading reports for the commit 64980eb to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
=============================================
- Coverage 53.99% 30.42% -23.58%
+ Complexity 4386 2334 -2052
=============================================
Files 1903 1034 -869
Lines 41371 26031 -15340
Branches 4632 2567 -2065
=============================================
- Hits 22340 7921 -14419
+ Misses 17889 17489 -400
+ Partials 1142 621 -521
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...nfigmap/ConfigmapConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWdtYXBDb25maWd1cmF0aW9uV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | :arrow_down: |
| [...tion/configmap/ConfigurationConfigmapInformer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWs4cy1jb25maWdtYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2NvbmZpZ21hcC9Db25maWd1cmF0aW9uQ29uZmlnbWFwSW5mb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.83% <0.00%> (-2.83%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <ø> (-15.00%)` | :arrow_down: |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| ... and [1506 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...64980eb](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3994315) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 3994315 differs from pull request most recent head 32a8ce9. Consider uploading reports for the commit 32a8ce9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 179 -1724
Lines 41371 4568 -36803
Branches 4632 528 -4104
============================================
- Hits 22340 0 -22340
+ Misses 17889 4568 -13321
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1874 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...32a8ce9](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (071ce4e) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 071ce4e differs from pull request most recent head 64980eb. Consider uploading reports for the commit 64980eb to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 203 -1700
Lines 41371 4988 -36383
Branches 4632 586 -4046
============================================
- Hits 22340 0 -22340
+ Misses 17889 4988 -12901
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1855 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e6447d5...64980eb](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#discussion_r696385780
##########
File path: CHANGES.md
##########
@@ -18,6 +18,7 @@ Release Notes.
* Fix kafka-reporter-plugin shade package conflict
* Add all config items to `agent.conf` file for convenient containerization use cases.
* Advanced Kafka Producer configuration enhancement.
+* Enable mTLS for gRPC channel.
Review comment:
Maybe change `Enable` to `Support`? Because we don't enable it by default
##########
File path: oap-server/server-library/library-server/src/main/java/org/apache/skywalking/oap/server/library/server/grpc/ssl/DynamicSslContext.java
##########
@@ -59,18 +63,25 @@ protected void updateContext(String caFile) {
}
}
- @Override
- protected void updateContext(final String privateKeyFile, final String certChainFile) {
+ protected void updateContext(final String privateKeyFile, final String certChainFile, final String trustedCAsFile) {
try {
- setCtx(GrpcSslContexts
- .configure(SslContextBuilder
- .forServer(
- new FileInputStream(Paths.get(certChainFile).toFile()),
- PrivateKeyUtil.loadDecryptionKey(privateKeyFile)),
- SslProvider.OPENSSL)
- .build());
+ SslContextBuilder builder = GrpcSslContexts.configure(
+ SslContextBuilder.forServer(
+ new FileInputStream(Paths.get(certChainFile).toFile()),
+ PrivateKeyUtil.loadDecryptionKey(privateKeyFile)
+ ),
+ SslProvider.OPENSSL
+ );
+
+ if (StringUtil.isNotEmpty(trustedCAsFile)) {
+ builder.trustManager(new FileInputStream(Paths.get(trustedCAsFile).toFile()))
Review comment:
Same here
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/TLSChannelBuilder.java
##########
@@ -23,31 +23,59 @@
import io.grpc.netty.NettyChannelBuilder;
import io.netty.handler.ssl.SslContextBuilder;
import java.io.File;
-import javax.net.ssl.SSLException;
+import java.io.FileInputStream;
+import java.io.IOException;
import org.apache.skywalking.apm.agent.core.boot.AgentPackageNotFoundException;
import org.apache.skywalking.apm.agent.core.boot.AgentPackagePath;
import org.apache.skywalking.apm.agent.core.conf.Config;
-import org.apache.skywalking.apm.agent.core.conf.Constants;
+import org.apache.skywalking.apm.agent.core.logging.api.ILog;
+import org.apache.skywalking.apm.agent.core.logging.api.LogManager;
+import org.apache.skywalking.apm.agent.core.util.PrivateKeyUtil;
+import org.apache.skywalking.apm.util.StringUtil;
/**
- * Detect the `/ca` folder in agent package, if `ca.crt` exists, start TLS (no mutual auth).
+ * If only ca.crt exists, start TLS. If cert, key and ca files exist, enable mTLS.
*/
public class TLSChannelBuilder implements ChannelBuilder<NettyChannelBuilder> {
- private static String CA_FILE_NAME = "ca" + Constants.PATH_SEPARATOR + "ca.crt";
+ private static final ILog LOGGER = LogManager.getLogger(TLSChannelBuilder.class);
@Override
public NettyChannelBuilder build(
- NettyChannelBuilder managedChannelBuilder) throws AgentPackageNotFoundException, SSLException {
- File caFile = new File(AgentPackagePath.getPath(), CA_FILE_NAME);
- boolean isCAFileExist = caFile.exists() && caFile.isFile();
- if (Config.Agent.FORCE_TLS || isCAFileExist) {
+ NettyChannelBuilder managedChannelBuilder) throws AgentPackageNotFoundException, IOException {
+
+ File caFile = new File(toAbsolutePath(Config.Agent.SSL_TRUSTED_CA_PATH));
+ if (Config.Agent.FORCE_TLS || caFile.isFile()) {
SslContextBuilder builder = GrpcSslContexts.forClient();
- if (isCAFileExist) {
+
+ if (caFile.isFile()) {
+ String certPath = Config.Agent.SSL_CERT_CHAIN_PATH;
+ String keyPath = Config.Agent.SSL_KEY_PATH;
+ if (StringUtil.isNotBlank(certPath) && StringUtil.isNotBlank(keyPath)) {
+ File keyFile = new File(toAbsolutePath(keyPath));
+ File certFile = new File(toAbsolutePath(certPath));
+ if (certFile.isFile() && keyFile.isFile()) {
+ builder.keyManager(new FileInputStream(certFile), PrivateKeyUtil.loadDecryptionKey(keyPath));
Review comment:
Seems `builder.keyManager` doesn't close the passed-in `InputStream`? If so, should close it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06e391f) into [master](https://codecov.io/gh/apache/skywalking/commit/944b47b5156d210c703a24ea60e0a4de23b164a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (944b47b) will **decrease** coverage by `53.99%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 06e391f differs from pull request most recent head 8b9dab0. Consider uploading reports for the commit 8b9dab0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
- Coverage 53.99% 0.00% -54.00%
============================================
Files 1903 180 -1723
Lines 41371 4555 -36816
Branches 4632 528 -4104
============================================
- Hits 22340 0 -22340
+ Misses 17889 4555 -13334
+ Partials 1142 0 -1142
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-81.54%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-36.37%)` | :arrow_down: |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1875 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [944b47b...8b9dab0](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7565: Support mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-909812639
The `mTLS` case passed. The document still needs some polish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7565: Enable mTLS for gRPC channel
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7565:
URL: https://github.com/apache/skywalking/pull/7565#issuecomment-905580879
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7565](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d43ab9) into [master](https://codecov.io/gh/apache/skywalking/commit/50688c18795ee69adb97e896de880a5f1a6d0506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50688c1) will **increase** coverage by `4.30%`.
> The diff coverage is `51.85%`.
> :exclamation: Current head 7d43ab9 differs from pull request most recent head 5eaf3af. Consider uploading reports for the commit 5eaf3af to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7565 +/- ##
============================================
+ Coverage 53.67% 57.97% +4.30%
- Complexity 4334 4372 +38
============================================
Files 1903 1050 -853
Lines 41395 26956 -14439
Branches 4635 2661 -1974
============================================
- Hits 22219 15629 -6590
+ Misses 18035 9943 -8092
- Partials 1141 1384 +243
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/starter/OAPServerBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RhcnRlci9PQVBTZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `60.86% <0.00%> (-5.80%)` | :arrow_down: |
| [...rver/library/server/ssl/HttpDynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9IdHRwRHluYW1pY1NzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `15.00% <ø> (ø)` | |
| [...r/receiver/sharing/server/SharingServerConfig.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlckNvbmZpZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `29.48% <0.00%> (-0.39%)` | :arrow_down: |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `69.56% <63.63%> (-11.39%)` | :arrow_down: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `79.66% <100.00%> (ø)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `58.73% <100.00%> (+1.58%)` | :arrow_up: |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `75.00% <100.00%> (ø)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1344 more](https://codecov.io/gh/apache/skywalking/pull/7565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50688c1...5eaf3af](https://codecov.io/gh/apache/skywalking/pull/7565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org