You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@onami.apache.org by Simone Tripodi <si...@apache.org> on 2013/02/19 21:43:07 UTC
[VOTE] gradiate the Converters extension out from the Sandbox
Hi all,
Converters extension is IMHO ready to be pushed out from the Sandbox,
so I propose to graduate it to propert /trunk
[ ] +1 let's promote it
[ ] ±0 go ahead, but...
[ ] -1 because... (provide a reason)
This vote is open for at least 72h and closes ~ on Feb 22th, at 8:40 GMT
Many thanks in advance, all the best!
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
Re: [VOTE] gradiate the Converters extension out from the Sandbox
Posted by Eric Charles <er...@apache.org>.
+1
Thx for this Simo,
Eric
On 19/02/2013 20:43, Simone Tripodi wrote:
> Hi all,
>
> Converters extension is IMHO ready to be pushed out from the Sandbox,
> so I propose to graduate it to propert /trunk
>
> [ ] +1 let's promote it
> [ ] �0 go ahead, but...
> [ ] -1 because... (provide a reason)
>
> This vote is open for at least 72h and closes ~ on Feb 22th, at 8:40 GMT
>
> Many thanks in advance, all the best!
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
Re: [VOTE] gradiate the Converters extension out from the Sandbox
Posted by Simone Tripodi <si...@apache.org>.
Hi Mikhail!
thanks a lot for having a look at the [converters] codebase!
But lets' clarify that graduate from /sandbox to /trunk means that the
codebase respects the initial quality standards required by Onami,
such as applied license, right package, onami build integration and so
on; it doesn't mean that it is ready to be released :)
Given that, please raise an issue to each problem you noticed - that
will makes absolutely easier to keep track of TODOs - and feel free to
assign to yourself and provide a fix! :)
Many thanks in advance, all the best,
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Thu, Feb 21, 2013 at 1:25 PM, Mikhail Mazursky
<mi...@gmail.com> wrote:
> +1 to graduate but there are lots of minor things to work on:
>
> - No consistent policy for exception handling - for example
> SQLTimestampConverter catches Throwable and rethrows it as
> ProvisionException but CharsetConverter do not catch anything at all.
> Should we catch at all or Guice handles this itself?
> - No need to catch Errors in such places in any case (catch Exception is
> enough IMHO);
> - PropertiesConverter converts String to bytes using ISO-8859-1 and then
> uses Properties.load() which converts that back to chars. Maybe just use
> Properties.load(new StringReader(value))? Someone already handled encoding
> problems and passed String to Guice so why mess with it one more time?
> - DateConverter is mutable - this is a bad idea itself IMHO but also there
> is no clean way to set locale and timezone. Maybe there is room for a
> simple DSL or builder for that module.
>
> Hope that helps =)
>
>
> 2013/2/20 Simone Tripodi <si...@apache.org>
>
>> > +0. Haven't looked at the code.
>>
>> Any help will be really appreciated here, Mikhail, I invite you to
>> participate as much as you can on Onami extensions development :)
>>
>> All the best, keep up the good work!
>> -Simo
>>
Re: [VOTE] gradiate the Converters extension out from the Sandbox
Posted by Mikhail Mazursky <mi...@gmail.com>.
+1 to graduate but there are lots of minor things to work on:
- No consistent policy for exception handling - for example
SQLTimestampConverter catches Throwable and rethrows it as
ProvisionException but CharsetConverter do not catch anything at all.
Should we catch at all or Guice handles this itself?
- No need to catch Errors in such places in any case (catch Exception is
enough IMHO);
- PropertiesConverter converts String to bytes using ISO-8859-1 and then
uses Properties.load() which converts that back to chars. Maybe just use
Properties.load(new StringReader(value))? Someone already handled encoding
problems and passed String to Guice so why mess with it one more time?
- DateConverter is mutable - this is a bad idea itself IMHO but also there
is no clean way to set locale and timezone. Maybe there is room for a
simple DSL or builder for that module.
Hope that helps =)
2013/2/20 Simone Tripodi <si...@apache.org>
> > +0. Haven't looked at the code.
>
> Any help will be really appreciated here, Mikhail, I invite you to
> participate as much as you can on Onami extensions development :)
>
> All the best, keep up the good work!
> -Simo
>
Re: [VOTE] gradiate the Converters extension out from the Sandbox
Posted by Simone Tripodi <si...@apache.org>.
> +0. Haven't looked at the code.
Any help will be really appreciated here, Mikhail, I invite you to
participate as much as you can on Onami extensions development :)
All the best, keep up the good work!
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
Re: [VOTE] gradiate the Converters extension out from the Sandbox
Posted by Mikhail Mazursky <mi...@gmail.com>.
+0. Haven't looked at the code.
2013/2/20 Simone Tripodi <si...@apache.org>
> my +1
>
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
>
> On Tue, Feb 19, 2013 at 9:43 PM, Simone Tripodi
> <si...@apache.org> wrote:
> > Hi all,
> >
> > Converters extension is IMHO ready to be pushed out from the Sandbox,
> > so I propose to graduate it to propert /trunk
> >
> > [ ] +1 let's promote it
> > [ ] ±0 go ahead, but...
> > [ ] -1 because... (provide a reason)
> >
> > This vote is open for at least 72h and closes ~ on Feb 22th, at 8:40 GMT
> >
> > Many thanks in advance, all the best!
> > -Simo
> >
> > http://people.apache.org/~simonetripodi/
> > http://simonetripodi.livejournal.com/
> > http://twitter.com/simonetripodi
> > http://www.99soft.org/
>
Re: [VOTE] gradiate the Converters extension out from the Sandbox
Posted by Simone Tripodi <si...@apache.org>.
my +1
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Tue, Feb 19, 2013 at 9:43 PM, Simone Tripodi
<si...@apache.org> wrote:
> Hi all,
>
> Converters extension is IMHO ready to be pushed out from the Sandbox,
> so I propose to graduate it to propert /trunk
>
> [ ] +1 let's promote it
> [ ] ±0 go ahead, but...
> [ ] -1 because... (provide a reason)
>
> This vote is open for at least 72h and closes ~ on Feb 22th, at 8:40 GMT
>
> Many thanks in advance, all the best!
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
Re: [VOTE] gradiate the Converters extension out from the Sandbox
Posted by Jordi Gerona <jo...@apache.org>.
+1
code looks amazing! so simple and powerful at the same time
On Wed, Feb 20, 2013 at 8:54 PM, Daniel Manzke <daniel.manzke@googlemail.com
> wrote:
> +1
>
>
> 2013/2/19 Simone Tripodi <si...@apache.org>
>
> > Hi all,
> >
> > Converters extension is IMHO ready to be pushed out from the Sandbox,
> > so I propose to graduate it to propert /trunk
> >
> > [ ] +1 let's promote it
> > [ ] ±0 go ahead, but...
> > [ ] -1 because... (provide a reason)
> >
> > This vote is open for at least 72h and closes ~ on Feb 22th, at 8:40 GMT
> >
> > Many thanks in advance, all the best!
> > -Simo
> >
> > http://people.apache.org/~simonetripodi/
> > http://simonetripodi.livejournal.com/
> > http://twitter.com/simonetripodi
> > http://www.99soft.org/
> >
>
>
>
> --
> Viele Grüße/Best Regards
>
> Daniel Manzke
>
Re: [VOTE] gradiate the Converters extension out from the Sandbox
Posted by Daniel Manzke <da...@googlemail.com>.
+1
2013/2/19 Simone Tripodi <si...@apache.org>
> Hi all,
>
> Converters extension is IMHO ready to be pushed out from the Sandbox,
> so I propose to graduate it to propert /trunk
>
> [ ] +1 let's promote it
> [ ] ±0 go ahead, but...
> [ ] -1 because... (provide a reason)
>
> This vote is open for at least 72h and closes ~ on Feb 22th, at 8:40 GMT
>
> Many thanks in advance, all the best!
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
--
Viele Grüße/Best Regards
Daniel Manzke
[RESULT][VOTE] gradiate the Converters extension out from the Sandbox
Posted by Simone Tripodi <si...@apache.org>.
Hi all,
more than 72h have passed and the current vote thread can be
considered concluded and passes with the following resolution:
five positive binding votes from following committers:
* Simone Tripodi
* Daniel Manzke
* Jordi Gerona
* Mikhail Mazursky
* Eric Charles
no other votes have been casted.
Converters is now part of the proper components, thanks all to take
part to the vote!
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Tue, Feb 19, 2013 at 9:43 PM, Simone Tripodi
<si...@apache.org> wrote:
> Hi all,
>
> Converters extension is IMHO ready to be pushed out from the Sandbox,
> so I propose to graduate it to propert /trunk
>
> [ ] +1 let's promote it
> [ ] ±0 go ahead, but...
> [ ] -1 because... (provide a reason)
>
> This vote is open for at least 72h and closes ~ on Feb 22th, at 8:40 GMT
>
> Many thanks in advance, all the best!
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/