You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@groovy.apache.org by paulk-asert <gi...@git.apache.org> on 2016/07/19 07:19:03 UTC

[GitHub] groovy pull request #367: GROOVY-7600: @Immutable support for Optional?

GitHub user paulk-asert opened a pull request:

    https://github.com/apache/groovy/pull/367

    GROOVY-7600: @Immutable support for Optional?

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paulk-asert/groovy groovy7600

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/367.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #367
    
----
commit 3c2e45b0154b54353983a3b62926aec42ea61479
Author: paulk <pa...@asert.com.au>
Date:   2016-07-19T07:17:50Z

    GROOVY-7600: @Immutable support for Optional?

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] groovy pull request #367: GROOVY-7600: @Immutable support for Optional?

Posted by paulk-asert <gi...@git.apache.org>.

Github user paulk-asert closed the pull request at:

    https://github.com/apache/groovy/pull/367


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] groovy pull request #367: GROOVY-7600: @Immutable support for Optional?

Posted by jwagenleitner <gi...@git.apache.org>.

Github user jwagenleitner commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/367#discussion_r71348536
  
    --- Diff: src/test/org/codehaus/groovy/transform/ImmutableTransformTest.groovy ---
    @@ -18,12 +18,40 @@
      */
     package org.codehaus.groovy.transform
     
    +import org.codehaus.groovy.control.MultipleCompilationErrorsException
    +import org.junit.After
    +import org.junit.Before
    +import org.junit.Rule
    +import org.junit.Test
    +import org.junit.rules.TestName
    +import org.junit.runner.RunWith
    +import org.junit.runners.JUnit4
    +
    +import static org.junit.Assume.assumeTrue
    +
     /**
    - * @author Paul King
    - * @author Tim Yates
    + * Tests for the @Immutable transform.
      */
    +@RunWith(JUnit4)
     class ImmutableTransformTest extends GroovyShellTestCase {
     
    +    @Rule public TestName nameRule = new TestName()
    +
    +    @Before
    +    void setUp() {
    +        super.setUp()
    +        // check java version requirements
    +        def m = System.getProperty("java.version") =~ /\d\.\d+/
    --- End diff --
    
    This may fail on jdk9 with the new versioning scheme.  Maybe the following would work since (at the moment) this returns 9 on jdk9 ea's.
    
    ```
    new BigDecimal(System.getProperty('java.specification.version')) >= 1.8
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---