You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by "subbudvk (via GitHub)" <gi...@apache.org> on 2025/01/03 14:14:29 UTC
[PR] TIKA-4365 : feat : Support Detection for AAB Bundle file [tika]
subbudvk opened a new pull request, #2085:
URL: https://github.com/apache/tika/pull/2085
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for your contribution to [Apache Tika](https://tika.apache.org/)! Your help is appreciated!
Before opening the pull request, please verify that
* there is an open issue on the [Tika issue tracker](https://issues.apache.org/jira/projects/TIKA) which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
* the issue ID (`TIKA-XXXX`)
- is referenced in the title of the pull request
- and placed in front of your commit messages surrounded by square brackets (`[TIKA-XXXX] Issue or pull request title`)
* commits are squashed into a single one (or few commits for larger changes)
* Tika is successfully built and unit tests pass by running `mvn clean test`
* there should be no conflicts when merging the pull request branch into the *recent* `main` branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled `main` branch
* if you add new module that downstream users will depend upon add it to relevant group in `tika-bom/pom.xml`.
We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the [Tika mailing list](http://tika.apache.org/mail-lists.html). Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4365 : feat : Support Detection for AAB Bundle file [tika]
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #2085:
URL: https://github.com/apache/tika/pull/2085#issuecomment-2612396962
I'll merge this as soon as the checks pass. On a follow-on PR, if you have a chance, would you be able to create/find an ASL 2.0-compatible test file for a unit test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4365 : feat : Support Detection for AAB Bundle file [tika]
Posted by "subbudvk (via GitHub)" <gi...@apache.org>.
subbudvk commented on PR #2085:
URL: https://github.com/apache/tika/pull/2085#issuecomment-2612380253
@tballison you are right. The Jar detector decides content based on the presence of MANIFEST.MF. The android package bundle will also have MANIFEST.MF, so to guarantee the order and JarDetector doesn't return jar based on MANIFEST.MF and since other android types are already handled in JarDetector, I changed here.
Let me know if you have comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4365 : feat : Support Detection for AAB Bundle file [tika]
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison merged PR #2085:
URL: https://github.com/apache/tika/pull/2085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4365 : feat : Support Detection for AAB Bundle file [tika]
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #2085:
URL: https://github.com/apache/tika/pull/2085#issuecomment-2612368867
I'm sorry for my delay on this. Is there a reason to put the android logic in the jar detector instead of a separate detector? The good thing about the current PR is that it guarantees the order of detectors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org