You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/18 09:22:58 UTC
[GitHub] [flink] liuzhuang2017 opened a new pull request, #19506: [hotfix][docs] Fixed memory units in "Migration Guide" under "Memory Configuration" page.
liuzhuang2017 opened a new pull request, #19506:
URL: https://github.com/apache/flink/pull/19506
## What is the purpose of the change
### English document：
- The markdown file is located in docs/content/docs/deployment/memory/mem_migration.md.
### Chinese document：
- The markdown file is located in docs/content.zh/docs/deployment/memory/mem_migration.md.
**According to the Chinese and English documentation above, I think "Mb" in it should be "MB". Because Mb and MB are not the same,in terms of memory, a byte is the smallest storage slot. Your hard drives, SSDs, USB sticks, and system memory are always measured in bytes.**
Please see "https://www.lifewire.com/what-is-a-megabit-2483412" for detailed differences.
According to experience, they have the following relationship:
- 8 Mb = 1 MB
- 1Mb = 1/8 MB = 0.125 MB
## Brief change log
Changed "Mb" in the documentation to "MB".
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no )
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? ( no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19506: [hotfix][docs] Fixed memory units in "Migration Guide" under "Memory Configuration" page.
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #19506:
URL: https://github.com/apache/flink/pull/19506#issuecomment-1102681502
Pipeline failure is unrelated to docs change, merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19506: [hotfix][docs] Fixed memory units in "Migration Guide" under "Memory Configuration" page.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19506:
URL: https://github.com/apache/flink/pull/19506#issuecomment-1101258544
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93ae08431e1d36d8932a1327e4d3cee64ba801b5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "93ae08431e1d36d8932a1327e4d3cee64ba801b5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 93ae08431e1d36d8932a1327e4d3cee64ba801b5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] liuzhuang2017 commented on pull request #19506: [hotfix][docs] Fixed memory units in "Migration Guide" under "Memory Configuration" page.
Posted by GitBox <gi...@apache.org>.
liuzhuang2017 commented on PR #19506:
URL: https://github.com/apache/flink/pull/19506#issuecomment-1102706487
@MartijnVisser , Thanks for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] liuzhuang2017 commented on pull request #19506: [hotfix][docs] Fixed memory units in "Migration Guide" under "Memory Configuration" page.
Posted by GitBox <gi...@apache.org>.
liuzhuang2017 commented on PR #19506:
URL: https://github.com/apache/flink/pull/19506#issuecomment-1102266344
@MartijnVisser , Sorry to bother you, can you help me review this pr? Thanks you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] liuzhuang2017 commented on pull request #19506: [hotfix][docs] Fixed memory units in "Migration Guide" under "Memory Configuration" page.
Posted by GitBox <gi...@apache.org>.
liuzhuang2017 commented on PR #19506:
URL: https://github.com/apache/flink/pull/19506#issuecomment-1102486281
@MartijnVisser ,Thanks for your reply, I'll try to fix all these kinds of issues in the documentation based on your suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser merged pull request #19506: [hotfix][docs] Fixed memory units in "Migration Guide" under "Memory Configuration" page.
Posted by GitBox <gi...@apache.org>.
MartijnVisser merged PR #19506:
URL: https://github.com/apache/flink/pull/19506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org