You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "wecharyu (via GitHub)" <gi...@apache.org> on 2023/09/13 13:03:41 UTC
[GitHub] [hudi] wecharyu opened a new pull request, #9707: [HUDI-6855] Exclude .hoodie_partition_metadata file in base file group
wecharyu opened a new pull request, #9707:
URL: https://github.com/apache/hudi/pull/9707
### Change Logs
Currently Hudi will build FileGroups for .hoodie_partition_metadata.parquet, and resovle the .hoodie as fileId, metadata as commit time.
Although these partiition metadata file groups will be filtered when comparing commit time, we can remove them while building file groups.
### Impact
No
### Risk level (write none, low medium or high below)
low
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua merged pull request #9707: [HUDI-6855] Exclude .hoodie_partition_metadata file in base file group
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #9707:
URL: https://github.com/apache/hudi/pull/9707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #9707: [HUDI-6855] Exclude .hoodie_partition_metadata file in base file group
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #9707:
URL: https://github.com/apache/hudi/pull/9707#discussion_r1325229264
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -478,8 +479,14 @@ protected FileStatus[] listPartition(Path partitionPath) throws IOException {
* @param statuses List of File-Status
*/
private Stream<HoodieBaseFile> convertFileStatusesToBaseFiles(FileStatus[] statuses) {
- Predicate<FileStatus> roFilePredicate = fileStatus -> fileStatus.getPath().getName()
- .contains(metaClient.getTableConfig().getBaseFileFormat().getFileExtension());
+ Predicate<FileStatus> roFilePredicate = fileStatus -> {
+ String pathName = fileStatus.getPath().getName();
+ // Filter base files if:
+ // 1. file extension equals to table configured file extension
Review Comment:
Reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on pull request #9707: [HUDI-6855] Exclude .hoodie_partition_metadata file in base file group
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #9707:
URL: https://github.com/apache/hudi/pull/9707#issuecomment-1718632410
`test-hudi-hadoop-mr-and-hudi-java-client (scala-2.12, spark3.2, flink1.17)` in GH action is flaky. Azure CI is green.
Merging this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9707: [HUDI-6855] Exclude .hoodie_partition_metadata file in base file group
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9707:
URL: https://github.com/apache/hudi/pull/9707#issuecomment-1717984410
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cfd2fd1dbc5b87ce1db33436a65fe3bd0bf8c025",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19891",
"triggerID" : "cfd2fd1dbc5b87ce1db33436a65fe3bd0bf8c025",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cfd2fd1dbc5b87ce1db33436a65fe3bd0bf8c025 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19891)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9707: [HUDI-6855] Exclude .hoodie_partition_metadata file in base file group
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9707:
URL: https://github.com/apache/hudi/pull/9707#issuecomment-1717678026
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cfd2fd1dbc5b87ce1db33436a65fe3bd0bf8c025",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19891",
"triggerID" : "cfd2fd1dbc5b87ce1db33436a65fe3bd0bf8c025",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cfd2fd1dbc5b87ce1db33436a65fe3bd0bf8c025 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19891)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9707: [HUDI-6855] Exclude .hoodie_partition_metadata file in base file group
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9707:
URL: https://github.com/apache/hudi/pull/9707#issuecomment-1717660809
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cfd2fd1dbc5b87ce1db33436a65fe3bd0bf8c025",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cfd2fd1dbc5b87ce1db33436a65fe3bd0bf8c025",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cfd2fd1dbc5b87ce1db33436a65fe3bd0bf8c025 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org