You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2014/01/01 08:52:00 UTC
Review Request 16551: put the hard coded rdp server port in host deatils
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16551/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh, Donal Lafferty, and Rajesh Battala.
Bugs: CLOUDSTACK-5703
https://issues.apache.org/jira/browse/CLOUDSTACK-5703
Repository: cloudstack-git
Description
-------
This patch removes the hard coded value of rdp server port and put it in host details
Diffs
-----
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/discoverer/HypervServerDiscoverer.java 2330da1
server/src/com/cloud/servlet/ConsoleProxyServlet.java e0aaa6d
Diff: https://reviews.apache.org/r/16551/diff/
Testing
-------
tested on my local setup
Thanks,
Anshul Gangwar
Re: Review Request 16551: put the hard coded rdp server port in host deatils
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16551/#review31009
-----------------------------------------------------------
Ship it!
Committed in e74889ac91c919ab26852da3d93133eaeae874c8
- Devdeep Singh
On Jan. 1, 2014, 7:52 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16551/
> -----------------------------------------------------------
>
> (Updated Jan. 1, 2014, 7:52 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Donal Lafferty, and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-5703
> https://issues.apache.org/jira/browse/CLOUDSTACK-5703
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch removes the hard coded value of rdp server port and put it in host details
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/discoverer/HypervServerDiscoverer.java 2330da1
> server/src/com/cloud/servlet/ConsoleProxyServlet.java e0aaa6d
>
> Diff: https://reviews.apache.org/r/16551/diff/
>
>
> Testing
> -------
>
> tested on my local setup
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 16551: put the hard coded rdp server port in host deatils
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16551/#review31007
-----------------------------------------------------------
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/discoverer/HypervServerDiscoverer.java
<https://reviews.apache.org/r/16551/#comment59372>
The rdp server port should be returned in details by the hyperv agent. You can update the agent to populate the port details in StartupCommand
- Devdeep Singh
On Jan. 1, 2014, 7:52 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16551/
> -----------------------------------------------------------
>
> (Updated Jan. 1, 2014, 7:52 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Donal Lafferty, and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-5703
> https://issues.apache.org/jira/browse/CLOUDSTACK-5703
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch removes the hard coded value of rdp server port and put it in host details
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/discoverer/HypervServerDiscoverer.java 2330da1
> server/src/com/cloud/servlet/ConsoleProxyServlet.java e0aaa6d
>
> Diff: https://reviews.apache.org/r/16551/diff/
>
>
> Testing
> -------
>
> tested on my local setup
>
>
> Thanks,
>
> Anshul Gangwar
>
>