[GitHub] [shardingsphere] dongzl commented on a change in pull request #7371: Refactor InsertStatement, add subclass for different databases.

[GitBox <gi...@apache.org>]

dongzl commented on a change in pull request #7371:
URL: https://github.com/apache/shardingsphere/pull/7371#discussion_r486279545



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dml/InsertStatement.java
##########
@@ -43,7 +43,7 @@
  */
 @Getter
 @Setter
-public final class InsertStatement extends AbstractSQLStatement implements DMLStatement {
+public abstract class InsertStatement extends AbstractSQLStatement {

Review comment:
       Hi @tristaZero , yes, we should split these segments into child classes, I want to finish this work in another PR, because in one PR, it will be modify too much files and make the code review difficultly.
   
   and I will communicate with jingshang right now, make sure the work not conflict.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org