You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/10/10 05:49:54 UTC
[GitHub] [kylin] zzcclp commented on a change in pull request #1440: KYLIN-4689 BuildJobSubmitter should obey MaxJobLimit
zzcclp commented on a change in pull request #1440:
URL: https://github.com/apache/kylin/pull/1440#discussion_r502750727
##########
File path: stream-coordinator/src/main/java/org/apache/kylin/stream/coordinator/coordinate/BuildJobSubmitter.java
##########
@@ -165,6 +166,11 @@ void doRun() {
for (StreamingCubeInfo cubeInfo : coordinator.getEnableStreamingCubes()) {
List<String> segmentList = checkSegmentBuildJobFromMetadata(cubeInfo.getCubeName());
for (String segmentName : segmentList) {
+ boolean isFull = DefaultScheduler.getInstance().getFetcherRunner().isJobPoolFull();
+ if (isFull) {
+ logger.info("Hit MaxConcurrentJobLimit, hold {}.", segmentName);
+ break;
+ }
Review comment:
IMO, it can add this check logical code at the beginning of function 'submitSegmentBuildJob'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org