[GitHub] [arrow-rs] alamb commented on a diff in pull request #3895: Use BooleanBuffer in BooleanArray (#3879)

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #3895:
URL: https://github.com/apache/arrow-rs/pull/3895#discussion_r1143825203


##########
arrow-ord/src/comparison.rs:
##########
@@ -196,23 +195,19 @@ pub fn eq_bool_scalar(
     left: &BooleanArray,
     right: bool,
 ) -> Result<BooleanArray, ArrowError> {
-    let len = left.len();
-    let left_offset = left.offset();
-
-    let values = if right {
-        left.values().bit_slice(left_offset, len)
-    } else {
-        buffer_unary_not(left.values(), left.offset(), left.len())
+    let values = match right {
+        true => left.values().clone(),
+        false => !left.values(),

Review Comment:
   that is fancy 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org