[jira] [Commented] (HBASE-9695) Some never used local variables cleanup.

["Jean-Marc Spaggiari (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-9695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783374#comment-13783374 ] 

Jean-Marc Spaggiari commented on HBASE-9695:
--------------------------------------------

There is one more that I did not fixed...

{code}
  @Test
  public void testRegexStringComparator() throws Exception {
    // test without specifying flags
    RegexStringComparator regexStringComparator = new RegexStringComparator(".+-2");
    assertTrue(regexStringComparator.areSerializedFieldsEqual(
      ProtobufUtil.toComparator(ProtobufUtil.toComparator(regexStringComparator))));

    // test with specifying flags
    regexStringComparator =
      new RegexStringComparator("regex", Pattern.CASE_INSENSITIVE | Pattern.DOTALL);
  }
{code}

The last RegexStringComparator is not used, but might be used for the test it it throws an exception, however, if that's the case, it's the the right way to do it. So we most probably can remove it too. Thought?


> Some never used local variables cleanup.
> ----------------------------------------
>
>                 Key: HBASE-9695
>                 URL: https://issues.apache.org/jira/browse/HBASE-9695
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.0, 0.96.1
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>            Priority: Minor
>         Attachments: HBASE-9695-v0-trunk.patch
>
>
> There is few local variables defined that we can clean-up.



--
This message was sent by Atlassian JIRA
(v6.1#6144)