You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Markus Wichitill <ma...@gmx.de> on 2004/07/16 21:37:27 UTC
[mp2] Some tests fail because of backslashes on Win32
Hi,
some tests fail because of backslashes on Win32 with current CVS. Roughly
two days ago these still worked.
C:\A\modperl-2.0\ModPerl-Registry>perl t/TEST -verbose t/basic.t
C:\dev\apache2\bin\Apache.EXE -d C:/A/modperl-2.0/ModPerl-Registry/t -f
C:/A/modperl-2.0/ModPerl-Registry/t/conf/httpd.conf -D APACHE2 -D
PERL_USEITHREADS
using Apache/2.0.50 (winnt MPM)
waiting 180 seconds for server to start: ...........
waiting 180 seconds for server to start: ok (waited 10 secs)
server localhost:8529 started
t\basic....1..18
# Running under perl version 5.008004 for MSWin32
# Win32::BuildNumber 810
# Current time local: Fri Jul 16 21:04:18 2004
# Current time GMT: Fri Jul 16 19:04:18 2004
# Using Test.pm version 1.25
# Using Apache/Test.pm version 1.13
# testing : ModPerl::PerlRun basic cgi test
# expected: ok C:/A/modperl-2.0/ModPerl-Registry/t/cgi-bin/basic.pl
# received: ok C:/A/modperl-2.0/ModPerl-Registry/t/cgi-bin/basic.pl
ok 1
# Failed test 2 in t\basic.t at line 28 fail #2
# testing : ModPerl::Registry basic cgi test
# expected: ok C:/A/modperl-2.0/ModPerl-Registry/t/cgi-bin/basic.pl
# received: ok C:\A\modperl-2.0\ModPerl-Registry\t\cgi-bin/basic.pl
not ok 2
# Failed test 3 in t\basic.t at line 28 fail #3
# testing : ModPerl::RegistryBB basic cgi test
# expected: ok C:/A/modperl-2.0/ModPerl-Registry/t/cgi-bin/basic.pl
# received: ok C:\A\modperl-2.0\ModPerl-Registry\t\cgi-bin\basic.pl
not ok 3
[...]
C:\A\modperl-2.0\ModPerl-Registry>perl t/TEST -verbose t/redirect.t
C:\dev\apache2\bin\Apache.EXE -d C:/A/modperl-2.0/ModPerl-Registry/t -f
C:/A/modperl-2.0/ModPerl-Registry/t/conf/httpd.conf -D APACHE2 -D
PERL_USEITHREADS
using Apache/2.0.50 (winnt MPM)
waiting 180 seconds for server to start: ...........
waiting 180 seconds for server to start: ok (waited 10 secs)
server localhost:8529 started
t\redirect....1..4
# Running under perl version 5.008004 for MSWin32
# Win32::BuildNumber 810
# Current time local: Fri Jul 16 21:13:24 2004
# Current time GMT: Fri Jul 16 19:13:24 2004
# Using Test.pm version 1.25
# Using Apache/Test.pm version 1.13
# Failed test 1 in t\redirect.t at line 21
# testing : test redirect: existing target
# expected: ok C:/A/modperl-2.0/ModPerl-Registry/t/cgi-bin/basic.pl
# received: ok C:\A\modperl-2.0\ModPerl-Registry\t\cgi-bin/basic.pl
not ok 1
[...]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [mp2] Some tests fail because of backslashes on Win32
Posted by Stas Bekman <st...@stason.org>.
Markus Wichitill wrote:
> Stas Bekman wrote:
>
>> now please do the whole 'make test' with this patch:
>
>
> All tests successful, thanks.
Thanks Markus, I'll commit those.
> BTW, I had some problems applying these inline patches with their extra
> linebreaks, but after reactivating format=flowed support in Thunderbird
> (which some extension must have disabled), it worked fine.
Cool. I've checked the lines weren't wrapped in the received message.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [mp2] Some tests fail because of backslashes on Win32
Posted by Markus Wichitill <ma...@gmx.de>.
Stas Bekman wrote:
> now please do the whole 'make test' with this patch:
All tests successful, thanks.
BTW, I had some problems applying these inline patches with their extra
linebreaks, but after reactivating format=flowed support in Thunderbird
(which some extension must have disabled), it worked fine.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [mp2] Some tests fail because of backslashes on Win32
Posted by Stas Bekman <st...@stason.org>.
Thanks Markus, now please do the whole 'make test' with this patch:
Index: ModPerl-Registry/t/conf/modperl_extra_startup.pl
===================================================================
RCS file:
/home/cvs/modperl-2.0/ModPerl-Registry/t/conf/modperl_extra_startup.pl,v
retrieving revision 1.18
diff -u -r1.18 modperl_extra_startup.pl
--- ModPerl-Registry/t/conf/modperl_extra_startup.pl 16 Jul 2004
01:10:45 -0000 1.18
+++ ModPerl-Registry/t/conf/modperl_extra_startup.pl 16 Jul 2004
21:40:09 -0000
@@ -8,12 +8,14 @@
use Apache::ServerRec ();
use Apache::ServerUtil ();
+use Apache::Process ();
-use File::Spec ();
use DirHandle ();
-my $base_dir = File::Spec->catdir(Apache::ServerUtil::server_root,
- "cgi-bin");
+my $proc = Apache->server->process;
+my $pool = $proc->pool;
+
+my $base_dir = Apache::ServerUtil::server_root_relative($pool, "cgi-bin");
# test the scripts pre-loading by explicitly specifying uri => filename
my $rl = ModPerl::RegistryLoader->new(package => "ModPerl::Registry");
@@ -30,7 +32,7 @@
sub trans {
my $uri = shift;
$uri =~ s|^/registry_bb/|cgi-bin/|;
- return File::Spec->catdir(Apache::ServerUtil::server_root, $uri);
+ return Apache::ServerUtil::server_root_relative($pool, $uri);
}
my $rl = ModPerl::RegistryLoader->new(
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [mp2] Some tests fail because of backslashes on Win32
Posted by Markus Wichitill <ma...@gmx.de>.
> Just for the basic.t. does this remove the problem?
>
> Index: ModPerl-Registry/t/conf/modperl_extra_startup.pl
> ===================================================================
> RCS file:
> /home/cvs/modperl-2.0/ModPerl-Registry/t/conf/modperl_extra_startup.pl,v
> retrieving revision 1.18
> diff -u -r1.18 modperl_extra_startup.pl
> --- ModPerl-Registry/t/conf/modperl_extra_startup.pl 16 Jul 2004
> 01:10:45 -0000 1.18
> +++ ModPerl-Registry/t/conf/modperl_extra_startup.pl 16 Jul 2004
> 20:39:22 -0000
> @@ -8,12 +8,13 @@
>
> use Apache::ServerRec ();
> use Apache::ServerUtil ();
> +use Apache::Process ();
>
> use File::Spec ();
> use DirHandle ();
>
> -my $base_dir = File::Spec->catdir(Apache::ServerUtil::server_root,
> - "cgi-bin");
> +my $base_dir = Apache::ServerUtil::server_root_relative(
> + Apache->server->process->pconf, "cgi-bin");
>
> # test the scripts pre-loading by explicitly specifying uri => filename
> my $rl = ModPerl::RegistryLoader->new(package => "ModPerl::Registry");
>
>
> I guess server_root_relative converts the path into the OS style,
> whereas server_root just gives a hardcoded value which is unix style.
# testing : ModPerl::PerlRun basic cgi test
# expected: ok C:/A/modperl-2.0/ModPerl-Registry/t/cgi-bin/basic.pl
# received: ok C:/A/modperl-2.0/ModPerl-Registry/t/cgi-bin/basic.pl
ok 1
# testing : ModPerl::Registry basic cgi test
# expected: ok C:/A/modperl-2.0/ModPerl-Registry/t/cgi-bin/basic.pl
# received: ok C:/A/modperl-2.0/ModPerl-Registry/t/cgi-bin/basic.pl
ok 2
# Failed test 3 in t\basic.t at line 28 fail #3
# testing : ModPerl::RegistryBB basic cgi test
# expected: ok C:/A/modperl-2.0/ModPerl-Registry/t/cgi-bin/basic.pl
# received: ok C:\A\modperl-2.0\ModPerl-Registry\t\cgi-bin\basic.pl
not ok 3
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [mp2] Some tests fail because of backslashes on Win32
Posted by Stas Bekman <st...@stason.org>.
Markus Wichitill wrote:
> Hi,
>
> some tests fail because of backslashes on Win32 with current CVS.
> Roughly two days ago these still worked.
>
>
> C:\A\modperl-2.0\ModPerl-Registry>perl t/TEST -verbose t/basic.t
> C:\dev\apache2\bin\Apache.EXE -d C:/A/modperl-2.0/ModPerl-Registry/t -f
> C:/A/modperl-2.0/ModPerl-Registry/t/conf/httpd.conf -D APACHE2 -D
> PERL_USEITHREADS
> using Apache/2.0.50 (winnt MPM)
>
> waiting 180 seconds for server to start: ...........
> waiting 180 seconds for server to start: ok (waited 10 secs)
> server localhost:8529 started
> t\basic....1..18
> # Running under perl version 5.008004 for MSWin32
> # Win32::BuildNumber 810
> # Current time local: Fri Jul 16 21:04:18 2004
> # Current time GMT: Fri Jul 16 19:04:18 2004
> # Using Test.pm version 1.25
> # Using Apache/Test.pm version 1.13
> # testing : ModPerl::PerlRun basic cgi test
> # expected: ok C:/A/modperl-2.0/ModPerl-Registry/t/cgi-bin/basic.pl
> # received: ok C:/A/modperl-2.0/ModPerl-Registry/t/cgi-bin/basic.pl
> ok 1
> # Failed test 2 in t\basic.t at line 28 fail #2
> # testing : ModPerl::Registry basic cgi test
> # expected: ok C:/A/modperl-2.0/ModPerl-Registry/t/cgi-bin/basic.pl
> # received: ok C:\A\modperl-2.0\ModPerl-Registry\t\cgi-bin/basic.pl
> not ok 2
> # Failed test 3 in t\basic.t at line 28 fail #3
> # testing : ModPerl::RegistryBB basic cgi test
> # expected: ok C:/A/modperl-2.0/ModPerl-Registry/t/cgi-bin/basic.pl
> # received: ok C:\A\modperl-2.0\ModPerl-Registry\t\cgi-bin\basic.pl
> not ok 3
> [...]
Just for the basic.t. does this remove the problem?
Index: ModPerl-Registry/t/conf/modperl_extra_startup.pl
===================================================================
RCS file:
/home/cvs/modperl-2.0/ModPerl-Registry/t/conf/modperl_extra_startup.pl,v
retrieving revision 1.18
diff -u -r1.18 modperl_extra_startup.pl
--- ModPerl-Registry/t/conf/modperl_extra_startup.pl 16 Jul 2004
01:10:45 -0000 1.18
+++ ModPerl-Registry/t/conf/modperl_extra_startup.pl 16 Jul 2004
20:39:22 -0000
@@ -8,12 +8,13 @@
use Apache::ServerRec ();
use Apache::ServerUtil ();
+use Apache::Process ();
use File::Spec ();
use DirHandle ();
-my $base_dir = File::Spec->catdir(Apache::ServerUtil::server_root,
- "cgi-bin");
+my $base_dir = Apache::ServerUtil::server_root_relative(
+ Apache->server->process->pconf, "cgi-bin");
# test the scripts pre-loading by explicitly specifying uri => filename
my $rl = ModPerl::RegistryLoader->new(package => "ModPerl::Registry");
I guess server_root_relative converts the path into the OS style,
whereas server_root just gives a hardcoded value which is unix style.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org