You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "YarBor (via GitHub)" <gi...@apache.org> on 2024/06/04 15:01:44 UTC
[PR] support condition rule multiply destination [dubbo-go]
YarBor opened a new pull request, #2685:
URL: https://github.com/apache/dubbo-go/pull/2685
to support #2684
new condition-rule config like this
```yaml
configVersion: v3.1
scope: service
force: true
runtime: true
enabled: true
key: org.apache.dubbo.samples.CommentService
conditions:
- rule: method=getComment => region=Hangzhou
force: false
priority: 20
- rule: xxx
force: true
priority: 10
```
through `configVersion` to choose parse and load logic.
set `configVersion: v3.1` to use new.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] support conditional routing with multiple destinations, customize conditional routing priorities and operation in route fail [dubbo-go]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2685:
URL: https://github.com/apache/dubbo-go/pull/2685#issuecomment-2148820363
## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/2685?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `60.00000%` with `50 lines` in your changes missing coverage. Please review.
> Project coverage is 47.18%. Comparing base [(`2f5143a`)](https://app.codecov.io/gh/apache/dubbo-go/commit/2f5143a2acf4d420d2b93555a85021295bfe86f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`bb74a97`)](https://app.codecov.io/gh/apache/dubbo-go/commit/bb74a97cc74be64f217aff5869c31ba2470f35c0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 20 commits behind head on main.
> :exclamation: **Current head bb74a97 differs from pull request most recent head b70d8f7**
>
> Please [upload](https://docs.codecov.com/docs/codecov-uploader) reports for the commit b70d8f7 to get more accurate results.
| [Files](https://app.codecov.io/gh/apache/dubbo-go/pull/2685?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [cluster/router/condition/dynamic\_router.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2685?src=pr&el=tree&filepath=cluster%2Frouter%2Fcondition%2Fdynamic_router.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL2R5bmFtaWNfcm91dGVyLmdv) | 56.31% | [28 Missing and 17 partials :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/2685?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [cluster/router/condition/route.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2685?src=pr&el=tree&filepath=cluster%2Frouter%2Fcondition%2Froute.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL3JvdXRlLmdv) | 77.27% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/2685?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2685 +/- ##
==========================================
- Coverage 47.38% 47.18% -0.21%
==========================================
Files 341 343 +2
Lines 25122 25413 +291
==========================================
+ Hits 11904 11991 +87
- Misses 12074 12250 +176
- Partials 1144 1172 +28
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-go/pull/2685?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] support conditional routing with multiple destinations, customize conditional routing priorities and operation in route fail [dubbo-go]
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj merged PR #2685:
URL: https://github.com/apache/dubbo-go/pull/2685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] support conditional routing with multiple destinations, customize conditional routing priorities and operation in route fail [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #2685:
URL: https://github.com/apache/dubbo-go/pull/2685#discussion_r1627112397
##########
cluster/router/condition/dynamic_router.go:
##########
@@ -18,27 +18,26 @@
package condition
import (
- "dubbo.apache.org/dubbo-go/v3/cluster/utils"
"fmt"
- "gopkg.in/yaml.v2"
"sort"
"strconv"
"strings"
"sync"
)
import (
- "github.com/dubbogo/gost/log/logger"
-)
-
-import (
+ "dubbo.apache.org/dubbo-go/v3/cluster/utils"
Review Comment:
https://github.com/dubbogo/resources/tree/master/tools/imports-formatter 用这个工具 format 下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] support conditional routing with multiple destinations, customize conditional routing priorities and operation in route fail [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2685:
URL: https://github.com/apache/dubbo-go/pull/2685#issuecomment-2148788626
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2685) **Quality Gate passed**
Issues
 [9 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2685&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2685&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2685&resolved=false&sinceLeakPeriod=true)
 No data about Coverage
 [2.5% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2685&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2685)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] support conditional routing with multiple destinations, customize conditional routing priorities and operation in route fail [dubbo-go]
Posted by "YarBor (via GitHub)" <gi...@apache.org>.
YarBor commented on PR #2685:
URL: https://github.com/apache/dubbo-go/pull/2685#issuecomment-2159810493
#2686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] support condition rule multiply destination [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2685:
URL: https://github.com/apache/dubbo-go/pull/2685#issuecomment-2147764925
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2685) **Quality Gate passed**
Issues
 [9 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2685&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2685&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2685&resolved=false&sinceLeakPeriod=true)
 No data about Coverage
 [2.5% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2685&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2685)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] support conditional routing with multiple destinations, customize conditional routing priorities and operation in route fail [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #2685:
URL: https://github.com/apache/dubbo-go/pull/2685#discussion_r1626863541
##########
cluster/router/condition/dynamic_router.go:
##########
@@ -18,6 +18,10 @@
package condition
import (
+ "dubbo.apache.org/dubbo-go/v3/cluster/utils"
Review Comment:
format 下 import 的整体内容
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] support conditional routing with multiple destinations, customize conditional routing priorities and operation in route fail [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2685:
URL: https://github.com/apache/dubbo-go/pull/2685#issuecomment-2148834090
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2685) **Quality Gate passed**
Issues
 [9 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2685&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2685&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2685&resolved=false&sinceLeakPeriod=true)
 No data about Coverage
 [2.5% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2685&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2685)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org