You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/12 01:46:55 UTC

[GitHub] [apisix] membphis commented on pull request #2935: feat: Implement traffic splitting plugin

membphis commented on pull request #2935:
URL: https://github.com/apache/apisix/pull/2935#issuecomment-743619285


   > 4\. the `upstreams` should highlight its function, i.e. weighted selection, so maybe "weighted_upstreams" or "weighted_clusters" is more suitable, since we will have label based selector in the future, we should distinguish them.
   
   `weighted_upstreams` is better than before, but I think we should use the singular form here, this field only works for one upstream.
   
   I prefer the name `weighted_upstream`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org