Re: [PR] feat(desktop): read a custom relay's model catalog before saving [maka]

["rootkiller6788 (via GitHub)" <gi...@apache.org>]

rootkiller6788 commented on PR #3700:
URL: https://github.com/apache/maka/pull/3700#issuecomment-5523464893

     Thanks for catching both — you were right on each.
   
     - P1 (credential leak): the probe now passes transient: true on connection.onboarding.verify, which skips
       canonical-slug resolution in storage, so a blank key no longer reuses the existing relay's stored credential. A
       blank key now returns credential_not_configured instead of probing with the wrong secret.
     - P2 (headers gap): the form's custom request headers ride along on the probe request and are validated at the IPC
       boundary, matching what the save path sends.
   
     Added regression coverage: a transient probe against an existing canonical relay asserts its key and headers never
     reach the new endpoint, plus decode coverage for the new transient/requestHeaders fields.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org