You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/01 22:23:36 UTC
[GitHub] [fineract] thesmallstar opened a new pull request #963: FINERACT-821 Added OneTopLevelClass checkstyle
thesmallstar opened a new pull request #963:
URL: https://github.com/apache/fineract/pull/963
Making an exception to the stopped checkstyle work as this won't cause any merge conflicts due to spotless.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #963: FINERACT-821 Added OneTopLevelClass checkstyle
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #963:
URL: https://github.com/apache/fineract/pull/963#issuecomment-637755852
That probably happened during a rebase, fixed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #963: FINERACT-821 Added OneTopLevelClass checkstyle
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #963:
URL: https://github.com/apache/fineract/pull/963#issuecomment-637643977
@vorburger merge this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #963: FINERACT-821 Added OneTopLevelClass checkstyle
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #963:
URL: https://github.com/apache/fineract/pull/963
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #963: FINERACT-821 Added OneTopLevelClass checkstyle
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #963:
URL: https://github.com/apache/fineract/pull/963#issuecomment-637294122
This will have to be re-based after #968 for FINERACT-1016 for the build to pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar edited a comment on pull request #963: FINERACT-821 Added OneTopLevelClass checkstyle
Posted by GitBox <gi...@apache.org>.
thesmallstar edited a comment on pull request #963:
URL: https://github.com/apache/fineract/pull/963#issuecomment-637755852
That probably happened during a rebase(unintentional), fixed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #963: FINERACT-821 Added OneTopLevelClass checkstyle
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #963:
URL: https://github.com/apache/fineract/pull/963#issuecomment-637266813
Build failure here is FINERACT-855 - please help us fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org