You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Hitesh Khamesra <hk...@pivotal.io> on 2015/12/10 22:57:46 UTC
Review Request 41224: added null check in checkAddressesForUUIDs
method
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41224/
-----------------------------------------------------------
Review request for geode and Bruce Schuchardt.
Repository: geode
Description
-------
For multicast ops it was null
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java bbe7ab3
Diff: https://reviews.apache.org/r/41224/diff/
Testing
-------
Thanks,
Hitesh Khamesra
Re: Review Request 41224: added null check in checkAddressesForUUIDs
method
Posted by Jason Huynh <hu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41224/#review109867
-----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java (line 1999)
<https://reviews.apache.org/r/41224/#comment169525>
Is this actually affecting us or a defensive measure at the moment?
- Jason Huynh
On Dec. 10, 2015, 9:57 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41224/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 9:57 p.m.)
>
>
> Review request for geode and Bruce Schuchardt.
>
>
> Repository: geode
>
>
> Description
> -------
>
> For multicast ops it was null
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java bbe7ab3
>
> Diff: https://reviews.apache.org/r/41224/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 41224: added null check in checkAddressesForUUIDs
method
Posted by Jason Huynh <hu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41224/#review109869
-----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java (line 1999)
<https://reviews.apache.org/r/41224/#comment169527>
Oops didnt read the description. ignore my last question
- Jason Huynh
On Dec. 10, 2015, 9:57 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41224/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 9:57 p.m.)
>
>
> Review request for geode and Bruce Schuchardt.
>
>
> Repository: geode
>
>
> Description
> -------
>
> For multicast ops it was null
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java bbe7ab3
>
> Diff: https://reviews.apache.org/r/41224/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 41224: added null check in checkAddressesForUUIDs
method
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41224/#review109880
-----------------------------------------------------------
Ship it!
Ship It!
- Bruce Schuchardt
On Dec. 10, 2015, 9:57 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41224/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 9:57 p.m.)
>
>
> Review request for geode and Bruce Schuchardt.
>
>
> Repository: geode
>
>
> Description
> -------
>
> For multicast ops it was null
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java bbe7ab3
>
> Diff: https://reviews.apache.org/r/41224/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>