You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "David Arthur (Created) (JIRA)" <ji...@apache.org> on 2012/03/28 23:15:27 UTC
[jira] [Created] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
RegexStringComparator supports java.util.regex.Pattern flags
------------------------------------------------------------
Key: HBASE-5667
URL: https://issues.apache.org/jira/browse/HBASE-5667
Project: HBase
Issue Type: Improvement
Components: filters
Reporter: David Arthur
Priority: Minor
Attachments: HBASE-5667.diff
* Add constructor that takes in a Pattern
* Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "Jimmy Xiang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241861#comment-13241861 ]
Jimmy Xiang commented on HBASE-5667:
------------------------------------
@Stack, I prefer to change them to pb so we should not bother to make them VersionedWritables for now.
We have lots of filters. We need to abstract them out and have a generic way to define them in pb.
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Priority: Minor
> Attachments: HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242701#comment-13242701 ]
Hudson commented on HBASE-5667:
-------------------------------
Integrated in HBase-TRUNK #2699 (See [https://builds.apache.org/job/HBase-TRUNK/2699/])
HBASE-5667 RegexStringComparator supports java.util.regex.Pattern flags (David Arthur) (Revision 1307580)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/RegexStringComparator.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/filter/TestSingleColumnValueFilter.java
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Assignee: David Arthur
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5667.diff, HBASE-5667.diff, HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243041#comment-13243041 ]
Hudson commented on HBASE-5667:
-------------------------------
Integrated in HBase-TRUNK-security #155 (See [https://builds.apache.org/job/HBase-TRUNK-security/155/])
HBASE-5667 RegexStringComparator supports java.util.regex.Pattern flags (David Arthur) (Revision 1307580)
Result = SUCCESS
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/RegexStringComparator.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/filter/TestSingleColumnValueFilter.java
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Assignee: David Arthur
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5667.diff, HBASE-5667.diff, HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "David Arthur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Arthur updated HBASE-5667:
--------------------------------
Attachment: HBASE-5667.diff
Yea on second thought keeping DOTALL is best for compatability. However, I don't like implicit things like that, so I added a comment to the (String) explaining it.
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Priority: Minor
> Attachments: HBASE-5667.diff, HBASE-5667.diff, HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241835#comment-13241835 ]
stack commented on HBASE-5667:
------------------------------
@Jimmy Whats going to happen in 0.96 serializing filters? Will these be pb'd? Or should we go to the bother of making all filters VersionedWritables?
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Priority: Minor
> Attachments: HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242613#comment-13242613 ]
Hadoop QA commented on HBASE-5667:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520628/HBASE-5667.diff
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1353//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1353//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1353//console
This message is automatically generated.
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Assignee: David Arthur
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5667.diff, HBASE-5667.diff, HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "David Arthur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Arthur updated HBASE-5667:
--------------------------------
Attachment: HBASE-5667.diff
* Changed constructor to (String, int)
* Added example in docs
* Removed DOTALL from (String) constructor
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Priority: Minor
> Attachments: HBASE-5667.diff, HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "Zhihong Yu (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu reassigned HBASE-5667:
---------------------------------
Assignee: David Arthur
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Assignee: David Arthur
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5667.diff, HBASE-5667.diff, HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242508#comment-13242508 ]
Zhihong Yu commented on HBASE-5667:
-----------------------------------
The new test failures are most likely inherited from TRUNK which were caused by HBASE-5673
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Priority: Minor
> Attachments: HBASE-5667.diff, HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "Jimmy Xiang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241870#comment-13241870 ]
Jimmy Xiang commented on HBASE-5667:
------------------------------------
For this patch, it changes the constructor of RegexStringComparator. A Pattern is hard to be pb'd. Can we specify the flags in a different way,
for example, using string, and/or some primitive parameters?
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Priority: Minor
> Attachments: HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242521#comment-13242521 ]
Zhihong Yu commented on HBASE-5667:
-----------------------------------
I think we should keep the Pattern.DOTALL in (String) constructor:
{code}
- this.pattern = Pattern.compile(expr, Pattern.DOTALL);
+ this.pattern = Pattern.compile(expr);
{code}
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Priority: Minor
> Attachments: HBASE-5667.diff, HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241940#comment-13241940 ]
stack commented on HBASE-5667:
------------------------------
Yeah, it looks like we can do the String plus int for flags as David suggests given thats all it takes to create a Pattern instance: http://docs.oracle.com/javase/6/docs/api/java/util/regex/Pattern.html#compile(java.lang.String, int)
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Priority: Minor
> Attachments: HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "David Arthur (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240818#comment-13240818 ]
David Arthur commented on HBASE-5667:
-------------------------------------
@Zhihong, yes it would be incompatible if it tried to read Filters that were serialized with the current code. I'm assuming that these Filters are ephemeral and aren't stored anywhere (could be a very wrong assumption).
Otherwise, the purpose of this patch is to expose the ability to add regex flags to the comparator. E.g., if I want a case-insensitive match I could construct a Filter like:
{code}
new SingleColumnValueFilter(COLUMN_FAMILY, COLUMN_QUALIFIER, CompareOp.EQUAL,
new RegexStringComparator(Pattern.compile("foo", Pattern.CASE_INSENSITIVE | Pattern.DOTALL)));
{code}
Also, in the current code, DOTALL is added to the underlying Pattern, but doesn't appear to be applied when deserializing.
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Priority: Minor
> Attachments: HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5667:
-------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to trunk a while back.
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: Filters
> Reporter: David Arthur
> Assignee: David Arthur
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5667.diff, HBASE-5667.diff, HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "Jimmy Xiang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241914#comment-13241914 ]
Jimmy Xiang commented on HBASE-5667:
------------------------------------
Pattern is fine if we can get it.
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Priority: Minor
> Attachments: HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242531#comment-13242531 ]
stack commented on HBASE-5667:
------------------------------
Yes, and call through to the other constructor so its super(expr, Pattern.DOTALL).
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Priority: Minor
> Attachments: HBASE-5667.diff, HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242496#comment-13242496 ]
Hadoop QA commented on HBASE-5667:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520612/HBASE-5667.diff
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestRestartCluster
org.apache.hadoop.hbase.client.TestMetaMigrationRemovingHTD
org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding
org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole
org.apache.hadoop.hbase.catalog.TestCatalogTrackerOnCluster
org.apache.hadoop.hbase.master.TestMasterFailover
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.TestMultiVersions
org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1352//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1352//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1352//console
This message is automatically generated.
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Priority: Minor
> Attachments: HBASE-5667.diff, HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240978#comment-13240978 ]
stack commented on HBASE-5667:
------------------------------
Patch looks good. We could commit it as is to trunk since the next release is going to 'incompatible' anyways, 0.96 (Should take the opportunity and make everything subclass versionedwritable but better, Writables should be on their way out)
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Priority: Minor
> Attachments: HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "David Arthur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Arthur updated HBASE-5667:
--------------------------------
Status: Patch Available (was: Open)
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Priority: Minor
> Attachments: HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240839#comment-13240839 ]
Zhihong Yu commented on HBASE-5667:
-----------------------------------
Maintaining backward compatibility would be desirable.
Would moving the read of flags to after the following line be better ?
{code}
final String charset = in.readUTF();
{code}
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Priority: Minor
> Attachments: HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "David Arthur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Arthur updated HBASE-5667:
--------------------------------
Attachment: HBASE-5667.diff
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Priority: Minor
> Attachments: HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242672#comment-13242672 ]
Zhihong Yu commented on HBASE-5667:
-----------------------------------
Patch v3 integrated to TRUNK.
Thanks for the patch David.
Thanks for the review Stack.
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Assignee: David Arthur
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5667.diff, HBASE-5667.diff, HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240778#comment-13240778 ]
Hadoop QA commented on HBASE-5667:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520321/HBASE-5667.diff
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1334//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1334//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1334//console
This message is automatically generated.
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Priority: Minor
> Attachments: HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "David Arthur (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241197#comment-13241197 ]
David Arthur commented on HBASE-5667:
-------------------------------------
Anything needed from me to get this in?
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Priority: Minor
> Attachments: HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240753#comment-13240753 ]
Zhihong Yu commented on HBASE-5667:
-----------------------------------
This is an incompatible change, right ?
{code}
- this.pattern = Pattern.compile(expr);
+ int flags = in.readInt();
+ this.pattern = Pattern.compile(expr, flags);
{code}
What's the advantage of passing Pattern directly ?
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Priority: Minor
> Attachments: HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242615#comment-13242615 ]
Zhihong Yu commented on HBASE-5667:
-----------------------------------
Patch v3 looks good.
Will integrate later if there is no objection.
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Assignee: David Arthur
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5667.diff, HBASE-5667.diff, HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5667:
------------------------------
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Assignee: David Arthur
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5667.diff, HBASE-5667.diff, HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "David Arthur (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241905#comment-13241905 ]
David Arthur commented on HBASE-5667:
-------------------------------------
If I'm not mistaken, a Pattern is just the pattern string and the flags. The constructor could just as easily be (String, int) rather than a Pattern instance if that jives better with pb
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Priority: Minor
> Attachments: HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5667) RegexStringComparator supports
java.util.regex.Pattern flags
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5667:
------------------------------
Comment: was deleted
(was: -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520612/HBASE-5667.diff
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestRestartCluster
org.apache.hadoop.hbase.client.TestMetaMigrationRemovingHTD
org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding
org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole
org.apache.hadoop.hbase.catalog.TestCatalogTrackerOnCluster
org.apache.hadoop.hbase.master.TestMasterFailover
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.TestMultiVersions
org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1352//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1352//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1352//console
This message is automatically generated.)
> RegexStringComparator supports java.util.regex.Pattern flags
> ------------------------------------------------------------
>
> Key: HBASE-5667
> URL: https://issues.apache.org/jira/browse/HBASE-5667
> Project: HBase
> Issue Type: Improvement
> Components: filters
> Reporter: David Arthur
> Assignee: David Arthur
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5667.diff, HBASE-5667.diff, HBASE-5667.diff
>
>
> * Add constructor that takes in a Pattern
> * Add Pattern's flags to Writable fields, and actually use them when recomposing the Filter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira