You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "zyfeier (via GitHub)" <gi...@apache.org> on 2023/08/02 11:22:31 UTC

[GitHub] [nuttx] zyfeier opened a new pull request, #10008: Arm64: get_cpu_id according to the correct affinity level

zyfeier opened a new pull request, #10008:
URL: https://github.com/apache/nuttx/pull/10008

   ## Summary
   
   Get cpuid according to the correct affinity level and set boot cpuid according to the mpidr.
   
   ## Impact
   
   ARM64 SMP
   
   ## Testing
   
   fvp-armv8r:nsh_smp and qemu-armv8a:nsh_smp ostest pass


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10008: Arm64: get_cpu_id according to the correct affinity level

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10008:
URL: https://github.com/apache/nuttx/pull/10008#discussion_r1282803654


##########
arch/arm64/src/common/arm64_cpustart.c:
##########
@@ -142,9 +142,9 @@ static void arm64_smp_init_top(void *arg)
 static void arm64_start_cpu(int cpu_num, char *stack, int stack_sz,
                             arm64_cpustart_t fn)
 {
-  uint64_t cpu_mpid;
-
-  cpu_mpid = arm64_get_mpid(cpu_num);
+#ifdef CONFIG_ARCH_HAVE_PSCI

Review Comment:
   why check CONFIG_ARCH_HAVE_PSCI



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] zyfeier commented on a diff in pull request #10008: Arm64: get_cpu_id according to the correct affinity level

Posted by "zyfeier (via GitHub)" <gi...@apache.org>.
zyfeier commented on code in PR #10008:
URL: https://github.com/apache/nuttx/pull/10008#discussion_r1282920106


##########
arch/arm64/src/common/arm64_cpustart.c:
##########
@@ -142,9 +142,9 @@ static void arm64_smp_init_top(void *arg)
 static void arm64_start_cpu(int cpu_num, char *stack, int stack_sz,
                             arm64_cpustart_t fn)
 {
-  uint64_t cpu_mpid;
-
-  cpu_mpid = arm64_get_mpid(cpu_num);
+#ifdef CONFIG_ARCH_HAVE_PSCI

Review Comment:
   second commit delete CONFIG_ARCH_HAVE_PSCI



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 merged pull request #10008: Arm64: get_cpu_id according to the correct affinity level

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #10008:
URL: https://github.com/apache/nuttx/pull/10008


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org